Workboard: fix CTRL+click on "Create Task" and "Edit Task"
ClosedPublic
Actions

Authored by valerio.bozzolan on Tue, Mar 7, 12:35.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15157: "Create Task" and "Edit Task" should open links in a new tab when CTRL-click

Commits

rPc6f56b8221ba: Workboard: fix CTRL+click on "Create Task" and "Edit Task"

Summary

The CTRL+click now opens the links in a new tab, like any other
normal link opened with CTRL+click.

Note that the middle-click was already working.

Closes T15157

Test Plan

visit a Workboard
column > menu > mouse on "Create Task"
- CTRL+click: open in new tab (→ now works)
- normal click: open the pop-up (→ still works)
- middle-click: open in new tab (→ still works)
column > single Task > mouse on "Edit"
- CTRL+click: open in new tab (→ now works)
- normal click: open the pop-up (→ still works)
- middle-click: open in new tab (→ still works)

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.Tue, Mar 7, 12:35

Owners added a reviewer: O1: Blessed Committers.Tue, Mar 7, 12:35

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptTue, Mar 7, 12:35

valerio.bozzolan requested review of this revision.Tue, Mar 7, 12:35

Harbormaster completed remote builds in B127: Diff 334.Tue, Mar 7, 12:35

I tried to keep the diff as much small as possible. That is why I just added a small piece of code with a return; instead of a bigger refactoring.

So the goal is:

stop other listeners: that's why I've adopted stop()
don't prevent anything: that's why I've not called prevent()
don't open the pop-up: that's why I've set that return;

This patch also tries improves the user experience of this diff:

D25068: Add project slug to tags query param in create action URLs on workboard column menus

Anyway we can approve and land this or that in any order.

valerio.bozzolan awarded a token.Sat, Mar 11, 22:32

In D25072#2285, @valerio.bozzolan wrote:

So the goal is:

stop other listeners: that's why I've adopted stop()

don't prevent anything: that's why I've not called prevent()

don't open the pop-up: that's why I've set that return;