Page MenuHomePhorge

Workboard: fix CTRL+click on "Create Task" and "Edit Task"
ClosedPublic

Authored by valerio.bozzolan on Tue, Mar 7, 12:35.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 21, 09:14
Unknown Object (File)
Tue, Mar 21, 00:43
Unknown Object (File)
Fri, Mar 17, 17:36
Tokens
"Dat Boi" token, awarded by valerio.bozzolan.

Details

Summary

The CTRL+click now opens the links in a new tab, like any other
normal link opened with CTRL+click.

Note that the middle-click was already working.

Closes T15157

Test Plan
  • visit a Workboard
  • column > menu > mouse on "Create Task"
    • CTRL+click: open in new tab (→ now works)
    • normal click: open the pop-up (→ still works)
    • middle-click: open in new tab (→ still works)
  • column > single Task > mouse on "Edit"
    • CTRL+click: open in new tab (→ now works)
    • normal click: open the pop-up (→ still works)
    • middle-click: open in new tab (→ still works)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I tried to keep the diff as much small as possible. That is why I just added a small piece of code with a return; instead of a bigger refactoring.

So the goal is:

  • stop other listeners: that's why I've adopted stop()
  • don't prevent anything: that's why I've not called prevent()
  • don't open the pop-up: that's why I've set that return;

This patch also tries improves the user experience of this diff:

D25068: Add project slug to tags query param in create action URLs on workboard column menus

Anyway we can approve and land this or that in any order.

So the goal is:

  • stop other listeners: that's why I've adopted stop()
  • don't prevent anything: that's why I've not called prevent()
  • don't open the pop-up: that's why I've set that return;

The funny part is: every time I read this comment I'm even more confused. But hey, it works.

This revision is now accepted and ready to land.Sat, Mar 18, 08:11