Page MenuHomePhorge
Feed All Stories

Wed, Apr 9

aklapper removed a subtask for T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4: T15354: Exception when trying to create Pholio mock without name.
Wed, Apr 9, 08:38 · PHP 8 support
mturdus closed T15536: PHP 8.1 bug reports from mturdus, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Wed, Apr 9, 07:17 · PHP 8 support
mturdus closed D25256: Fix PHP 8.1 "strlen(null)" exception on auth email message body when PhabricatorAuthMessage is unset.
Wed, Apr 9, 07:17 · PHP 8 support
mturdus closed T15536: PHP 8.1 bug reports from mturdus as Resolved by committing rP99834dd061aa: Fix PHP 8.1 "strlen(null)" exception on auth email message body when….
Wed, Apr 9, 07:17 · Bug Reports, PHP 8 support
mturdus committed rP99834dd061aa: Fix PHP 8.1 "strlen(null)" exception on auth email message body when….
Wed, Apr 9, 07:17

Tue, Apr 8

aklapper requested review of D25955: Unhandled Exception: Add last call to error message.
Tue, Apr 8, 18:24
aklapper added a revision to T15689: built in exception display is missing top line: D25955: Unhandled Exception: Add last call to error message.
Tue, Apr 8, 18:24 · Wikimedia Hackathon 2025, Phorge Development Tools
aklapper edited the content of Next Up.
Tue, Apr 8, 17:17
mainframe98 closed T16024: Tech Debt: Remove PHP mysql extension related code as Resolved by committing rP0f7e76ffe4f2: Remove support for PHP mysql extension.
Tue, Apr 8, 16:54
mainframe98 closed D25946: Remove support for PHP mysql extension.
Tue, Apr 8, 16:54
mainframe98 committed rP0f7e76ffe4f2: Remove support for PHP mysql extension.
Tue, Apr 8, 16:54
aklapper requested review of D25954: PHPDoc: Correct marker in one class header.
Tue, Apr 8, 16:07
aklapper requested review of D25953: PHPDoc: Replace invalid "key" and "value" types.
Tue, Apr 8, 15:49
aklapper requested review of D25952: PHPDoc: Replace invalid "obj" with "object".
Tue, Apr 8, 15:44
aklapper requested review of D25951: PHPDoc: Replace invalid "obj" with "object".
Tue, Apr 8, 15:36
aklapper closed D25937: PHPDoc: Make some parameter types match type in signatures.
Tue, Apr 8, 09:00
aklapper committed rP75d8c84c1372: PHPDoc: Make some parameter types match type in signatures.
Tue, Apr 8, 09:00
aklapper closed D25941: PhabricatorCustomField: Fix a typo in PHPDoc.
Tue, Apr 8, 09:00
aklapper committed rPbf39f021d626: PhabricatorCustomField: Fix a typo in PHPDoc.
Tue, Apr 8, 09:00
aklapper closed T15992: PHP 8.1 "strlen(null)" exception adding an MFA provider, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Tue, Apr 8, 08:59 · PHP 8 support
aklapper closed T15992: PHP 8.1 "strlen(null)" exception adding an MFA provider as Resolved by committing rPef3e0a75f62e: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Tue, Apr 8, 08:59 · Auth, PHP 8 support
aklapper closed D25867: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Tue, Apr 8, 08:59
aklapper committed rPef3e0a75f62e: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Tue, Apr 8, 08:59
avivey accepted D25937: PHPDoc: Make some parameter types match type in signatures.
Tue, Apr 8, 06:16
avivey accepted D25941: PhabricatorCustomField: Fix a typo in PHPDoc.
Tue, Apr 8, 06:15
avivey accepted D25867: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Tue, Apr 8, 06:15

Mon, Apr 7

nib added a comment to Q173: Why do Milestones in parent project's Workboard seemingly randomly hide tasks?.

I patched this in our local repo with a change to /src/applications/project/engine/PhabricatorBoardLayoutEngine.php, in the layoutBoard() method. Around line 520, inside if ($proxy_hits) block, you have array_slice() taking the first element of $proxy_hits, which seems random.

Mon, Apr 7, 23:54
aklapper closed T16025: Tech Debt: Complete session digest migration from SHA1 to SHA256 as Resolved by committing rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256.
Mon, Apr 7, 21:46
aklapper closed D25949: Complete session digest migration from SHA1 to SHA256.
Mon, Apr 7, 21:46
aklapper committed rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256.
Mon, Apr 7, 21:46
aklapper accepted D25256: Fix PHP 8.1 "strlen(null)" exception on auth email message body when PhabricatorAuthMessage is unset.

@mturdus: Could you land this one please, or would you like any help? Thanks!

Mon, Apr 7, 21:23 · PHP 8 support
aklapper accepted D25946: Remove support for PHP mysql extension.
  • Apply this patch on a Fedora 42 system with PHP 8.4.5. php -m listed mysqli, mysqlnd, pdo_mysql etc.
  • Uninstall php-mysqlnd package. After reboot, php -m does not list those three modules anymore, and Phorge complains Required PHP extensions are not installed: mysqli as expected.
  • Install package again, Phorge works: "Unresolved setup issues" still lists the same MySQL related stuff as before; /config/clusters/databases shows entry as usual; successfully filed a Maniphest task.
  • Open /etc/php.ini and set mysqli.allow_local_infile = On. Restart Apache HTTPD. "Unresolved setup issues" in Phorge shows Unsafe "MySQL "local_infile" Setting Enabled as expected.
Mon, Apr 7, 21:13
aklapper updated the test plan for D25950: Remove PHP APC support and APC references.
Mon, Apr 7, 20:47
aklapper updated the test plan for D25949: Complete session digest migration from SHA1 to SHA256.
Mon, Apr 7, 20:43
aklapper updated the summary of D25942: Herald Transcripts: Use μs instead of us for microseconds.
Mon, Apr 7, 20:15
aklapper closed D25933: Remove several unused private functions.
Mon, Apr 7, 20:14
aklapper committed rPd5ade92fd0d4: Remove several unused private functions.
Mon, Apr 7, 20:14
aklapper edited the content of Next Up.
Mon, Apr 7, 20:13
aklapper closed D25947: Remove setup check for safe_mode removed in PHP 5.4.
Mon, Apr 7, 20:12
aklapper committed rP969904e7fa3f: Remove setup check for safe_mode removed in PHP 5.4.
Mon, Apr 7, 20:12

Apr 7 2025

Siz3r303 awarded F2660603: profile a Evil Spooky Haunted Tree token.
Apr 7 2025, 15:50
Siz3r303 added a comment to F3363410: NEiN iN NiNE - created by SIMON BOSTON.

NEiN iN NiNE - created by SIMON BOSTON

Apr 7 2025, 15:48
avivey accepted D25947: Remove setup check for safe_mode removed in PHP 5.4.
Apr 7 2025, 06:08

Apr 6 2025

mainframe98 accepted D25947: Remove setup check for safe_mode removed in PHP 5.4.

Setup phorge, saw nothing unusual in the setup issues.

Apr 6 2025, 10:50
avivey accepted D25949: Complete session digest migration from SHA1 to SHA256.

Sure, 7 years is probably long enough to migrate cookies.

Apr 6 2025, 06:53

Apr 5 2025

20after4 added a comment to Q175: Instant messaging not working, disconnected.

One other thing to check: The chat uses wss (websocket) connection to communicate with aphlict. It's possible that a firewall or reverse proxy may be blocking the connection? Not all proxies support websockets in their default configuration.

Apr 5 2025, 18:22
valerio.bozzolan added a task to D25948: Remove setup check for PHP 7.0: T15047: Officially raise minimum required PHP version to 7.2.
Apr 5 2025, 17:31
valerio.bozzolan added a revision to T15047: Officially raise minimum required PHP version to 7.2: D25948: Remove setup check for PHP 7.0.
Apr 5 2025, 17:31 · Phorge
valerio.bozzolan edited the content of Next Up.
Apr 5 2025, 17:30
aklapper requested review of D25950: Remove PHP APC support and APC references.
Apr 5 2025, 17:04
Cigaryno edited the content of Dependencies.
Apr 5 2025, 16:51
Cigaryno edited the content of Welcome to the Phorge Wiki.
Apr 5 2025, 16:45 · Phorge
aklapper updated the diff for D25947: Remove setup check for safe_mode removed in PHP 5.4.

git rebase master

Apr 5 2025, 14:05
aklapper closed D25948: Remove setup check for PHP 7.0.
Apr 5 2025, 14:02
aklapper committed rPadc199eb4abb: Remove setup check for PHP 7.0.
Apr 5 2025, 14:02
mainframe98 updated the diff for D25946: Remove support for PHP mysql extension.

Update documentation and simplify extension check

Apr 5 2025, 14:01
aklapper requested review of D25949: Complete session digest migration from SHA1 to SHA256.
Apr 5 2025, 14:00
aklapper added a revision to T16025: Tech Debt: Complete session digest migration from SHA1 to SHA256: D25949: Complete session digest migration from SHA1 to SHA256.
Apr 5 2025, 14:00
valerio.bozzolan accepted D25948: Remove setup check for PHP 7.0.

sgtm

Apr 5 2025, 13:57
aklapper requested review of D25948: Remove setup check for PHP 7.0.
Apr 5 2025, 13:44
aklapper requested review of D25947: Remove setup check for safe_mode removed in PHP 5.4.
Apr 5 2025, 13:39
aklapper requested changes to D25946: Remove support for PHP mysql extension.

Nearly perfect (thanks!), only thing missing is to also update mysql (or mysqli) in src/docs/user/installation_guide.diviner.

Apr 5 2025, 13:12
mainframe98 removed a task from D25946: Remove support for PHP mysql extension: T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4).
Apr 5 2025, 12:07
mainframe98 removed a revision from T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4): D25946: Remove support for PHP mysql extension.
Apr 5 2025, 12:07 · Deprecation Notice, PHP 8 support, Bug Reports
mainframe98 updated the summary of D25946: Remove support for PHP mysql extension.
Apr 5 2025, 12:06
mainframe98 updated the diff for D25946: Remove support for PHP mysql extension.

Ran bin/celerity map

Apr 5 2025, 12:04
mainframe98 requested review of D25946: Remove support for PHP mysql extension.
Apr 5 2025, 12:03
mainframe98 added a revision to T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4): D25946: Remove support for PHP mysql extension.
Apr 5 2025, 12:03 · Deprecation Notice, PHP 8 support, Bug Reports
mainframe98 added a revision to T16024: Tech Debt: Remove PHP mysql extension related code: D25946: Remove support for PHP mysql extension.
Apr 5 2025, 12:03
aklapper created T16025: Tech Debt: Complete session digest migration from SHA1 to SHA256.
Apr 5 2025, 09:50
aklapper added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

Phorge supports either the old mysql extension or mysqli - and mysql was deprecated in PHP 5.5, and removed in PHP 7.0.

Apr 5 2025, 09:42
aklapper created T16024: Tech Debt: Remove PHP mysql extension related code.
Apr 5 2025, 09:41
aklapper updated the summary of D25886: Remove use of deprecated E_STRICT PHP constant.
Apr 5 2025, 09:24
aklapper updated the summary of D25887: Remove use of deprecated E_STRICT PHP constant.
Apr 5 2025, 09:24
aklapper added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

I cannot remember how I attempted (and failed) to check a few weeks ago... Thank you both for jumping in and correcting!

Apr 5 2025, 09:21

Apr 4 2025

20after4 added a comment to T15948: Allow public API access when equivalent public web access exists.
Apr 4 2025, 10:01 · Policy, Conduit, Phorge
valerio.bozzolan edited the content of Change Log.
Apr 4 2025, 07:17

Apr 3 2025

keithzg added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

Yeah I was also pretty sure Phab used mysqli? I have had to have it on all my installations, and the Phorge documentation still cites it. https://we.phorge.it/book/contrib/article/database/

Apr 3 2025, 17:36
mainframe98 added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

Phorge neither uses PHP's mysqli extension nor calls PHP's htmlentities() function.

Are you sure about that? Phorge supports either the old mysql extension or mysqli - and mysql was deprecated in PHP 5.5, and removed in PHP 7.0. Notably, Phorge checks for the existence of mysqli in PhabricatorDatabaseRef, PhabricatorExtensionSetupCheck and PhabricatorPHPConfigSetupCheck.

Apr 3 2025, 17:07
Cigaryno updated the task description for T15948: Allow public API access when equivalent public web access exists.
Apr 3 2025, 11:16 · Policy, Conduit, Phorge
valerio.bozzolan resigned from rP67b7181f5226: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.
Apr 3 2025, 07:43

Apr 2 2025

aklapper updated subscribers of T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated.

Patch based on my understanding of taavi's comments in T15963 (as I fail to set up an LDAP server locally):

diff --git a/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php b/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php
index 14047c1761..e25659a4aa 100644
--- a/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php
+++ b/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php
@@ -305,7 +305,16 @@ final class PhutilLDAPAuthAdapter extends PhutilAuthAdapter {
           'port' => $this->port,
         ));
Apr 2 2025, 21:43 · Deprecation Notice, PHP 8 support
aklapper added a comment to rP67b7181f5226: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.

@valerio.bozzolan Could you remove the concern so this isn't listed on https://we.phorge.it/diffusion/commit/ for me? Thanks :)

Apr 2 2025, 20:19
aklapper edited the content of Welcome to the Phorge Wiki.
Apr 2 2025, 20:17 · Phorge
Cigaryno added a comment to T15948: Allow public API access when equivalent public web access exists.

There must be a function that allows Conduit methods to be used by logged-out users. It's just that there are hardly any methods using that function.

Apr 2 2025, 18:16 · Policy, Conduit, Phorge
Cigaryno updated the task description for T15948: Allow public API access when equivalent public web access exists.
Apr 2 2025, 18:11 · Policy, Conduit, Phorge
Cigaryno added a comment to T15948: Allow public API access when equivalent public web access exists.

There must be a function that allows Conduit methods to be used by logged-out users. It's just that there are hardly any methods using that function.

Apr 2 2025, 18:11 · Policy, Conduit, Phorge
aklapper closed T15640: Errors when a commit belongs to a numeric git branch: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php as Resolved by committing rP17033a1c70d8: Fix exception handling a numeric git branch ("Call to phutil_nonempty_string()….
Apr 2 2025, 13:09 · Bug Reports, Affects-Wikimedia
aklapper closed D25945: Fix exception handling a numeric git branch ("Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository).
Apr 2 2025, 13:09
aklapper committed rP17033a1c70d8: Fix exception handling a numeric git branch ("Call to phutil_nonempty_string()….
Apr 2 2025, 13:09
aklapper updated the diff for D25945: Fix exception handling a numeric git branch ("Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository).

add PHPDoc

Apr 2 2025, 13:07
valerio.bozzolan accepted D25945: Fix exception handling a numeric git branch ("Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository).

Check if the comments are interesting - thanks for this Phorgi patchi that seems lovely

Apr 2 2025, 12:03
aklapper requested review of D25945: Fix exception handling a numeric git branch ("Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository).
Apr 2 2025, 11:55
aklapper added a revision to T15640: Errors when a commit belongs to a numeric git branch: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php: D25945: Fix exception handling a numeric git branch ("Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository).
Apr 2 2025, 11:55 · Bug Reports, Affects-Wikimedia
valerio.bozzolan renamed T15640: Errors when a commit belongs to a numeric git branch: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php from Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php to Errors when a commit belongs to a numeric git branch: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.
Apr 2 2025, 11:23 · Bug Reports, Affects-Wikimedia
valerio.bozzolan added a comment to T15640: Errors when a commit belongs to a numeric git branch: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

I'm still a bit shocked by how PHP is so weird. So:

Apr 2 2025, 09:55 · Bug Reports, Affects-Wikimedia
valerio.bozzolan added a comment to T15640: Errors when a commit belongs to a numeric git branch: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

Wow. 10 years of PHP, first time that I notice this

Apr 2 2025, 09:45 · Bug Reports, Affects-Wikimedia
aklapper added a comment to T15640: Errors when a commit belongs to a numeric git branch: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.

https://www.php.net/manual/en/language.types.array.php#language.types.array.syntax :

Strings containing valid decimal ints, unless the number is preceded by a + sign, will be cast to the int type.

Apr 2 2025, 00:00 · Bug Reports, Affects-Wikimedia

Apr 1 2025

aklapper closed D25943: PHPDoc: Replace non-existing return type phid with string.
Apr 1 2025, 23:15
aklapper committed rARC93930454c58a: PHPDoc: Replace non-existing return type phid with string.
Apr 1 2025, 23:15