- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Aug 11 2024
Aug 11 2024
aklapper requested review of D25771: Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider.
aklapper closed T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
valerio.bozzolan moved T15906: Add unit tests for Calendar imports from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
valerio.bozzolan updated the test plan for D25768: Fix PHP 8.1 "strlen(null)" exception in DivinerFindController.
Not sure what "similar working links" means... Something like https://we.phorge.it/diviner/find/?name=PhutilSafeHTML ?
aklapper renamed T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef from PHP 8.1 "strlen(null)" exception in DivinerAtomRef to PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Is this also the reason why links to e.g. https://we.phorge.it/diviner/find/?name=JX.behavior&type=function&jump=1 on https://we.phorge.it/book/javelin/article/behaviors/ or to http://we.phorge.it/diviner/find/?name=JX.Stratcom&type=class&jump=1 are 404s, or do I misunderstand and that's a separate issue?
Urgh. In calling https://we.phorge.it/source/phorge/browse/master/src/applications/diviner/query/DivinerAtomQuery.php$340 , $this->titles is an array which has a length of 1, with its only member being null. Sounds like there's already something fishy before.
valerio.bozzolan added a comment to T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController.
Where I can find similar working links? I've tried generating Diviner books for both Arcanist and Phorge but http://phorge.localhost/diviner/find/?name=JX.Stratcom is still giving me 404
aklapper updated the diff for D25738: Avoid RuntimeException on "Skip past this commit" when commit still importing.
Thanks for finding a way to reproduce! I still fail to find the right timing here to produce a testcase, so this is another untested shot in the dark.
aklapper added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).
No, as project membership is unrelated to task object policy, as a task can associated to more than one project.
Aug 10 2024
Aug 10 2024
valerio.bozzolan added a comment to D25051: Destroy file attachments when file is deleted, or object is deleted.
Just for the glory of the archive. I've tested this feature in production before landing.
valerio.bozzolan added a comment to D25617: docs/file_domain: remove cloudflare mention of autominify.
I guess this is the time. Feel free to land as usual with
valerio.bozzolan committed rP2b7c0ec92f6c: Destroy file attachments when file is deleted, or object is deleted (authored by Dylsss).
valerio.bozzolan closed T15896: Explore How-To Permanently Destroy Things in Phorge, a subtask of T15110: File reference not removed when file is deleted, as Resolved.
Well, I doubt we can dig more than this.
I think that is complex because some admins are not well active on their platforms, so as said before it can be underdimensioned
Aug 9 2024
Aug 9 2024
valerio.bozzolan added a project to T15905: Linter: do not break "ics" files: User-valerio.bozzolan.
valerio.bozzolan moved T15256: Diffusion file: add a way to copy permalink from PingDeath 🌚 to Code Sprint Candidate on the User-valerio.bozzolan board.
revi renamed T15908: More Useful "Quick Create" button on Workboard Columns from More Useful "Quick Create" button on Wo rboard Columns to More Useful "Quick Create" button on Workboard Columns.
revi renamed T15908: More Useful "Quick Create" button on Workboard Columns from More Useful "Quick Create" button on Worboard Columns to More Useful "Quick Create" button on Wo rboard Columns.
@aklapper I see. What do you think about D25301#15795 ?
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).
- updated screenshot access to All Users
- thanks, that task would solve the problem!
- alternatively, "Project Members" option could be made available as an object policy for tasks
@valerio.bozzolan also, triggers don't offer an option to change task space or task access.
valerio.bozzolan requested changes to D25738: Avoid RuntimeException on "Skip past this commit" when commit still importing.
OK. Full immersion mode 🌈
valerio.bozzolan added inline comments to D25733: Do not throw Aphront400Response when editing a task.
valerio.bozzolan added inline comments to D25738: Avoid RuntimeException on "Skip past this commit" when commit still importing.
Aug 8 2024
Aug 8 2024
valerio.bozzolan added a comment to T15888: RuntimeException using "Skip past this commit" to access a commit still importing: "reset() expects parameter 1 to be array, null given".
I'm trying to reproduce, creating a repository, stopping phlog, and pushing, and starting and immediately randomly stopping phlog.
At the moment we have a multi-thread command existence checker, and it early dies if a command is not existing.
avivey moved T15908: More Useful "Quick Create" button on Workboard Columns from Backlog to Feature Requests on the Workboard board.
I wonder if "Workboard Triggers" may do the job here.
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).
I've filed T15908 for the "quick create from column to do what I mean".
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).
(@arp - the images you pasted did not get Attached, so they are Private; Please set them manually to Public so they can be seen. We have an open ticket for that somewhere)
valerio.bozzolan retitled D25363: Calendar Import: calendar uploader is not anymore an alien from Match yourself from Imported Events Invitees
valerio.bozzolan updated the diff for D25363: Calendar Import: calendar uploader is not anymore an alien.
be based on unit tests
It's 3 days past the scheduled execution date but the settings in dashboard and docs are still there.
I see. So, is that functionality already a part of arc diff? In other words, if arc work T123 would have worked exactly the same way as arc work branch-name (by creating a branch that's called either T123 or branch-name), then arc diff would correctly link it?
Aug 7 2024
Aug 7 2024
Yes - it works seamlessly because if the local branch has a task number in it, the diff is automatically linked to that task when you run arc diff
OK thanks
It's probably better to exclude ICS files from TXT in .arclint, or define their own section, rather then add hard-coded exceptions in here.
aklapper closed T15902: PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper closed T15472: Support Open Graph protocol (at least in Maniphest) as Resolved by committing rP89778dc9e617: Add Open Graph protocol meta tags to Maniphest task pages.
valerio.bozzolan updated the diff for D25766: Arcanist Text Linter: do not break the "ics" special format.
remove unuseful newline
valerio.bozzolan requested review of D25766: Arcanist Text Linter: do not break the "ics" special format.
valerio.bozzolan added a parent task for T15905: Linter: do not break "ics" files: T15906: Add unit tests for Calendar imports.
Oh wow, that is a really unexpected way to create tags.
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).
We have a public project tag used by a team. Some tasks associated with that public project tag are public tasks visible to everyone and anyone, so they are not in an access-restricted Space but default S1. Some tasks associated with that public project tag are temporarily non-public, "secret" tasks that should only be visible to that team and nobody else, so they are in an access-restricted Space that can only be accessed by team members.
aklapper added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).
In my installation this would not be a reasonable expectation. We have a public project tag used by a team. Some tasks associated with that public project tag are public tasks visible to everyone and anyone, so they are not in an access-restricted Space but default S1. Some tasks associated with that public project tag are temporarily non-public, "secret" tasks that should only be visible to that team and nobody else, so they are in an access-restricted Space that can only be accessed by team members.
So I'd rather envision a Herald rule: for a Maniphest task, if is newly created is true && Space is Sxx, then add project tag #whatever. (The other way round is not particularly feasible: The task would have a default view setting for a moment and potentially visible to outsiders, before moving it to a view-restricted Space).
I was confused about why I couldn't tag a task with any random tag that I wanted to create on the fly as I'd do in Meta's Phabricator. It took me some time to realize that tags mean projects.
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).
To clarify: currently existing auto-tagging is not about the column from which the task is created. It's about tagging with the project to which the column belongs.
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).
It's not "impossible" on the technical level, it's just not obviously the right solution.
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).
But also, why is it impossible? When a task is created from a column, it automatically pre-populates the tag column with the project it is created from. It seems trivial to implement a patch that would auto-detect the project's space and set it accordingly for the task.
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).
Then, if every project could choose its own Task Create/Edit Form Configuration, it would solve the issue. Maybe form configurations could be tagged with projects, and when no tag = show for all projects?
I'd assume that it also links the task and the diff together and optionally allows to close the task automatically on diff land?
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0