Fix strlen(null) PHP 8.1 error when pushing into a fresh repository
ClosedPublic
Actions

Authored by Sten on Jul 28 2023, 13:28.

Tags

None

Referenced Files

	F3289465: D25361.1742848200.diff
	Sun, Mar 23, 20:30

	F3254354: D25361.1742463528.diff
	Wed, Mar 19, 09:38

	F3252737: D25361.1742405391.diff
	Tue, Mar 18, 17:29

	F3252646: D25361.1742397176.diff
	Tue, Mar 18, 15:12

	F3249093: D25361.1742281858.diff
	Mon, Mar 17, 07:10

	F3246513: D25361.1742209647.diff
	Sun, Mar 16, 11:07

	F3236417: D25361.1742170241.diff
	Sun, Mar 16, 00:10

	F3223658: D25361.1741998265.diff
	Fri, Mar 14, 00:24

Subscribers

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15569: git push into a fresh repository fails with PHP 8.1 strlen(null) error

Commits

rP189a5d60478e: Fix strlen(null) PHP 8.1 error when pushing into a fresh repository

Summary

Doing a git push into a fresh repository over https fails with a PHP 8.1 strlen(null) error.

This fixes it.

Fixes T15569

Test Plan

Create an empty repository on a PHP 8.1 Phorge instance
Clone it
Add some data
git push

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Sten created this revision.Jul 28 2023, 13:28

Owners added a reviewer: O1: Blessed Committers.Jul 28 2023, 13:28

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 28 2023, 13:28

Harbormaster completed remote builds in B695: Diff 1163.Jul 28 2023, 13:28

Sten requested review of this revision.Jul 28 2023, 13:28

speck accepted this revision.Jul 28 2023, 15:23

This revision is now accepted and ready to land.Jul 28 2023, 15:23

Closed by commit rP189a5d60478e: Fix strlen(null) PHP 8.1 error when pushing into a fresh repository. · Explain WhyJul 28 2023, 17:23

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rP189a5d60478e: Fix strlen(null) PHP 8.1 error when pushing into a fresh repository.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

2 lines

O1: Blessed Committers

Diff 1173

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Fix strlen(null) PHP 8.1 error when pushing into a fresh repositoryClosedPublicActions