Page MenuHomePhorge

PHP 8.1 DifferentialBranchField getBranchDescription strlen(null) error
Closed, ResolvedPublic

Description

Trying to view a diff (eg https://my.phorge.site/D1234) on a PHP 8.1 site fails with a strlen(null) error

Stack trace:

AH01071: Got error 'PHP message: [2023-06-30 08:22:03] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter
#1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]PHP message: arcanist(head=master, ref.master=8130241a11ac, custom=4), phorge(head=master, ref.master=7c1487e4dcfa)PHP message:
#0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/differential/customfield/DifferentialBranchField.php:48]PHP message:
#1 <#2> DifferentialBranchField::getBranchDescription(DifferentialDiff) called at [<phorge>/src/applications/differential/customfield/DifferentialBranchField.php:35]PHP message:
#2 <#2> DifferentialBranchField::renderDiffPropertyViewValue(DifferentialDiff) called at [<phorge>/src/applications/differential/controller/DifferentialRevisionViewController.php:1226]PHP message:
#3 <#2> DifferentialRevisionViewController::buildDiffPropertyList(DifferentialDiff, DifferentialRevision, array) called at [<phorge>/src/applications/differential/controller/DifferentialRevisionViewController.php:1188]PHP message:
#4 <#2> DifferentialRevisionViewController::buildDiffDetailView(array, DifferentialRevision, PhabricatorCustomFieldList) called at [<phorge>/src/applications/differential/controller/DifferentialRevisionViewController.php:344]PHP message:
#5 <#2> DifferentialRevisionViewController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284]PHP message:
#6 phlog(RuntimeException) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]PHP message:
#7 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, RuntimeException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]PHP message:
#8 AphrontApplicationConfiguration::handleThrowable(RuntimeException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:296]PHP message:
#9 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:204]PHP message:
#10 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]'

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.