Page MenuHomePhorge
Feed All Stories

Jul 5 2023

valerio.bozzolan updated the summary of D25322: Blur profile image when user account disabled.
Jul 5 2023, 12:47
valerio.bozzolan accepted D25310: Fix PHP 8.1 "strlen(null)" exception opening a File overlay (Lightbox comment frame).

It took me a little while to understand the problem because I thought we were talking about the blog image, instead this problem probably affects any file in any description of any Task.

Jul 5 2023, 12:46
valerio.bozzolan retitled D25310: Fix PHP 8.1 "strlen(null)" exception opening a File overlay (Lightbox comment frame) from Fix PHP 8.1 "strlen(null)" exception opening image details in a Phame blog post
Jul 5 2023, 12:45
Sten added a comment to D25334: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.
  1. Probably we can avoid to create a "dummy" DifferentialTestCommitMessageField and just use something like DifferentialSubscribersCommitMessageField in the test case
Jul 5 2023, 12:45
valerio.bozzolan awarded T15498: PHP 8.2 "strlen(null)" exception when viewing image details a Doubloon token.
Jul 5 2023, 12:42 · Files, PHP 8 support
valerio.bozzolan added a comment to T15498: PHP 8.2 "strlen(null)" exception when viewing image details.

OK I can reproduce now. I was missing the php-gd extension for some reasons.

Jul 5 2023, 12:42 · Files, PHP 8 support
Sten updated the test plan for D25334: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.
Jul 5 2023, 12:39
Sten updated the diff for D25334: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.

Remove blank line

Jul 5 2023, 12:37
valerio.bozzolan added a comment to D25296: Fix PHP 8.1 "strlen(null)" exception trying to stop maintenance mode of Diffusion repo.

As already said the legacy situation deserved an additional check to me to prevent confusing situations of --stop --start "" wrongly recognized as stopped.

Jul 5 2023, 12:31
Sten updated the diff for D25327: PHP8.1 fix for DiffusionServeController serveRequest().

Try now - adding PHABRICATOR_TESTCONFIG_BUILD_STORAGE_FIXTURES has resolved the Database isolation exception in other test cases I've done.

Jul 5 2023, 12:28
valerio.bozzolan added inline comments to D25307: Dashboard Tabs: fix action "Move Right".
Jul 5 2023, 12:10
valerio.bozzolan added a comment to D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

I know, the attached video is beautiful

Jul 5 2023, 12:07
valerio.bozzolan accepted D25322: Blur profile image when user account disabled.

Originally the image was just set to grayscale using CSS, but now it's also blurred.

Jul 5 2023, 11:52
valerio.bozzolan added a comment to T15524: Discussion: Technical direction of Phorge.

About offering hosting services massively, AFAIK Phorge is already ready for multi-configuration. I mean, you can quickly offer multi-hosting of a Phorge from a very single installation, but having completely different and separated environments, based for example on the incoming request (domain).

Jul 5 2023, 11:42
valerio.bozzolan added a comment to T15498: PHP 8.2 "strlen(null)" exception when viewing image details.

I'm trying to reproduce this, but in my local installation I do not have any allowed file formats. I also do not remember how to make that list available.

Jul 5 2023, 11:38 · Files, PHP 8 support
valerio.bozzolan accepted D25324: Fix PHP 8.1 PhabricatorEditorURIEngine::newForViewer() trim(NULL) error.

Thanks :) Soft +1 to wait for other thoughts. The test plan works for me.

Jul 5 2023, 11:30
valerio.bozzolan added inline comments to D25324: Fix PHP 8.1 PhabricatorEditorURIEngine::newForViewer() trim(NULL) error.
Jul 5 2023, 11:26
valerio.bozzolan accepted D25334: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.

Thanks. Some tips:

Jul 5 2023, 11:17
avivey added a comment to D25327: PHP8.1 fix for DiffusionServeController serveRequest().

I like changes that have unit tests.

Jul 5 2023, 11:05
avivey awarded D25327: PHP8.1 fix for DiffusionServeController serveRequest() a Yellow Medal token.
Jul 5 2023, 11:03
Sten updated the diff for D25334: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.

Handle renderFieldValue in DifferentialRevisionIDCommitMessageField as well

Jul 5 2023, 10:43
valerio.bozzolan added a comment to T15530: arc diff throws PHP 8.1 strlen(null) error from DifferentialCommitMessageField renderFieldValue.

What do you suggest as reproduce steps here?

Jul 5 2023, 10:37 · PHP 8 support
Sten requested review of D25334: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.
Jul 5 2023, 10:34
Sten added a revision to T15530: arc diff throws PHP 8.1 strlen(null) error from DifferentialCommitMessageField renderFieldValue: D25334: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.
Jul 5 2023, 10:34 · PHP 8 support
valerio.bozzolan added a comment to D25327: PHP8.1 fix for DiffusionServeController serveRequest().

Thanks, I love this minimal change.

Jul 5 2023, 10:33
Sten claimed T15530: arc diff throws PHP 8.1 strlen(null) error from DifferentialCommitMessageField renderFieldValue.
Jul 5 2023, 10:30 · PHP 8 support
Sten created T15530: arc diff throws PHP 8.1 strlen(null) error from DifferentialCommitMessageField renderFieldValue.
Jul 5 2023, 10:29 · PHP 8 support
Sten requested review of D25333: Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors.
Jul 5 2023, 09:47
Sten added a revision to T15529: arc diff DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors : D25333: Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors.
Jul 5 2023, 09:47 · PHP 8 support
Sten claimed T15529: arc diff DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors .
Jul 5 2023, 09:41 · PHP 8 support
Sten created T15529: arc diff DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors .
Jul 5 2023, 09:41 · PHP 8 support
avivey added a project to T15526: Diffusion: Description and tags are not shown: Good Starter Task.

I think this is a Good Starter Task...

Jul 5 2023, 09:09 · Diffusion, Good Starter Task, UX
avivey added a comment to T15524: Discussion: Technical direction of Phorge.

(I think I'm still interested in continuing some of this discussion, but I'm far behind on reading it already. I might resurrect [parts of] it later...)

Jul 5 2023, 08:27
valerio.bozzolan added inline comments to D25332: Fix DifferentialGetCommitMessageConduitAPIMethod execute strlen(null).
Jul 5 2023, 08:25
valerio.bozzolan added a comment to T15524: Discussion: Technical direction of Phorge.

It does seem like it is not designed for development use either..

Jul 5 2023, 08:17
Sten requested review of D25332: Fix DifferentialGetCommitMessageConduitAPIMethod execute strlen(null).
Jul 5 2023, 08:16
Sten added a revision to T15527: arc diff <differential.getcommitmessage> strlen(null) PHP 8.1 error: D25332: Fix DifferentialGetCommitMessageConduitAPIMethod execute strlen(null).
Jul 5 2023, 08:16 · PHP 8 support
valerio.bozzolan updated the task description for T15322: Footer: specify a default Libre license for Phorge contents.
Jul 5 2023, 08:15 · Discussion Needed, Governance
valerio.bozzolan added a comment to T15322: Footer: specify a default Libre license for Phorge contents.

Uhm. Have we any idea about how to unlock this situation?

Jul 5 2023, 08:14 · Discussion Needed, Governance
valerio.bozzolan triaged T15528: Diffusion commit Feed: avoid to show the author twice (Authored by xxx) as Wishlist priority.
Jul 5 2023, 08:09 · UX, User-valerio.bozzolan, Diffusion
Sten claimed T15527: arc diff <differential.getcommitmessage> strlen(null) PHP 8.1 error.
Jul 5 2023, 08:01 · PHP 8 support
Sten created T15527: arc diff <differential.getcommitmessage> strlen(null) PHP 8.1 error.
Jul 5 2023, 08:01 · PHP 8 support
valerio.bozzolan added a project to T15526: Diffusion: Description and tags are not shown: UX.

I don't know if this should be a Feature Requests

Jul 5 2023, 07:49 · Diffusion, Good Starter Task, UX
Sten closed T15523: Browsing a file in Diffusion fails under PHP 8.1 with strlen(null) as Resolved by committing rP5e48e16f77fd: Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP….
Jul 5 2023, 07:44 · PHP 8 support
Sten closed T15523: Browsing a file in Diffusion fails under PHP 8.1 with strlen(null), a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jul 5 2023, 07:44 · PHP 8 support
Sten closed D25330: Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP 8.1.
Jul 5 2023, 07:44
Sten committed rP5e48e16f77fd: Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP….
Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP…
Jul 5 2023, 07:44
avivey added inline comments to D25331: Project Hovercards: Show Description.
Jul 5 2023, 07:42
valerio.bozzolan added a comment to T15526: Diffusion: Description and tags are not shown.

The current workaround was to put the Tags in the description. So, adding this feature could cause the Tags to be "somehow shown twice".

Jul 5 2023, 07:42 · Diffusion, Good Starter Task, UX
valerio.bozzolan awarded T15526: Diffusion: Description and tags are not shown a Love token.
Jul 5 2023, 07:38 · Diffusion, Good Starter Task, UX
avivey created T15526: Diffusion: Description and tags are not shown.
Jul 5 2023, 07:29 · Diffusion, Good Starter Task, UX
valerio.bozzolan added a comment to T15525: Create repository for Diagrams, a DrawIO integration.

ihih I always thought the lack of tags was a feature. So I always manually Tagged also the Description. Thanks for the Task.

Jul 5 2023, 07:29 · Phactory: Community Projects
avivey added a comment to T15525: Create repository for Diagrams, a DrawIO integration.

I would like to mention #diagrams_extension in the Repository description, but I do not have enough permissions.

Jul 5 2023, 07:27 · Phactory: Community Projects
valerio.bozzolan added inline comments to D25331: Project Hovercards: Show Description.
Jul 5 2023, 07:26
valerio.bozzolan awarded T15525: Create repository for Diagrams, a DrawIO integration a Love token.
Jul 5 2023, 07:16 · Phactory: Community Projects
valerio.bozzolan added a comment to T15525: Create repository for Diagrams, a DrawIO integration.

I would like to mention #diagrams_extension in the Repository description, but I do not have enough permissions.

Jul 5 2023, 07:09 · Phactory: Community Projects
ton closed T15524: Discussion: Technical direction of Phorge as Spite.
Jul 5 2023, 05:29
ton added a comment to T15524: Discussion: Technical direction of Phorge.

@speck I think I can see now where we have fundamental differences in our views.

Jul 5 2023, 05:29
speck added a comment to T15524: Discussion: Technical direction of Phorge.
  • Is it possible to make Phorge use a different database? Adding SQLite support could greatly reduce complexity and lower the barrier for entry for new developers and allow running Phorge as a standalone app.

Phorge/Phab support a variety of different setups, including support of clustered MySQL/MariaDB databases. Moving to SQLite would be a large undertaking and would not support clustering/replication without major overhauls. For a move like this I can only conceive of many downsides and no benefits.

Jul 5 2023, 03:55
ton added a comment to T15524: Discussion: Technical direction of Phorge.

Thanks for your replies!

Jul 5 2023, 00:26

Jul 4 2023

Cigaryno closed T15525: Create repository for Diagrams, a DrawIO integration as Resolved.

This task is mostly done now that the repository is present and someone made an initial release of Diagram.

Jul 4 2023, 21:37 · Phactory: Community Projects
speck added a comment to T15524: Discussion: Technical direction of Phorge.

It all comes from the fact that PHP was designed for a web 1.0

I don't follow this logic.

Jul 4 2023, 19:51
mturdus committed R5:ee422fb38773: Initial version.
Initial version
Jul 4 2023, 19:37
avivey added a member for Diagrams (Extension): mturdus.
Jul 4 2023, 19:36
avivey renamed T15525: Create repository for Diagrams, a DrawIO integration from Create repository for DrawIO extension (name TBD) to Create repository for Diagrams, a DrawIO integration.
Jul 4 2023, 18:59 · Phactory: Community Projects
avivey added a comment to T15525: Create repository for Diagrams, a DrawIO integration.

And you can manage Diagrams (Extension), which has access to manage the repo.

Jul 4 2023, 18:59 · Phactory: Community Projects
avivey edited Description on Diagrams (Extension).
Jul 4 2023, 18:56
avivey set the color for Diagrams (Extension) to Yellow.
Jul 4 2023, 18:56
avivey created Diagrams (Extension).
Jul 4 2023, 18:55
avivey created T15525: Create repository for Diagrams, a DrawIO integration.
Jul 4 2023, 18:53 · Phactory: Community Projects
avivey added a comment to Q64: File editor extension: updating PhabricatorFile content (Answer 83).

We don't really have a concrete flow setup.
I'll file a task and have you fill some details...

Jul 4 2023, 18:48
mturdus added a comment to Q64: File editor extension: updating PhabricatorFile content (Answer 83).

I'm ready to publish a first version, but I don't understand how to publish it under Phactory?
Do I need to publish on Github first ?

Jul 4 2023, 18:37
avivey added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I think the current actionable steps we can take are:

Jul 4 2023, 18:10 · Discussion Needed, Arcanist
avivey added a comment to T15524: Discussion: Technical direction of Phorge.

Also, I don't know for sure, but I don't believe the technical issues had a serious effect on Phacility's shutdown - I believe it was the business of trying to compete with GitHub in the low end, and with Phabricator on the high-end - Phabricator/Phorge is at its best when it's being managed in-house, with customizations for integration with the rest of the business tools. Using it as a sealed product is missing half the fun.

Jul 4 2023, 17:57
avivey added a comment to T15524: Discussion: Technical direction of Phorge.

I'm not sure what is being suggested.

Jul 4 2023, 17:53
valerio.bozzolan added a comment to T15524: Discussion: Technical direction of Phorge.

Side note: indeed PHP allows threads and async. For example in the Config page, Phorge executes 6+ git commands in async.

Jul 4 2023, 17:52
ton added a comment to T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..

I posted this in a separate thread, but it is definitely related: https://we.phorge.it/T15524

Jul 4 2023, 17:38 · Discussion Needed, Arcanist
ton created T15524: Discussion: Technical direction of Phorge.
Jul 4 2023, 17:37
Cigaryno edited the content of Welcome to the Phorge Wiki.
Jul 4 2023, 16:50 · Phorge
valerio.bozzolan added a comment to rP603cf474ee1d: Fix int fields for now.

The default case was $this->getFieldValue(), so, returning that as-is.

Jul 4 2023, 16:32
valerio.bozzolan closed T15508: Locate File could accept initial "./" to speedup lazy terminal users as Resolved.

\o/

Jul 4 2023, 16:24 · User-valerio.bozzolan, UX, Diffusion
valerio.bozzolan closed D25299: Remarkup Code-block: parse language specifier in markdown.
Jul 4 2023, 16:23
valerio.bozzolan edited the content of Next Up.
Jul 4 2023, 16:23
valerio.bozzolan closed T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks as Resolved by committing rP80484b76a5ff: Remarkup Code-block: parse language specifier in markdown.
Jul 4 2023, 16:23 · Feature Requests, Remarkup
valerio.bozzolan committed rP80484b76a5ff: Remarkup Code-block: parse language specifier in markdown.
Remarkup Code-block: parse language specifier in markdown
Jul 4 2023, 16:23
avivey requested verification of rPd725ffaa7728: Fix "Register with Approval flow" for php 8.
Jul 4 2023, 16:07
avivey accepted D25330: Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP 8.1.
Jul 4 2023, 16:04
avivey requested review of D25331: Project Hovercards: Show Description.
Jul 4 2023, 15:52
avivey added a revision to T15275: Project hover-card should show Description: D25331: Project Hovercards: Show Description.
Jul 4 2023, 15:52 · Projects
Sten requested review of D25330: Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP 8.1.
Jul 4 2023, 15:25
Sten added a revision to T15523: Browsing a file in Diffusion fails under PHP 8.1 with strlen(null): D25330: Update DiffusionDocumentRenderingEngine to cope with null code coverage in PHP 8.1.
Jul 4 2023, 15:25 · PHP 8 support
Sten claimed T15523: Browsing a file in Diffusion fails under PHP 8.1 with strlen(null).
Jul 4 2023, 15:21 · PHP 8 support
Sten created T15523: Browsing a file in Diffusion fails under PHP 8.1 with strlen(null).
Jul 4 2023, 15:21 · PHP 8 support
valerio.bozzolan updated the task description for T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks.
Jul 4 2023, 15:20 · Feature Requests, Remarkup
Sten updated the diff for D25329: Fix passing null to trim() error in DiffusionBrowseTableView render().

Remove earlier changes to DiffusionBrowseTableView

Jul 4 2023, 15:14
Sten requested review of D25329: Fix passing null to trim() error in DiffusionBrowseTableView render().
Jul 4 2023, 15:13
Sten added a revision to T15522: Top level diffusion repository view fails under PHP 8.1 with passing null to trim(): D25329: Fix passing null to trim() error in DiffusionBrowseTableView render().
Jul 4 2023, 15:13 · PHP 8 support
valerio.bozzolan closed D25320: Locate File: allow to search './path/to/something.txt'.
Jul 4 2023, 15:13
valerio.bozzolan committed rP4a0d3ba3e14b: Locate File: allow to search './path/to/something.txt'.
Locate File: allow to search './path/to/something.txt'
Jul 4 2023, 15:13
valerio.bozzolan edited the content of Next Up.
Jul 4 2023, 15:12