remove whitespace

improve even more readability

You are the best, thanks for this tip

Thanks a lot!

Hi @jkimbo thank you for your bug report. Now you are a Trusted Contributors. Feel free to elevate this question as a Task under PHP 8 support

By the way you are now a Trusted Contributors :) Thanks

Ah nice thanks @smith - feel free to move that as Answer

You can do it using HTML tags and literal line breaks, like this:

But you probably already know that, given that the task you quoted was closed by committing this revision.
(<br> doesn't work here, but I think it should, even if it's ignored in plain Remarkup.)

A big bug we have now is the absence of a free license in the footer.

Tagging also as Affects Wikimedia since during Wikimedia Hackaton I've talked with a couple of very friendly staff members from WMF-CiviCRM that would really love this thing.

avoid an extra variable

There is some support for this today, I have worked with dependent revisions in the past. There are some gaps but it’s possible today. I’ll look through my notes but I think this requires a fair amount of additional state tracking as commits change on local machines. I haven’t fully thought through it all but I think an ideal solution would be something like mercurial’s “evolve”, but that is likely a ton of work.

In T15364#8952, @avivey wrote:

"tooling for chains of diffs" might need its own topic, with a design of the what the whole thing should look like in an ideal world, and how to get to it.
Even if not all of the stuff fits nicely into Phorge, there's probably a lot that can work, and some conduit methods can be added to implement the rest.

Breaking this out from the discussion at T15364: arc land complaints summary by FreeBSD community

Last word to our friend @avivey

I'm quite sure we do not cause any nuclear implosion here. Added some things in the test plan

Oh nice, I was able to test the enroll message:

adopt empty string default value, avoiding null

Thanks again for your original troubleshooting and this patch. Probably we hammered this stuff without causing a cute unexpected nuclear implosion, but who knows.

fix a potential PHP pitfall

Tested, no nuclear implosions

replace phutil_nonempty_string() with just an explicit cast to string to answer the question "is this string non empty?"
so this works with integers as well, without crashes.

Thanks for this troubleshooting and this patch (again) :)

minimize this even more, just because we can

I tested this and it totally works. Also, since if this does not use any phutil_() stuff this will not cause any unexpected nuclear implosion.

Thanks avivey, I share the same concerns. Hoping to be useful I've followed these tips to expand the test plan a bit.

Nice shot, really!

For the records, the follow-up is here:

amend a small thing we discussed in live

Thanks again for this patch

Thanks again, I really loved this follow-up on your hack