array_fuse in arcanist is a wrapper for calling array_combine($list, $list). The latter doesn't seem to accept passing null instead of an array in PHP 8.2. Thus pass an empty array instead of null.
Closes T15393
Details
Details
- Reviewers
- None
- Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15393: PHP 8.1 "array_fuse(null)" exception blocks rendering Conduit's "Method Call Result" page
Applied this change; afterwards "Method Call Result" page at /api/project.create correctly displayed in the web browser.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- conduitEatMyKittens (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 408 Build 408: arc lint + arc unit
Event Timeline
Comment Actions
I think we can just have array_fuse() accept null and return an empty list, because it's only there to simplify calling sites.
(The syntax for it in php 5/7 is function array_fuse(array $list = null) {...}).
Comment Actions
Uh right, that makes way more sense to cover numerous such cases in Arcanist instead of playing whack-a-mole in Phorge Conduit. Thanks!
Comment Actions
For the records, the follow-up is here:
D25228: Fix PHP 8.1 exception in Conduit: Make "array_fuse(array $list)" accept null as parameter