Page MenuHomePhorge
Feed All Stories

Aug 12 2024

aklapper edited the content of Next Up.
Aug 12 2024, 09:21

Aug 11 2024

valerio.bozzolan edited the content of Next Up.
Aug 11 2024, 21:16
aklapper requested review of D25771: Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider.
Aug 11 2024, 21:00
aklapper added a revision to T15912: PHP 8.1 "strlen(null)" exceptions creating OAuth provider: D25771: Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider.
Aug 11 2024, 21:00 · PHP 8 support
aklapper created T15912: PHP 8.1 "strlen(null)" exceptions creating OAuth provider.
Aug 11 2024, 20:57 · PHP 8 support
aklapper requested review of D25770: Fix $boot_length comparison in PhagePHPAgentBootloader.
Aug 11 2024, 20:48
aklapper closed T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 11 2024, 20:36 · PHP 8 support
aklapper closed T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController as Resolved by committing rP58f1c83a5ac5: Fix PHP 8.1 "strlen(null)" exception in DivinerFindController.
Aug 11 2024, 20:36 · PHP 8 support
aklapper closed D25768: Fix PHP 8.1 "strlen(null)" exception in DivinerFindController.
Aug 11 2024, 20:36
aklapper committed rP58f1c83a5ac5: Fix PHP 8.1 "strlen(null)" exception in DivinerFindController.
Fix PHP 8.1 "strlen(null)" exception in DivinerFindController
Aug 11 2024, 20:36
valerio.bozzolan moved T15697: When deleting the last Sub-project, restore its Root Project from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.
Aug 11 2024, 19:52 · User-valerio.bozzolan, Projects
valerio.bozzolan moved T15906: Add unit tests for Calendar imports from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Aug 11 2024, 16:32 · User-valerio.bozzolan, Calendar
valerio.bozzolan updated the test plan for D25768: Fix PHP 8.1 "strlen(null)" exception in DivinerFindController.
Aug 11 2024, 16:21
valerio.bozzolan accepted D25768: Fix PHP 8.1 "strlen(null)" exception in DivinerFindController.

yesyes

Aug 11 2024, 16:21
aklapper added a comment to T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController.

Not sure what "similar working links" means... Something like https://we.phorge.it/diviner/find/?name=PhutilSafeHTML ?

Aug 11 2024, 16:17 · PHP 8 support
aklapper renamed T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef from PHP 8.1 "strlen(null)" exception in DivinerAtomRef to PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Aug 11 2024, 15:38 · PHP 8 support
aklapper added a comment to T15123: Javelin Support stuff.

Is this also the reason why links to e.g. https://we.phorge.it/diviner/find/?name=JX.behavior&type=function&jump=1 on https://we.phorge.it/book/javelin/article/behaviors/ or to http://we.phorge.it/diviner/find/?name=JX.Stratcom&type=class&jump=1 are 404s, or do I misunderstand and that's a separate issue?

Aug 11 2024, 15:31
aklapper requested review of D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Aug 11 2024, 15:29
aklapper added a revision to T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef: D25769: Fix PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Aug 11 2024, 15:29 · PHP 8 support
aklapper added a comment to T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.

Urgh. In calling https://we.phorge.it/source/phorge/browse/master/src/applications/diviner/query/DivinerAtomQuery.php$340 , $this->titles is an array which has a length of 1, with its only member being null. Sounds like there's already something fishy before.

Aug 11 2024, 15:28 · PHP 8 support
valerio.bozzolan added a comment to T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController.

Where I can find similar working links? I've tried generating Diviner books for both Arcanist and Phorge but http://phorge.localhost/diviner/find/?name=JX.Stratcom is still giving me 404

Aug 11 2024, 15:10 · PHP 8 support
aklapper created T15911: PHP 8.1 "str_replace(null)" exception in DivinerAtomRef.
Aug 11 2024, 15:01 · PHP 8 support
aklapper requested review of D25768: Fix PHP 8.1 "strlen(null)" exception in DivinerFindController.
Aug 11 2024, 15:00
aklapper added a revision to T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController: D25768: Fix PHP 8.1 "strlen(null)" exception in DivinerFindController.
Aug 11 2024, 15:00 · PHP 8 support
valerio.bozzolan added a revision to T15905: Linter: do not break "ics" files: D25767: Calendar Import: add unit tests to cover participants.
Aug 11 2024, 14:59 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan added a task to D25767: Calendar Import: add unit tests to cover participants: T15905: Linter: do not break "ics" files.
Aug 11 2024, 14:59
aklapper created T15910: PHP 8.1 "strlen(null)" exception in DivinerFindController.
Aug 11 2024, 14:57 · PHP 8 support
aklapper updated the diff for D25738: Avoid RuntimeException on "Skip past this commit" when commit still importing.

Thanks for finding a way to reproduce! I still fail to find the right timing here to produce a testcase, so this is another untested shot in the dark.

Aug 11 2024, 09:35
aklapper added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

No, as project membership is unrelated to task object policy, as a task can associated to more than one project.

Aug 11 2024, 07:54

Aug 10 2024

valerio.bozzolan added a comment to D25051: Destroy file attachments when file is deleted, or object is deleted.

Just for the glory of the archive. I've tested this feature in production before landing.

Aug 10 2024, 20:45 · Files
valerio.bozzolan added a comment to D25617: docs/file_domain: remove cloudflare mention of autominify.

I guess this is the time. Feel free to land as usual with

Aug 10 2024, 20:31
valerio.bozzolan edited the content of Next Up.
Aug 10 2024, 20:18
valerio.bozzolan closed D25051: Destroy file attachments when file is deleted, or object is deleted.
Aug 10 2024, 20:17 · Files
valerio.bozzolan closed T15110: File reference not removed when file is deleted as Resolved by committing rP2b7c0ec92f6c: Destroy file attachments when file is deleted, or object is deleted.
Aug 10 2024, 20:17 · Files, Bug Reports
valerio.bozzolan committed rP2b7c0ec92f6c: Destroy file attachments when file is deleted, or object is deleted (authored by Dylsss).
Destroy file attachments when file is deleted, or object is deleted
Aug 10 2024, 20:16
valerio.bozzolan closed T15896: Explore How-To Permanently Destroy Things in Phorge, a subtask of T15110: File reference not removed when file is deleted, as Resolved.
Aug 10 2024, 20:14 · Files, Bug Reports
valerio.bozzolan closed T15896: Explore How-To Permanently Destroy Things in Phorge as Resolved.

Well, I doubt we can dig more than this.

Aug 10 2024, 20:14 · Phorge
omorrigan added a comment to T15501: Voluntary Usage Survey App.

I think that is complex because some admins are not well active on their platforms, so as said before it can be underdimensioned

Aug 10 2024, 14:05 · Discussion Needed

Aug 9 2024

valerio.bozzolan added a project to T15905: Linter: do not break "ics" files: User-valerio.bozzolan.
Aug 9 2024, 20:50 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan moved T15578: The action "Quote comment" has an incomplete fragment URL from PingDeath 🌚 to Code Sprint Candidate on the User-valerio.bozzolan board.
Aug 9 2024, 20:49 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
valerio.bozzolan moved T15256: Diffusion file: add a way to copy permalink from PingDeath 🌚 to Code Sprint Candidate on the User-valerio.bozzolan board.
Aug 9 2024, 20:49 · User-valerio.bozzolan, Diffusion
revi renamed T15908: More Useful "Quick Create" button on Workboard Columns from More Useful "Quick Create" button on Wo rboard Columns to More Useful "Quick Create" button on Workboard Columns.
Aug 9 2024, 13:04 · Feature Requests, Workboard
revi renamed T15908: More Useful "Quick Create" button on Workboard Columns from More Useful "Quick Create" button on Worboard Columns to More Useful "Quick Create" button on Wo rboard Columns.
Aug 9 2024, 13:03 · Feature Requests, Workboard
valerio.bozzolan added a comment to D25301: Diffusion: add "Permalink" button.

@aklapper I see. What do you think about D25301#15795 ?

Aug 9 2024, 12:57
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).
  • updated screenshot access to All Users
  • thanks, that task would solve the problem!
  • alternatively, "Project Members" option could be made available as an object policy for tasks
Aug 9 2024, 10:27
arp added a comment to T15908: More Useful "Quick Create" button on Workboard Columns.

@valerio.bozzolan also, triggers don't offer an option to change task space or task access.

Aug 9 2024, 10:15 · Feature Requests, Workboard
valerio.bozzolan requested changes to D25738: Avoid RuntimeException on "Skip past this commit" when commit still importing.

OK. Full immersion mode 🌈

Aug 9 2024, 09:59
valerio.bozzolan added inline comments to D25733: Do not throw Aphront400Response when editing a task.
Aug 9 2024, 07:15
valerio.bozzolan added inline comments to D25738: Avoid RuntimeException on "Skip past this commit" when commit still importing.
Aug 9 2024, 06:41

Aug 8 2024

valerio.bozzolan added a comment to T15888: RuntimeException using "Skip past this commit" to access a commit still importing: "reset() expects parameter 1 to be array, null given".

I'm trying to reproduce, creating a repository, stopping phlog, and pushing, and starting and immediately randomly stopping phlog.

Aug 8 2024, 18:57
valerio.bozzolan added a comment to T15909: Absence of "git-http-backend" in Debian default PATH.

At the moment we have a multi-thread command existence checker, and it early dies if a command is not existing.

Aug 8 2024, 16:41 · Diffusion
valerio.bozzolan created T15909: Absence of "git-http-backend" in Debian default PATH.
Aug 8 2024, 16:23 · Diffusion
avivey moved T15908: More Useful "Quick Create" button on Workboard Columns from Backlog to Features on the Workboard board.
Aug 8 2024, 15:05 · Feature Requests, Workboard
avivey accepted D25617: docs/file_domain: remove cloudflare mention of autominify.
Aug 8 2024, 15:04
valerio.bozzolan added a comment to T15908: More Useful "Quick Create" button on Workboard Columns.

I wonder if "Workboard Triggers" may do the job here.

Aug 8 2024, 15:04 · Feature Requests, Workboard
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

I've filed T15908 for the "quick create from column to do what I mean".

Aug 8 2024, 14:54
avivey created T15908: More Useful "Quick Create" button on Workboard Columns.
Aug 8 2024, 14:52 · Feature Requests, Workboard
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

(@arp - the images you pasted did not get Attached, so they are Private; Please set them manually to Public so they can be seen. We have an open ticket for that somewhere)

Aug 8 2024, 14:24
valerio.bozzolan retitled D25363: Calendar Import: calendar uploader is not anymore an alien from Match yourself from Imported Events Invitees
Aug 8 2024, 12:00
valerio.bozzolan updated the diff for D25363: Calendar Import: calendar uploader is not anymore an alien.

be based on unit tests

Aug 8 2024, 11:54
revi published D25617: docs/file_domain: remove cloudflare mention of autominify for review.

It's 3 days past the scheduled execution date but the settings in dashboard and docs are still there.

Aug 8 2024, 10:28
valerio.bozzolan requested review of D25767: Calendar Import: add unit tests to cover participants.
Aug 8 2024, 10:27
valerio.bozzolan added a revision to T15564: Allow yourself to be Invited in Imported Events: D25767: Calendar Import: add unit tests to cover participants.
Aug 8 2024, 10:27 · User-valerio.bozzolan, Calendar
valerio.bozzolan added a revision to T15906: Add unit tests for Calendar imports: D25767: Calendar Import: add unit tests to cover participants.
Aug 8 2024, 10:27 · User-valerio.bozzolan, Calendar
arp added a comment to Q144: Support for arc work T12345 (workOnTask workflow).

I see. So, is that functionality already a part of arc diff? In other words, if arc work T123 would have worked exactly the same way as arc work branch-name (by creating a branch that's called either T123 or branch-name), then arc diff would correctly link it?

Aug 8 2024, 06:13 · Feature Requests, Arcanist

Aug 7 2024

Ekubischta added a comment to Q144: Support for arc work T12345 (workOnTask workflow).

Yes - it works seamlessly because if the local branch has a task number in it, the diff is automatically linked to that task when you run arc diff

Aug 7 2024, 19:33 · Feature Requests, Arcanist
aklapper closed D25762: Fix 404 link in Diviner to "Configuring File Storage" article.
Aug 7 2024, 15:41
aklapper committed rPb74f1ad519e8: Fix 404 link in Diviner to "Configuring File Storage" article.
Fix 404 link in Diviner to "Configuring File Storage" article
Aug 7 2024, 15:41
valerio.bozzolan abandoned D25766: Arcanist Text Linter: do not break the "ics" special format.

OK thanks

Aug 7 2024, 14:38
aklapper created T15907: Make Open Graph protocol meta tags code apply to any objects.
Aug 7 2024, 11:59
avivey added a comment to D25766: Arcanist Text Linter: do not break the "ics" special format.

It's probably better to exclude ICS files from TXT in .arclint, or define their own section, rather then add hard-coded exceptions in here.

Aug 7 2024, 11:57
aklapper closed T15902: PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 7 2024, 11:57 · PHP 8 support
aklapper closed T15902: PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction as Resolved by committing rP88225b99f2fc: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.
Aug 7 2024, 11:57 · PHP 8 support
aklapper closed D25765: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.
Aug 7 2024, 11:57
aklapper committed rP88225b99f2fc: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.
Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction
Aug 7 2024, 11:57
aklapper closed T15472: Support Open Graph protocol (at least in Maniphest) as Resolved by committing rP89778dc9e617: Add Open Graph protocol meta tags to Maniphest task pages.
Aug 7 2024, 11:54 · User-valerio.bozzolan, Affects-Wikimedia, Maniphest
aklapper closed D25668: Add Open Graph protocol meta tags to Maniphest task pages.
Aug 7 2024, 11:54
aklapper committed rP89778dc9e617: Add Open Graph protocol meta tags to Maniphest task pages.
Add Open Graph protocol meta tags to Maniphest task pages
Aug 7 2024, 11:54
valerio.bozzolan updated the diff for D25766: Arcanist Text Linter: do not break the "ics" special format.

remove unuseful newline

Aug 7 2024, 10:43
valerio.bozzolan requested review of D25766: Arcanist Text Linter: do not break the "ics" special format.
Aug 7 2024, 10:09
valerio.bozzolan added a revision to T15905: Linter: do not break "ics" files: D25766: Arcanist Text Linter: do not break the "ics" special format.
Aug 7 2024, 10:08 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan triaged T15905: Linter: do not break "ics" files as Normal priority.
Aug 7 2024, 09:58 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan added a parent task for T15905: Linter: do not break "ics" files: T15906: Add unit tests for Calendar imports.
Aug 7 2024, 09:57 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan added a subtask for T15906: Add unit tests for Calendar imports: T15905: Linter: do not break "ics" files.
Aug 7 2024, 09:57 · User-valerio.bozzolan, Calendar
valerio.bozzolan created T15906: Add unit tests for Calendar imports.
Aug 7 2024, 09:56 · User-valerio.bozzolan, Calendar
valerio.bozzolan claimed T15905: Linter: do not break "ics" files.
Aug 7 2024, 09:47 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan created T15905: Linter: do not break "ics" files.
Aug 7 2024, 09:47 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
arp updated the answer details for Q146: How to tag? (Answer 182).
Aug 7 2024, 09:46
arp added a comment to Q146: How to tag? (Answer 181).

Oh wow, that is a really unexpected way to create tags.

Aug 7 2024, 09:46
arp added Q146: How to tag? (Answer 182).
Aug 7 2024, 09:45
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

We have a public project tag used by a team. Some tasks associated with that public project tag are public tasks visible to everyone and anyone, so they are not in an access-restricted Space but default S1. Some tasks associated with that public project tag are temporarily non-public, "secret" tasks that should only be visible to that team and nobody else, so they are in an access-restricted Space that can only be accessed by team members.

Aug 7 2024, 09:40
valerio.bozzolan accepted D25762: Fix 404 link in Diviner to "Configuring File Storage" article.

yesyes

Aug 7 2024, 09:19
aklapper added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

In my installation this would not be a reasonable expectation. We have a public project tag used by a team. Some tasks associated with that public project tag are public tasks visible to everyone and anyone, so they are not in an access-restricted Space but default S1. Some tasks associated with that public project tag are temporarily non-public, "secret" tasks that should only be visible to that team and nobody else, so they are in an access-restricted Space that can only be accessed by team members.
So I'd rather envision a Herald rule: for a Maniphest task, if is newly created is true && Space is Sxx, then add project tag #whatever. (The other way round is not particularly feasible: The task would have a default view setting for a moment and potentially visible to outsiders, before moving it to a view-restricted Space).

Aug 7 2024, 09:02
aklapper added Q146: How to tag? (Answer 181).
Aug 7 2024, 08:51
arp asked Q146: How to tag?.
Aug 7 2024, 08:39
arp added a comment to T15546: Terminology inconsistency: Hashtags vs Tags vs Projects.

I was confused about why I couldn't tag a task with any random tag that I wanted to create on the fly as I'd do in Meta's Phabricator. It took me some time to realize that tags mean projects.

Aug 7 2024, 08:31
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

To clarify: currently existing auto-tagging is not about the column from which the task is created. It's about tagging with the project to which the column belongs.

Aug 7 2024, 08:17
avivey added a member for Trusted Contributors: arp.
Aug 7 2024, 07:47
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

It's not "impossible" on the technical level, it's just not obviously the right solution.

Aug 7 2024, 07:46
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

But also, why is it impossible? When a task is created from a column, it automatically pre-populates the tag column with the project it is created from. It seems trivial to implement a patch that would auto-detect the project's space and set it accordingly for the task.

Aug 7 2024, 07:06