(I said "override" but probably "patch" fits better - since I see that the class is final. I don't know why the codebase is so strict in having final classes. But I think you can just try to patch it in your local installation. Try!)

OK so you are trying to improve email notifications, immediately showing the Task Priority in the Subject. That's nice honestly.

The added [xxx] lets people easily see right in the email inbox if something needs immediate response without need to open and read the email or login to phorge to check for example the severity or priority of a task. We found that adding such a marker was the easiest way to go. However, if there are better solutions, i am eager to learn about them. Would tags and columns (what are columns in this context?) help there?

Uhm. Yep. Do you know have any idea about what should be changed to achieve this in a secure way?

I wonder if this could be just a patch that assumes Story Points = 1 as sane default instead of zero.

I see that this sender is still as was reported.

I think this could me marked as resolved since lot of users are using Ponder here. Nice.

I mean, is this related to we.phorge.it?

I agree that an agreement could be useful but I don't think that the author should ever allow to re-license its work. I honestly do not want to allow my contributions to be re-licensed, since this usually means that the repository owner wants to re-license that work under a proprietary license when needed. I don't accept that. Normal volunteers do not accept that. This is probably not what we want.

I just want to mark this as resolved since Rector.php is quite nice and simple and we can surely use this tool to do nice things, even without adding it in our Composer but just locally, when we need it.

Untagging Phorge since this is a well-known wide group of issue related to Outlook itself or the SMTP server, and 99.999% not related in any way to Phorge itself. Make sure that your configuration is consistent. Make sure that your sender From: is the same as your SMTP username. Make sure you contacted Outlook for delivery troubleshooting info.

Out of curiosity, how is it not better to have a column or tag for this?

Superseded by:

try to fix lint again - but I don't hope for it

I understand that this is... too much.

@valerio.bozzolan Thanks for the feedback and sorry for the late response. I must admit that i forgot how we eventually fixed our issue, i only recall it was more about "avoid the issue" and less about "fix the issue". I also completely forgot about this Maniphest. Hence, it is OK for me that it is closed by now. sorry for not taking care about this earlier.

If you are really really really interested in hard-blocking Task creation from custom rules using Herald, it should be probably developed a new Herald Action to support the "block Task creation" if something happens. But I honestly cannot implement this feature, so at the moment I hope the "auto-comment" is enough for you.

One thing that could be done right now is:

Thank you again for your question. Sorry if I start marking this as closed since currently this specific Task with this title is probably not implementable as-is. We have some approaches, but without much feedback from the original poster and from other users it's very difficult to do something concrete that do not impact other workflows.

Do you want an hand to land this accepted revision?

As a proof of concept I've uploaded a GIMP image (GIMP = green is my pepper) as Task image.

For some historical context, this current patch comes from another one from the Phabricator of Wikimedia Foundation:

OK no sorry, it already does not show any content.

This fluffy rabbit is released in the public domain by user Clevername.

@Dylsss thanks - can I ask if you agree with the edit suggestion?

This patch also tries improves the user experience of this diff:

So the goal is:

I tried to keep the diff as much small as possible. That is why I just added a small piece of code with a return; instead of a bigger refactoring.

I would like to fix this lint:

simplify ( $a->b() )->$b() to just $a->b()->c() since the first it's only supported in PHP 7.0

I have an ironical situation. This syntax is very supported:

skip the replacement of __CLASS__ to self::class since it can be just confusing

avoid to replace CLASS to self::class since it's probably nonsense

I'm pretty impressed by the power of Rector. I almost figured out how to use the 2% of it: Rector put my whole house in order, including Phorge and Arcanist that were on the bedside table.