Page MenuHomePhorge
Create Task
Maniphest T15166

Render Ponder mentions as striked if resolved (like Tasks)
Closed, ResolvedPublic
Actions

Description

I noticed that, when mentioning a resolved Ponder question, they are not striked if it was resolved.

This is true for both search results and remarkup.

Example mention:

Q11

Q11: upgrade phabricator to phorge

For historical reasons here a screenshot (with just one line):

Example Ponder mention.png (77×113 px, 2 KB)

Expected behavior:

A mentioned Ponder should be rendered as striked when it is resolved. Just like Tasks.

  • D25086 strike resolved Ponder search results
  • strike resolved Ponder mentions from Remarkup (how??)

Revisions and Commits

rP Phorge
AbandonedD25085 PonderQuestion: add method isStatusClosed() and test cases
D25086rP5eac69b79dbb Ponder: strike code of resolved questions in query results

Related Objects

Event Timeline

valerio.bozzolan triaged this task as Wishlist priority.Mar 10 2023, 07:20
valerio.bozzolan created this task.
valerio.bozzolan created this object in space S1 Public.
Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptMar 10 2023, 07:20
valerio.bozzolan updated the task description. (Show Details)Mar 23 2023, 13:01
valerio.bozzolan added a revision: D25085: PonderQuestion: add method isStatusClosed() and test cases.Mar 23 2023, 14:32
valerio.bozzolan updated the task description. (Show Details)Mar 23 2023, 14:55
valerio.bozzolan added a revision: D25086: Ponder: strike code of resolved questions in query results.Mar 23 2023, 14:56
valerio.bozzolan added a commit: rP5eac69b79dbb: Ponder: strike code of resolved questions in query results.Mar 27 2023, 18:55
valerio.bozzolan mentioned this in 2023 Week 2.Mar 27 2023, 20:28
valerio.bozzolan closed this task as Resolved.Mar 28 2023, 06:31
valerio.bozzolan claimed this task.

This is now resolved! with:

rP5eac69b79dbb: Ponder: strike code of resolved questions in query results

valerio.bozzolan reopened this task as Open.Mar 28 2023, 06:31
valerio.bozzolan updated the task description. (Show Details)

OK no I was wrong. We still need a fix for Remarkup as well. But maybe we can mark as wontfix.

valerio.bozzolan added a project: User-valerio.bozzolan.Mar 28 2023, 09:03
valerio.bozzolan closed this task as Resolved.EditedMar 31 2023, 20:07

I have no interest in striking a question in Remarkup since a Question is always useful even if marked as closed, so it's not that useful to strike it.

The current implementation is just fine.

avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54
avivey removed a project: Ponder (archived).May 9 2023, 10:51
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0