First of all: you should create the copy button server side. Ideally inside the remark rule for creating a code block. There you can attach the ressources too. And you can add sigils to the button. Javelin uses sigils to attach behaviors and listen to events.

In D25966#25736, @mturdus wrote:

@bekay

• when using mousedown in combination with an a-tag with href=#, I don't know how to convert e.preventDefault. e.prevent() didn't work the same

@bekay
I tried to use JX.Stratcom.listen but I ran into the following issues:

• I couldn't use mouseenter and mouseleave events for some reason
• when using mousedown in combination with an a-tag with href=#, I don't know how to convert e.preventDefault. e.prevent() didn't work the same

Comments from z1 chat:

ES5 compatibility issues fixed

In D25965#25711, @aklapper wrote:

Uh nice, thank you! This seems to work as expected:

I wonder if this also influences T15884: "Uncaught TypeError: spec is undefined" and no hovercard over task link in Aphlict notification which I do not manage to reproduce right now (and that might instead be related to running a newer node-ws version locally)

This might be a bad idea after looking up more docs:

Uh nice, thank you! This seems to work as expected:

@mturdus the page option is now 1-indexed and I have fixes some css styles for a better rendering of different options.

• make page option 1-indexed
• make layout, float and width rendering options more concise
• remove console.log

Rebase and re-run tests with expected LANG

@nib please do submit a diff, I'd be happy to review it.

Thaanks

Works for me. Tested on our firm instance.

In D25962#25652, @mturdus wrote:

This looks very pro !

I found one small issue:
the page parameter seems to be zero-based. Can you make it one-based, so that the first page can be accessed with page=1 instead of page=0 ?

This looks very pro !

Thanks! Accepting per testing in D25956#25577

Nice!

Update quickstart with paste mailkey removal

Capitalize consistently

Reset to original diff.

Update

In D25900#25559, @mainframe98 wrote:

I had to go dig for this, but from what I understand of looking at PhabricatorMetaMTAMailProperties, which is the class now responsible for this functionality, creating a mail key only happens when its loadMailKey method is called. That method is only called when email functionality engaged.

Thanks! Small nitpick: I'd probably change @deprecated call Exception::getPrevious directly. to @deprecated Call Exception::getPrevious() directly.

@mturdus I have landed this but have reintroduced this code which you have removed - please accept my fix: D25960

In D25900#25554, @aklapper wrote:

What is (or rather was, I guess) that mailKey thingie good for?

In D25619#22881, @aklapper wrote:

@bekay: Would you like to merge this?

What is (or rather was, I guess) that mailKey thingie good for? Or more relevant, I assume it's intentional after performing the Test Plan steps above that creating a new Paste does not create a new row in phabricator_metamta.metamta_mailproperties?
Apart from that, seems to work as expected. :) Thanks!

Fix

Add test

Wow, super fast thanks. Maybe nice to expand a bit the src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php