Cigaryno moved this task from Backlog to PHP 8.1 on the PHP 8 support board.

Uhm, I realize this might not be a good idea because some might still be accessed by reflection.

Superseded by https://we.phorge.it/rPa4948ec800e9e385ecb519d86b40c5f13719fb53

I do not recommend, because https://phabricator.wikimedia.org/T293139 - Phorge displays whatever it gets, especially if the video got deleted in the meantime. Same behavior for Youtube.

Yeah that makes sense, thanks!

• rebase again

./bin/celerity/map

Remove newNoMenuItemsView() instead

Uhm, right. A quick fix would be removing the margin-left: 300px; CSS rule for div.phui-document-content-outer which might invalidate related screenshots on https://we.phorge.it/w/changelog/next_up/.

Do not use consts but keep the two pixel values defined in getMaxTransformDimensions(), make function non-static

@Cigaryno: What is your motivation behind and which actual problem are you trying to solve by this? For example, there are now 4 out of ~25000 patches tagged with Projects if I was about to search for patches tagged with Projects. I can imagine tags to be partially useful on Maniphest tasks and I fail to see the advantage for Differential patches so far.

@Cigaryno: Could you please not add project tags to patches? You seem to be the only person doing this lately, and it creates notifications that others need to read. Thanks.

• mb_chr(215) because arc lint dislikes funky ×
• const MAX_TRANSFORM_* because arc lint does not like private const, so maybe PhabricatorFileImageTransform::getMaxTransformDimensions() is overengineering as I could also access the two consts directly instead
• Cannot private const int because that requires PHP 8.3 (type safety haha)

Please answer my questions via text. The two images can only be seen by you.

Create a task in Phorge and attach a file (e.g., a screenshot or document).

git clean -fx to hopefully avoid test failure

In T15640#19898, @valerio.bozzolan wrote:

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

Thanks for the super-quick patch! I can confirm that this fixes the issue in the Phriction ToC on wider screens.

@jeffrey: Would you like to arc land your patch to get it merged?

@bekay: Would you like to merge this?

In D25775#21206, @valerio.bozzolan wrote:

More understanding on the root cause is needed. Probably the root cause is "just" that getOldValue() returns an empty string. In that case we should probably at least understand what object is that (sub-class of PhabricatorTransactionRemarkupChange?) and we probably we need something like a generateOldValue() or something similar.

After installing subversion and setting LC_ALL instead of LANG I can finally reproduce on a Fedora 40 system:

Oh true, got it. Have to replace PhabricatorPolicyCapability::POLICY_ADMIN, with 'capability' => PhabricatorPolicies::POLICY_ADMIN, here

Right... one day I may get used to all those Phorge shortcuts, thanks

Oops, no for real

Uhm, right, heh

I applied this patch locally on top of git master and output does not complain anymore about 'link-brackets.txt' (thus it's correct) but fails in link-edge-cases.txt now (thus it's likely not complete):

@mturdus: Thanks! LGTM

@valerio.bozzolan: Feel free to give this revised version another review :)