Page MenuHomePhorge

Remove unused properties
AbandonedPublic

Authored by aklapper on Feb 8 2025, 16:08.
Tags
None
Referenced Files
F3253916: D25866.1742447837.diff
Wed, Mar 19, 05:17
F3247822: D25866.1742232015.diff
Sun, Mar 16, 17:20
F3224497: D25866.1742048508.diff
Fri, Mar 14, 14:21
F3216199: D25866.1741685075.diff
Mon, Mar 10, 09:24
F3214799: D25866.1741592998.diff
Sun, Mar 9, 07:49
F3157398: D25866.1741240245.diff
Wed, Mar 5, 05:50
F3015724: D25866.1740729933.diff
Thu, Feb 27, 08:05
F3006491: D25866.1740575119.diff
Tue, Feb 25, 13:05

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

Remove unused properties / variables.

Test Plan

Run static code analysis.

Diff Detail

Repository
rARC Arcanist
Branch
rmUnusedProperties (branched from master)
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 1686
Build 1686: arc lint + arc unit

Unit TestsFailed

TimeTest
696 msArcanistBundleTestCase::testGitRepository
EXCEPTION (Exception): Expected patch and actual patch for 5dec8bf28557f078d1987c4e8cfb53d08310f522 differ. Wrote actual patch to '/var/www/html/phorge/arcanist/src/parser/__tests__/patches//5dec8bf28557f078d1987c4e8cfb53d08310f522.gitpatch.real'. #0 /var/www/html/phorge/arcanist/src/parser/__tests__/ArcanistBundleTestCase.php(87): ArcanistBundleTestCase->runGitRepositoryTests(Object(PhutilDirectoryFixture)) #1 /var/www/html/phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(639): ArcanistBundleTestCase->testGitRepository()
73 msAbstractDirectedGraphTestCase::testCyclicGraph
1 assertion(s) passed.
73 msAbstractDirectedGraphTestCase::testEdgeLoadFailure
1 assertion(s) passed.
79 msAbstractDirectedGraphTestCase::testNonTreeGraph
1 assertion(s) passed.
73 msAbstractDirectedGraphTestCase::testNoncyclicGraph
1 assertion(s) passed.
View Full Test Results (1 Failed · 213 Passed)