Remove unused properties / variables.
Details
Details
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- rmUnusedProperties (branched from master)
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 1686 Build 1686: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 696 ms | ArcanistBundleTestCase::testGitRepository EXCEPTION (Exception): Expected patch and actual patch for 5dec8bf28557f078d1987c4e8cfb53d08310f522 differ. Wrote actual patch to '/var/www/html/phorge/arcanist/src/parser/__tests__/patches//5dec8bf28557f078d1987c4e8cfb53d08310f522.gitpatch.real'.
#0 /var/www/html/phorge/arcanist/src/parser/__tests__/ArcanistBundleTestCase.php(87): ArcanistBundleTestCase->runGitRepositoryTests(Object(PhutilDirectoryFixture))
#1 /var/www/html/phorge/arcanist/src/unit/engine/phutil/PhutilTestCase.php(639): ArcanistBundleTestCase->testGitRepository()
| |
| 73 ms | AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed. | |
| 73 ms | AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed. | |
| 79 ms | AbstractDirectedGraphTestCase::testNonTreeGraph 1 assertion(s) passed. | |
| 73 ms | AbstractDirectedGraphTestCase::testNoncyclicGraph 1 assertion(s) passed. | |
| View Full Test Results (1 Failed · 213 Passed) |
Event Timeline
Comment Actions
Uhm, I realize this might not be a good idea because some might still be accessed by reflection.