Also run ./bin/celerity map because it's JS

@Wikivu: Why?

are a bit esoteric

we should probably toggle visibility by JavaScript

In D25672#19381, @valerio.bozzolan wrote:

I love this collapsible on mobile since it saves a lot of scrolls, but I think the collapsible on desktop can just add confusion without clear benefits (since the desktop layout is not vertical, and saving vertical space does not help in showing more information). Probably this should only apply on .device-tablet and .device-phone, but not .device-desktop

I've seen this occasionally when trying to log in via a /bin/auth recover link with same stacktrace as above, PHP 8.3.8 on a Fedora 40 machine:

It seems that the function PHUIDiffTableOfContentsItemView.php::render() is not called anymore as rPf21f1d8ab9e909b3e2c4dc07af7a358a8336902c removed $rows[] = $item->render();. I cannot spot another direct render() call anywhere else in the files instantiating a PHUIDiffTableOfContentsItemView.
However, PHUIDiffTableOfContentsItemView must define render() as it's defined as an abstract method in parent AphrontView.
After emptying render(), renderChangesetMetadata() does not have any other callers either, thus also removing it.

In D25658#19351, @avivey wrote:

grep for PHUIDiffTableOfContentsItemView in the codebase to see where we might be using this class.

The called method renderChangesetLink() is not defined anywhere so static code analysis complains.
UI-wise I could not spot anything obviously broken in the "Paths" sidebar under ToC for a merged commit, though.

Confirming this works as expected - thanks!

Congrats to this patch.

Looks like installing php-xdebug forces me to set 'xdebug.mode' to 'coverage' in 'php.ini' to pass arc unit, no matter what...

Move CDN check from generic AphrontResponse to more correct AphrontHTMLResponse.

probably need to escape the URI

The diff below suppresses the error (and checks like trying to "Sign With MFA" without another action should fail etc still work) but no idea about potential side effects as isPreviewRequest() is called in numerous places.

@valerio.bozzolan Any thoughts/opinion regarding my last comment? :) TIA

Sigh I screwed up (again) by not running ./bin/celerity map one more time. :( Followup in D25697

Meh, after removing the value from the "Page Size" field on phorge.localhost/maniphest/query/advanced/, field entry will incorrectly display "0" but list 100 results. Need to find out how to keep the value displayed/reset after manually removing it to avoid PHP converting an empty integer to a 0.

Make Celerity happy (I hope)

We pushed rPfbe07fbeefcadea3abdb4dc3e4d4558c2b91ada9 in the meantime so no more String but Int field

Current patch does not work anymore since merging rPfbe07fbeefcadea3abdb4dc3e4d4558c2b91ada9; need to remove getDefaultValue() from PhabricatorSearchIntField instead of PhabricatorSearchTextField now

https://secure.phabricator.com/T13624#255069 and https://secure.phabricator.com/T13624#255072 provide the bigger context why it's "temporarily disabled".

Thanks for taking a look! Grep'ing the Phorge codebase I could not find any other consumers of d3 than Chart.js used by the Facts application. The d3 API has changed between 5.9.2 and 6.7.0 but the only changes relevant to Phorge which I found are covered in the three lines touched in Chart.js in this very patch.

I realize how little I remember SVN to set up testing, sigh... Any chance to share the related stacktrace?

Per my last comment

This is not a full fix, still it is an improvement (and a base if anyone feels like fixing this perfectly).

revi confirmed this is called by getRepositorySlug() so abandoning this patch as hiding the underlying issue (no repository slug defined?) is not the right approach

In D25636#17849, @valerio.bozzolan wrote:

Nice catch. Basically the question is, why is this not working?

@revi: Could you please double-check and confirm that the line 144 in <phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php is
'n' => $this->escapeToken($repository->getRepositorySlug()),
in your installation? Thanks in advance!

can it cause anything bad

Good point, thanks! Updated.