Page MenuHomePhorge

Remove janky array copying workaround for IE8
Needs ReviewPublic

Authored by aklapper on Jun 29 2024, 18:10.
Tags
None
Referenced Files
F3333980: D25704.1743542117.diff
Mon, Mar 31, 21:15
F3328784: D25704.1743462137.diff
Sun, Mar 30, 23:02
F3320214: D25704.1743323468.diff
Sat, Mar 29, 08:31
F3304341: D25704.1743096503.diff
Wed, Mar 26, 17:28
F3298533: D25704.1743004182.diff
Tue, Mar 25, 15:49
F3298444: D25704.1743002197.diff
Tue, Mar 25, 15:16
F3297890: D25704.1742992037.diff
Tue, Mar 25, 12:27
F3292723: D25704.1742899814.diff
Mon, Mar 24, 10:50

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

Internet Explorer 8 and earlier did not consider DOM NodeLists to be JS objects.
In different words: IE<9 did not support Array#slice on collections objects.
See for example https://stackoverflow.com/a/11113539

This reverts rP597c6c07f7120d253e83fa110db8842bfa05859f

Test Plan

Still: Load a diff in a web browser; see changes and do not get JS errors.

Diff Detail

Repository
rP Phorge
Branch
ie8nodelist
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1381
Build 1381: arc lint + arc unit