git rebase master

Thanks. Moreover, looking at PhutilKeyValueCache it seems that setKey(null) has no sense. So thanks also for that extra care you already set.

I will then need a rebase for D25363

To me it makes sense thanks. Maybe just add a comment somewhere to say that the menu should be automatically generated - T15224

Test plan: I finished my ideas. It seems it just works 🤔

In D25685#18805, @avivey wrote:

this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

Better than before.

all those tears shed by devastated users after clicking the Calendar menu item

Maybe a good moment for minimal PHPDoc with

I will update the screenshots. Let's wait another +1 on strings.

Tried to re-phrase a bit, thanks to feedback from Italian coworkers and Andrè. lol

Also fix the typo in the function name

Thanks. Your edit effectively reflects what already happens, but interestingly, it still may crash 🤔

A bit more than Normal, since it reflects on a database with orphan elements that creates "ghosts in the UI".

Wow. With my proposal is not funny anymore. OK I will refrain myself from contributing here. But I personally like the new proposal from Andrè and @pppery. Personally approving.

I understand the points. Third proposal, starting with useful tips (good idea), and shorter:

No results.

Is anything extending HeraldEngine trying direct access to that?

The linter now screams nonsense things because of my little new unit test, taken from the proposed tar.gz file. Probably better than nothing. Tested A/B and it makes sense. Also the addition makes sense to me, compared to the other ones.

add unit test

• AlmanacDeviceSearchEngine: add comma, but maybe keeping 'networks' in plural since the button is See Networks
• AlmanacServiceSearchEngine: -of your devices +provided by your devices

Also adding some on-platform documentation would be nice.

Screenshot taken at 702 x 495

I guess I should abandon this patch?

Sorry again for the confusion, I don't want to create extra work. I will create another patch as clarification. Unfortunate legacy situation.

Yup. I noticed that probably the method getNewUserBody() should be just moved from PhabricatorDashboardPanelListController to PhabricatorDashboardPanelSearchEngine. Additional details in T15844.

The test plan should be:

Just try to move the method in PhabricatorDashboardPanelSearchEngine as-is

Wow, this was super-interesting

Nice!

restore newline

Thanks for the upstream link

https://www.reddit.com/r/ProgrammerHumor/comments/9xat04/the_ancient_code/

Well, I understand why this patch completely removes that joke.

Thanks asd

shot at line 1162

Thanks :3 Hoping to be useful I will amend with a minimal sed -i 's/QRbitrtream/QRbitstream/' externals/phpqrcode/phpqrcode.php

I tested this with the following snippet:

Thanks :3 It makes sense, and I've also tested that snippet in PHP 5.5 and PHP 8.1 obtaining same results (premising that each() is not available anymore in PHP 8 as already clarified)

It was probably confused with the internal API executeRemovePath

Uh? It seems in use to me, in legacy lines 142, 145, 154, 155, etc.