Paths

Table of Contentst

Remove unused variable from HeraldEngine
ClosedPublic
Actions

Authored by aklapper on Jun 4 2024, 09:34.

Tags

None

Referenced Files

	F3298149: D25679.1742997736.diff
	Tue, Mar 25, 14:02

	F3294815: D25679.1742944115.diff
	Mon, Mar 24, 23:08

	F3249552: D25679.1742286560.diff
	Mon, Mar 17, 08:29

	F3224539: D25679.1742057879.diff
	Fri, Mar 14, 16:57

	F3222856: D25679.1741931281.diff
	Thu, Mar 13, 05:48

	F3027099: D25679.1740825442.diff
	Fri, Feb 28, 10:37

	F2997265: D25679.1740394606.diff
	Feb 23 2025, 10:56

	F2996021: D25679.1740361239.diff
	Feb 23 2025, 01:40

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPa8af0c6e5119: Remove unused variable from HeraldEngine

Summary

$activeRule is not used anywhere.

Test Plan

Grep the code.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jun 4 2024, 09:34

Owners added a reviewer: O1: Blessed Committers.Jun 4 2024, 09:34

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJun 4 2024, 09:34

aklapper requested review of this revision.Jun 4 2024, 09:34

Harbormaster completed remote builds in B1317: Diff 2067.Jun 4 2024, 09:34

Is anything extending HeraldEngine trying direct access to that?

grep -RF -- '->activeRule' .

No results.

This revision is now accepted and ready to land.Jun 4 2024, 10:24

Closed by commit rPa8af0c6e5119: Remove unused variable from HeraldEngine. · Explain WhyJun 5 2024, 08:30

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPa8af0c6e5119: Remove unused variable from HeraldEngine.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

herald/

engine/

HeraldEngine.php

1 line

O1: Blessed Committers

Diff 2074

View Options

src/applications/herald/engine/HeraldEngine.php

Remove unused variable from HeraldEngineClosedPublicActions