Paths

Table of Contentst

Remove unused variable from HeraldEngine
ClosedPublic
Actions

Authored by aklapper on Jun 4 2024, 09:34.

Tags

None

Referenced Files

	F2985501: D25679.1740058943.diff
	Wed, Feb 19, 13:42

	F2979399: D25679.1739851996.diff
	Mon, Feb 17, 04:13

	F2979049: D25679.1739763961.diff
	Sun, Feb 16, 03:46

	F2950118: D25679.1738718384.diff
	Tue, Feb 4, 01:19

	F2938885: D25679.1738024995.diff
	Mon, Jan 27, 00:43

	F2933598: D25679.1737777078.diff
	Fri, Jan 24, 03:51

	F2933595: D25679.1737777048.diff
	Fri, Jan 24, 03:50

	F2933593: D25679.1737776998.diff
	Fri, Jan 24, 03:49

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPa8af0c6e5119: Remove unused variable from HeraldEngine

Summary

$activeRule is not used anywhere.

Test Plan

Grep the code.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jun 4 2024, 09:34

Owners added a reviewer: O1: Blessed Committers.Jun 4 2024, 09:34

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJun 4 2024, 09:34

aklapper requested review of this revision.Jun 4 2024, 09:34

Harbormaster completed remote builds in B1317: Diff 2067.Jun 4 2024, 09:34

Is anything extending HeraldEngine trying direct access to that?

grep -RF -- '->activeRule' .

No results.

This revision is now accepted and ready to land.Jun 4 2024, 10:24

Closed by commit rPa8af0c6e5119: Remove unused variable from HeraldEngine. · Explain WhyJun 5 2024, 08:30

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPa8af0c6e5119: Remove unused variable from HeraldEngine.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

herald/

engine/

HeraldEngine.php

1 line

O1: Blessed Committers

Diff 2074

View Options

src/applications/herald/engine/HeraldEngine.php

Remove unused variable from HeraldEngineClosedPublicActions