Shorten too long line

Simplify code with neat functions as proposed by Valerio

Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) and Apache 2.0 unless otherwise noted.

In T15322#11590, @valerio.bozzolan wrote:

This would also help Wikimedia volunteers to upload screenshots of Phorge to Wikimedia Commons, avoiding annoying deletion procedures for the lack of the license in the very same page etc.

As this is broken anyway (and creates noisy log spam when someone tries to use the broken Create Identity form), would it make sense in the meantime as a workaround to disable (or hide, but no idea how to do that for a PhabricatorEditEngine) that form for every and any user? A one-line hack would be in P22.

Argh, sorry for my comment. I missed that rPbcfcd9acfc12fdf8ca3bf0e2c89651ba6d159b17 removed that noise already! (Anyway, I cannot share a stack trace when no stack trace is printed anyway.)

@valerio.bozzolan: This is now spamming our error logs. Any recommendations how to proceed?

fix a typo

Please do note that this patch is untested as I am unaware of reproduction steps.

shrug

Try again, after an rm and arc liberate on master, and then a git rebase master on this branch

and that's now wrong because src/__phutil_library_map__.php includes a non-existing file though I had ran git stash. I love git...

Obviously not a clean tree, sorry. Thus ran arc liberate, now arc asked whether to include unstaged changes in src/__phutil_library_map__.php (yes)

Ran arc unit first

Make code more readable

Accept whatever stuff is passed as $label as long as it's not null, per last comment

FYI I proposed a partial patch in D25415 which makes the issue more contained at least.

I confirm that there is no problem after running git revert 02a4f8b0c8f1279fc0040ad8077942fd8b0d948b.

Right... I also quickly tested with Conduit: On http://phorge.localhost/conduit/method/maniphest.search/ entering integer values like 12 or 91 in the fields before, after, limit and this one-liner doesn't show an exception anymore. And same for older http://phorge.localhost/conduit/method/maniphest.query/ and the fields limit and offset there - no exceptions.

I confirm for e.g. https://we.phorge.it/D25079 or https://we.phorge.it/D25079?id=355 or https://we.phorge.it/D25079?id=360 that this only happens when not being logged in. Or on https://we.phorge.it/D25342?id=1111 stacking four errors on top of each other.

In D25374#10923, @Matthew wrote:

Please fix unit errors

@ncoker See T15586 instead