Page MenuHomePhorge

Countdown: add a capability to decide who can Create
ClosedPublic

Authored by 20after4 on Mar 27 2023, 16:12.
Referenced Files
Unknown Object (File)
Wed, Apr 24, 23:53
Unknown Object (File)
Sun, Apr 7, 10:25
Unknown Object (File)
Mon, Apr 1, 02:19
Unknown Object (File)
Mon, Apr 1, 01:05
Unknown Object (File)
Mon, Apr 1, 01:05
Unknown Object (File)
Mon, Apr 1, 01:05
Unknown Object (File)
Mar 25 2024, 07:35
Unknown Object (File)
Mar 25 2024, 07:35
Tokens
"Yellow Medal" token, awarded by valerio.bozzolan.

Details

Summary

This change adds the countdown.create capability to
allow to limit countdown creation.

This change comes from the Wikimedia Phabricator and
was originally proposed by v.bozzolan and implemented
by the kind user 20after4.

https://phabricator.wikimedia.org/T258599

Closes T15208
Ref T15081

Test Plan
  • go to the page /applications/view/PhabricatorCountdownApplication/
  • play a bit with the "Can Create Countdowns" option
  • note that it is respected

Diff Detail

Repository
rP Phorge
Branch
countdown.capability
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 194
Build 194: arc lint + arc unit

Event Timeline

If we implement it in the upstream, we may use it to restrict Countdown to Trusted Contributors if needed.

I accept this since I tested in my local and it works as expected. Thank you.

This revision is now accepted and ready to land.Apr 7 2023, 21:56

Thank you again @20after4. In my opinion you are free to land this in Phorge master right now if you want

Hi @20after4 thank you again for this nice patch. Can I can help to land this? :) No rush, but I like this.