Page MenuHomePhorge

Render all Removed Comments a little more docile
ClosedPublic

Authored by valerio.bozzolan on Mar 25 2023, 20:49.
Referenced Files
Unknown Object (File)
Sat, Apr 13, 04:53
Unknown Object (File)
Sat, Apr 13, 04:50
Unknown Object (File)
Sat, Apr 13, 04:49
Unknown Object (File)
Sun, Apr 7, 21:28
Unknown Object (File)
Thu, Apr 4, 23:37
Unknown Object (File)
Mon, Apr 1, 01:03
Unknown Object (File)
Mon, Apr 1, 01:03
Unknown Object (File)
Mon, Apr 1, 01:03
Tokens
"Like" token, awarded by Cigaryno.
Time Spent

Details

Summary

This small restyle makes any Removed Comment a little less
prominent than normal ones, with the goal of decreasing a
bit your in-page distractions and increase your individual
productivity in your business by at least 250 milliseconds
every 48 hours of hard work in front of your monitor.

BeforeAfter
Comments deleted Before D25096.png (319×340 px, 16 KB)
Comments deleted After D25096.png (298×343 px, 15 KB)

This implementation (which is called "Kasper on Diet")
contains these specific changes for Removed Comments:

  • user icon visibility: reduced by ~50% (-> Kasper)
  • black "trash" icon: reduced by ~50% (-> Diet)
  • texts: visibility reduced by ~50%
  • vertical padding: reduced from 16px down to 4px

Note that if your Phorge is under the Serious Business Mode,
it seems it is still technically possible to manually
activate the "Decaying Curse" proposal mentioned in the Task.

Closes T15192

Test Plan
  • Add a Comment "I love Phorge"
  • Add a Comment "I love Phabricator"
  • Mark the second Comment as Removed
  • Call a person at your desk
  • Plug that person to an eyeball tracker

If the general attention focuses first on a normal Comment and then
on the Removed Comment, this change works perfectly.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan edited the test plan for this revision. (Show Details)

avoid opacity just to change a background color since it's less efficient

This is how a removed comment will be rendered after this change:

Restyle removed Comments.png (299×554 px, 23 KB)

Here you can see A/B:

T15192: Removed Comments are too visually impactful

If you like it, feel free to +1

  • refactor to avoid an "!important" and fix corner case
  • fix lint about 80-chars limitation
  • adopt the already-defined grey color

You have chosen the best proposal without community consecus.

This revision is now accepted and ready to land.Apr 6 2023, 12:42