Page MenuHomePhorge

Removed Comments: add CSS class "phui-timeline-shell-removed"
AbandonedPublic

Authored by valerio.bozzolan on Mar 25 2023, 16:43.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 00:58
Unknown Object (File)
Wed, Mar 20, 23:15
Unknown Object (File)
Wed, Mar 20, 22:27
Unknown Object (File)
Wed, Mar 20, 14:10
Unknown Object (File)
Thu, Mar 14, 08:22
Unknown Object (File)
Thu, Mar 14, 08:22
Unknown Object (File)
Thu, Mar 14, 07:57
Unknown Object (File)
Thu, Mar 14, 07:52

Details

Summary

This boring change does not involve any graphical change.

After this change, a new CSS class is introduced to distinguish
comments that were removed. For example, this change allows to
easily distinguish removed Maniphest Tasks, so that your
critic web designers can now have a really good time during the
next hard CSS party in which you were not invited - as usual -
since we always treat designers badly and they don't get our nice
jokes about proprietary software etc.

In short, dear designer, try this CSS rule and have fun:

.phui-timeline-shell-removed {
   border: 20px solid red; /* Look at me! I'm a CSS rockstar! */
}

Unfortunately, you will have to learn some CSS to master that.
Your skills on drawing manga are not enough with Phorge. Sorry
for that. This is definitely a problem closely related to
Phorge and that no other website in the universe has.

In any case, instead of hacking your local CSS right now like
a rockstar to make everything big and red, please share your
ideas in this Task:

https://we.phorge.it/T15192

Thank you so much!

Closes T15191

Test Plan
  • Look a removed Comment from a Task page
  • Nothing special happens (that is OK)
  • Press the F-12 key in Firefox and try the above proposed CSS rule
  • See the removed comments can become really irritating thanks to my design talent
  • See that the normal comments are still as-is

Diff Detail

Repository
rP Phorge
Branch
T15191-tasks-removed-restyle
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 183
Build 183: arc lint + arc unit

Event Timeline

Your customization is very good.

maybe this is the right "remove" state (?)

it seems the same but more semantically correct

I truly do not understand what the hell it changes from:

  • a "deleted" comment
  • a "removed" comment

So, since the "set is edited" flag is checked against the "! has removed", I opted for the "removed" state.

Note: as far as I can see on the Maniphest page, I can interchange them and nothing changes: it works in both cases.

If you know the sneaky difference please indicate it. Otherwise, I think we can just don't care. After all, it is for a CSS rule and not at all a critical server-side logic with sneaky super corner-cases to be understood.

To be nice, I thought this modification would be fine on its own, since it is already very useful for designers to customize their installations.

This way we can take more time for things like:

D25096: Render all Removed Comments a little more docile

But if you want, I'll merge the two in one.

Yeah, this two changes (adding a class and using it) should go together.