Page MenuHomePhorge
Differential D25078

Trigger: Capitalize most Buzzwords in our Weird Way as usual
AbandonedPublic
Actions

Authored by valerio.bozzolan on Mar 22 2023, 00:08.

Details

Reviewers
Sten
Group Reviewers
O1: Blessed Committers
Test Plan
  • Open the Trigger Page from a Workboard Column
  • See that Most Things are Finally in this usual Weird Way

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25078
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 149
Build 149: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Mar 22 2023, 00:08
Owners added a reviewer: O1: Blessed Committers.Mar 22 2023, 00:08
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 22 2023, 00:08
valerio.bozzolan requested review of this revision.Mar 22 2023, 00:08
Harbormaster completed remote builds in B140: Diff 352.Mar 22 2023, 00:08
valerio.bozzolan updated this revision to Diff 353.Mar 22 2023, 00:10

update celerity to make the lint happy

Harbormaster completed remote builds in B141: Diff 353.Mar 22 2023, 00:10
valerio.bozzolan mentioned this in Z1: Phorge.Mar 22 2023, 14:34
valerio.bozzolan awarded a token.Mar 22 2023, 14:43
valerio.bozzolan updated this revision to Diff 361.Mar 22 2023, 18:07
  • also fix small typo "elmement"
Harbormaster completed remote builds in B149: Diff 361.Mar 22 2023, 18:07
valerio.bozzolan mentioned this in 2023-03-27.Mar 27 2023, 13:59
valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16
Sten accepted this revision.Aug 8 2023, 10:59
Sten subscribed.

Apart from the pre-existing 'Statues' typo, looks good to me...

src/applications/project/trigger/PhabricatorProjectTriggerManiphestStatusRule.php
27

Plural of 'Status' is 'Statuses'. 'Statues' is the plural of 'Statue', which is something different.

valerio.bozzolan updated this revision to Diff 1219.Aug 10 2023, 07:47

let's also fix a typo (thanks Sten)

Harbormaster completed remote builds in B737: Diff 1219.Aug 10 2023, 07:47
valerio.bozzolan abandoned this revision.Jan 12 2024, 21:43
valerio.bozzolan added a subscriber: aklapper.

Part of this Diff has no sense now that I learned that... some of these has sense. Let's close.

In D25507#14716, @aklapper wrote:
In D25507#14682, @valerio.bozzolan wrote:

Yeah I honestly don't know if uppercase or lowercase.

In this case should be lower-case because consistency and because it's pretty much a full sentence.

Relevant. "User Profiles":

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a page title and thus title case.

Also, "User profiles", 4 lines below:

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a button text or such and seems to be sentence case...

Revision Contents
Changeset List

Diff 361

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerAddProjectsRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerInvalidRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerManiphestOwnerRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerManiphestPriorityRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerManiphestStatusRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerPlaySoundRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerRemoveProjectsRule.php

Loading...
View Options

src/applications/project/trigger/PhabricatorProjectTriggerUnknownRule.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0