Page MenuHomePhorge

Trigger: Capitalize most Buzzwords in our Weird Way as usual
AbandonedPublic

Authored by valerio.bozzolan on Mar 22 2023, 00:08.
Tags
None
Referenced Files
F2057078: D25078.id.diff
Thu, Mar 28, 05:36
Unknown Object (File)
Mon, Mar 25, 08:08
Unknown Object (File)
Mon, Mar 25, 08:04
Unknown Object (File)
Sun, Mar 24, 05:52
Unknown Object (File)
Thu, Mar 21, 10:37
Unknown Object (File)
Thu, Mar 21, 10:08
Unknown Object (File)
Thu, Mar 21, 02:12
Unknown Object (File)
Wed, Mar 20, 18:41
Tokens
"Hungry Hippo" token, awarded by valerio.bozzolan.

Details

Reviewers
Sten
Group Reviewers
O1: Blessed Committers
Test Plan
  • Open the Trigger Page from a Workboard Column
  • See that Most Things are Finally in this usual Weird Way

Diff Detail

Repository
rP Phorge
Branch
capitalize-stuff-randomly
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 140
Build 140: arc lint + arc unit

Unit TestsFailed

TimeTest
767 msPhabricatorCelerityTestCase::testCelerityMaps
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
685 msPhabricatorConduitTestCase::testConduitMethods
1 assertion passed.
225 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
1 assertion passed.
251 msPhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries
1 assertion passed.
323 msPhabricatorLibraryTestCase::testEverythingImplemented
1 assertion passed.
View Full Test Results (1 Failed · 29 Passed)

Event Timeline

update celerity to make the lint happy

  • also fix small typo "elmement"
Sten subscribed.

Apart from the pre-existing 'Statues' typo, looks good to me...

src/applications/project/trigger/PhabricatorProjectTriggerManiphestStatusRule.php
27

Plural of 'Status' is 'Statuses'. 'Statues' is the plural of 'Statue', which is something different.

let's also fix a typo (thanks Sten)

valerio.bozzolan added a subscriber: aklapper.

Part of this Diff has no sense now that I learned that... some of these has sense. Let's close.

Yeah I honestly don't know if uppercase or lowercase.

In this case should be lower-case because consistency and because it's pretty much a full sentence.

Relevant. "User Profiles":

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a page title and thus title case.

Also, "User profiles", 4 lines below:

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a button text or such and seems to be sentence case...