Re "implement in php" - AFAICT, there's no built-in support for websockets in php, but I found at least 2 pure-php implementations out there that might work.

Thanks. We can update the "We didn't yet release a fix on Phorge" and the "We'll release" since D25967 it's now fixed in master 👍

In J6#66, @Cigaryno wrote:

Thanks for this! Is this any related to the security vulnerability warning I got with npm install last month, which prompted me to run npm audit fix?

Thanks for this! Is this any related to the security vulnerability warning I got with npm install last month, which prompted me to run npm audit fix?

Possible ways to reduce risk for future issues:

• add a Setup Check that runs npm audit
• remove node, use php-based websocket implementation

Relevant report:

This project is now abandonware without you. 😆

Gents, you’re both nothing short of geniuses

Gents, you’re both nothing short of geniuses—fixed before I’d even blinked! Thanks. Will look at fixing it permanently in T15513.

I can reproduce, looks like the change in src/applications/conpherence/controller/ConpherenceViewController.php is the culprit.
No clue what's a correct fix, thus proposing to revert the entire commit.

Eventually please try reverting this change in your local copy:

Tip: activate DarkConsole and check requests there 👍

From checking the network requests when I load an unrelated page and the modal appears, I can see a POST request to /conpherence/edit/1/ which returns the modal. I've attached both the request and the response, with light redactions, to P48 and P49.

D25012 solves it, but I wonder if we should just exclude it from the "type": "text" linters

ahh, there's a global setting for revisions - differential.generated-paths.

I was thinking of ArcanistGeneratedLinter.php, but it looks like the only way to mark a file is by adding @generated in it, and I think we can't do that?
I thought there was another way, because this also applies to revisions (it folds the file by default).

In T15021#564, @avivey wrote:

There might be a way to explicitly define it as generated, which (used to) exclude it from lint.

There might be a way to explicitly define it as generated, which (used to) exclude it from lint.

I see that this has been added to the changelog already here: https://we.phorge.it/w/changelog/2021.25/ . Fantastic!

I landed the code, but leaving the task open because we need to add a release note whenever we know where they go.