My only concern here is that technically this introduces issues for any user install that already contains an untracked package support/aphlict/server/package-lock.json

I feel that this needs to be addressed in "release notes" or "upgrade notes" somewhere - However, we do not yet have this process defined?

This was handled by Phacility/Phabricator with their changelog and process for promoting stable

In D25006#216, @Ekubischta wrote:

My only concern here is that technically this introduces issues for any user install that already contains an untracked package support/aphlict/server/package-lock.json

I feel that this needs to be addressed in "release notes" or "upgrade notes" somewhere - However, we do not yet have this process defined?

This was handled by Phacility/Phabricator with their changelog and process for promoting stable

In my updates to the Diviner documentation (T15012), I’ve been referencing a change log like Phacility had. We should probably continue to use that, at the very least.

In D25006#216, @Ekubischta wrote:

My only concern here is that technically this introduces issues for any user install that already contains an untracked package support/aphlict/server/package-lock.json

I feel that this needs to be addressed in "release notes" or "upgrade notes" somewhere - However, we do not yet have this process defined?

This was handled by Phacility/Phabricator with their changelog and process for promoting stable

I'm happy to add a release note somewhere, I'm just not sure where. Could you point me to the appropriate place?

In D25006#220, @deadalnix wrote:

I'm happy to add a release note somewhere, I'm just not sure where. Could you point me to the appropriate place?

We don't have one - I started T15014 to discuss

We should probably exclude the package-lock.json from linting rules, because it is auto generated.

I'm going to land this one as to not wait on things that are not sorted out, with the obvious note that a release note would be advantageous.