Page MenuHomePhorge

Add package.json for aphlict
ClosedPublic

Authored by deadalnix on Jun 19 2021, 17:15.

Details

Reviewers
Matthew
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Maniphest Tasks
T15019: Make Aphlict a node package
Commits
rP2258ba8535d5: Add package.json for aphlict
Summary

This makes the whole setup easier, future proof and reproducible.

Test Plan
cd support/aphlict/server/
npm install

See that ws gets installed as expected.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jun 19 2021, 17:15

My only concern here is that technically this introduces issues for any user install that already contains an untracked package support/aphlict/server/package-lock.json

I feel that this needs to be addressed in "release notes" or "upgrade notes" somewhere - However, we do not yet have this process defined?

This was handled by Phacility/Phabricator with their changelog and process for promoting stable

My only concern here is that technically this introduces issues for any user install that already contains an untracked package support/aphlict/server/package-lock.json

I feel that this needs to be addressed in "release notes" or "upgrade notes" somewhere - However, we do not yet have this process defined?

This was handled by Phacility/Phabricator with their changelog and process for promoting stable

In my updates to the Diviner documentation (T15012), I’ve been referencing a change log like Phacility had. We should probably continue to use that, at the very least.

My only concern here is that technically this introduces issues for any user install that already contains an untracked package support/aphlict/server/package-lock.json

I feel that this needs to be addressed in "release notes" or "upgrade notes" somewhere - However, we do not yet have this process defined?

This was handled by Phacility/Phabricator with their changelog and process for promoting stable

I'm happy to add a release note somewhere, I'm just not sure where. Could you point me to the appropriate place?

I'm happy to add a release note somewhere, I'm just not sure where. Could you point me to the appropriate place?

We don't have one - I started T15014 to discuss

We should probably exclude the package-lock.json from linting rules, because it is auto generated.

This revision is now accepted and ready to land.Jun 20 2021, 21:43

I'm going to land this one as to not wait on things that are not sorted out, with the obvious note that a release note would be advantageous.

This revision was landed with ongoing or failed builds.Jun 21 2021, 10:46
This revision was automatically updated to reflect the committed changes.