Page MenuHomePhorge

Exclude the Aphlict package-lock.json from linting rule
Closed, ResolvedPublic

Description

Refs D25006#288

support/aphlict/server/package-lock.json

This file should be excluded by most of the relevent rules in .arclint for this repo

Refs https://we.phorge.it/D25006?vs=on&id=30#toc

image.png (384×968 px, 25 KB)

Event Timeline

There might be a way to explicitly define it as generated, which (used to) exclude it from lint.

In T15021#564, @avivey wrote:

There might be a way to explicitly define it as generated, which (used to) exclude it from lint.

Where is this (generated) defined? - Give me a pointer and I will submit a revision!

Is this normally in a comment in the file itself?

Alternatively - any issues with adding this to .arclint

"exclude": [
        "/support/aphlict/server/package-lock.json"
    ]

I was thinking of ArcanistGeneratedLinter.php, but it looks like the only way to mark a file is by adding @generated in it, and I think we can't do that?
I thought there was another way, because this also applies to revisions (it folds the file by default).

Just excluding it from lint is also fine.

ahh, there's a global setting for revisions - differential.generated-paths.

D25012 solves it, but I wonder if we should just exclude it from the "type": "text" linters