Page MenuHomePhorge

Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup
ClosedPublic

Authored by Ekubischta on Jun 25 2021, 22:24.
Tags
None
Referenced Files
F186205: D25012.id36.diff
Tue, Oct 4, 00:25
Unknown Object (File)
Sat, Oct 1, 21:26
Unknown Object (File)
Sat, Oct 1, 06:33
Unknown Object (File)
Sat, Oct 1, 06:33
Unknown Object (File)
Sat, Oct 1, 06:33
Unknown Object (File)
Wed, Sep 28, 13:18
Unknown Object (File)
Sat, Sep 24, 01:47
Unknown Object (File)
Sat, Sep 24, 01:47
Subscribers

Details

Summary

Aphlict requires a machine generated package-lock.json that can trigger linters unnecessarily.

This revision excludes it from all linters

Test Plan

Testing

Fake Change to set off the linter
diff --git a/support/aphlict/server/package-lock.json b/support/aphlict/server/package-lock.json
index 8af62ae233..a417725182 100644
--- a/support/aphlict/server/package-lock.json
+++ b/support/aphlict/server/package-lock.json
@@ -2,11 +2,12 @@
   "name": "aphlict-server",
   "requires": true,
   "lockfileVersion": 1,
+  "testing" : true,
   "dependencies": {
     "ws": {
       "version": "7.5.0",
       "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.0.tgz",
-      "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgi4vw=="
+      "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfi4vw=="
     }
   }
 }
arc lint results
root@63c842bff39e:/srv/phorge/phorge# arc lint
>>> Lint for support/aphlict/server/package-lock.json:


   Warning  (TXT3) Line Too Long
    This line is 156 characters long, but the convention is 80 characters.

               7     "ws": {
               8       "version": "7.5.0",
               9       "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.0.tgz",
    >>>       10       "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfi4vw=="
              11     }
              12   }
              13 }
root@63c842bff39e:/srv/phorge/phorge#

Updated change

Change to .arclint
diff --git a/.arclint b/.arclint
index f215d93fdc..ca89c601e4 100644
--- a/.arclint
+++ b/.arclint
@@ -2,7 +2,8 @@
   "exclude": [
     "(^externals/)",
     "(^webroot/rsrc/externals/(?!javelin/))",
-    "(/__tests__/data/)"
+    "(/__tests__/data/)",
+    "(^support/aphlict/server/package-lock.json)"
   ],
   "linters": {
     "chmod": {
arc lint results
root@63c842bff39e:/srv/phorge/phorge# arc lint
 OKAY  No lint messages.
root@63c842bff39e:/srv/phorge/phorge#

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

We could move this from the global exclude to just the specific linters (like the txt linter, etc.) - That would be a reasonable request

Ekubischta retitled this revision from Updated .arclint in Phorge to exclude package-lock.json from Sphlict setup to Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup.
This revision is now accepted and ready to land.Jun 25 2021, 22:41

We could move this from the global exclude to just the specific linters (like the txt linter, etc.) - That would be a reasonable request

Since the file is auto-generated I think it makes sense to exclude globally