Page MenuHomePhorge

AphlictProject
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Jul 24 2023

avivey closed T15502: Aphlict expects Phorge to be installed in a directory called "phabricator" as Resolved by committing rPbf025c5fb491: Aphlict - search for default config in the right place.
Jul 24 2023, 07:42 · Bug Reports, Aphlict

Jul 10 2023

avivey added a revision to T15502: Aphlict expects Phorge to be installed in a directory called "phabricator": D25344: Aphlict - search for default config in the right place.
Jul 10 2023, 20:56 · Bug Reports, Aphlict

Jun 29 2023

Cigaryno added a project to T15502: Aphlict expects Phorge to be installed in a directory called "phabricator": Bug Reports.
Jun 29 2023, 10:49 · Bug Reports, Aphlict

Jun 26 2023

valerio.bozzolan added a parent task for T15502: Aphlict expects Phorge to be installed in a directory called "phabricator": T15006: Re-brand Phorge.
Jun 26 2023, 19:38 · Bug Reports, Aphlict
valerio.bozzolan triaged T15502: Aphlict expects Phorge to be installed in a directory called "phabricator" as Normal priority.
Jun 26 2023, 19:38 · Bug Reports, Aphlict

Jun 29 2021

Ekubischta closed T15021: Exclude the Aphlict package-lock.json from linting rule, a subtask of T15019: Make Aphlict a node package, as Resolved.
Jun 29 2021, 02:45 · Aphlict
Ekubischta closed T15021: Exclude the Aphlict package-lock.json from linting rule as Resolved.
Jun 29 2021, 02:45 · Aphlict

Jun 25 2021

Ekubischta added a comment to T15021: Exclude the Aphlict package-lock.json from linting rule.

D25012 solves it, but I wonder if we should just exclude it from the "type": "text" linters

Jun 25 2021, 22:27 · Aphlict
Ekubischta added a revision to T15021: Exclude the Aphlict package-lock.json from linting rule: D25012: Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup.
Jun 25 2021, 22:24 · Aphlict
Ekubischta claimed T15021: Exclude the Aphlict package-lock.json from linting rule.
Jun 25 2021, 22:18 · Aphlict
avivey added a comment to T15021: Exclude the Aphlict package-lock.json from linting rule.

ahh, there's a global setting for revisions - differential.generated-paths.

Jun 25 2021, 18:56 · Aphlict
avivey added a comment to T15021: Exclude the Aphlict package-lock.json from linting rule.

I was thinking of ArcanistGeneratedLinter.php, but it looks like the only way to mark a file is by adding @generated in it, and I think we can't do that?
I thought there was another way, because this also applies to revisions (it folds the file by default).

Jun 25 2021, 18:55 · Aphlict
Ekubischta added a comment to T15021: Exclude the Aphlict package-lock.json from linting rule.
In T15021#564, @avivey wrote:

There might be a way to explicitly define it as generated, which (used to) exclude it from lint.

Jun 25 2021, 18:49 · Aphlict

Jun 21 2021

avivey added a comment to T15021: Exclude the Aphlict package-lock.json from linting rule.

There might be a way to explicitly define it as generated, which (used to) exclude it from lint.

Jun 21 2021, 17:33 · Aphlict
Ekubischta updated the task description for T15021: Exclude the Aphlict package-lock.json from linting rule.
Jun 21 2021, 14:28 · Aphlict
Ekubischta updated the task description for T15021: Exclude the Aphlict package-lock.json from linting rule.
Jun 21 2021, 14:27 · Aphlict
Ekubischta created T15021: Exclude the Aphlict package-lock.json from linting rule.
Jun 21 2021, 14:26 · Aphlict
deadalnix closed T15019: Make Aphlict a node package as Resolved.

I see that this has been added to the changelog already here: https://we.phorge.it/w/changelog/2021.25/ . Fantastic!

Jun 21 2021, 11:43 · Aphlict
deadalnix added a comment to T15019: Make Aphlict a node package.

I landed the code, but leaving the task open because we need to add a release note whenever we know where they go.

Jun 21 2021, 11:39 · Aphlict

Jun 20 2021

Matthew added a revision to T15019: Make Aphlict a node package: D25006: Add package.json for aphlict.
Jun 20 2021, 23:48 · Aphlict
Matthew triaged T15019: Make Aphlict a node package as Normal priority.
Jun 20 2021, 23:47 · Aphlict

Jun 19 2021

speck abandoned D25004: Update .gitignore to account for package-lock.json.

Abandoning for D25006

Jun 19 2021, 17:25 · Aphlict
deadalnix added a comment to D25004: Update .gitignore to account for package-lock.json.

[...]

Jun 19 2021, 17:16 · Aphlict
Ekubischta added a comment to D25004: Update .gitignore to account for package-lock.json.

Without package-lock.json, it is not possible to deploy a consistent set of dependencies resolution - they might change any time any one publishes a new package, which creates a lot of problems for reproducibility.

Jun 19 2021, 15:32 · Aphlict
deadalnix added a comment to D25004: Update .gitignore to account for package-lock.json.

While I'm not super familiar with this setup, it is customary in the node space to commit package-lock.json int he repository. If it is intended to put stuff in there which are not to be committed at all - the folder is a placeholder - then it is best to ignore the whole folder. If committing what's in there is intended, then package-lock.json should be included.

Jun 19 2021, 10:44 · Aphlict
speck requested review of D25004: Update .gitignore to account for package-lock.json.
Jun 19 2021, 04:48 · Aphlict
speck updated the diff for D25004: Update .gitignore to account for package-lock.json.

Updating comment per discussion

Jun 19 2021, 03:31 · Aphlict
speck added a comment to D25004: Update .gitignore to account for package-lock.json.

I have some concerns regarding the new comment, as these files don't really belong to aphlict, but are npm npm artifcats. If node-ws is installed via e.g. the system package manager (which is probably the better idea anyway), these files/folders won't be created.

Jun 19 2021, 01:21 · Aphlict

Jun 18 2021

chris added a comment to D25004: Update .gitignore to account for package-lock.json.

Fair point on being precise with the terminology.

Jun 18 2021, 22:18 · Aphlict
tobiaswiese added a comment to D25004: Update .gitignore to account for package-lock.json.

I have some concerns regarding the new comment, as these files don't really belong to aphlict, but are npm npm artifcats. If node-ws is installed via e.g. the system package manager (which is probably the better idea anyway), these files/folders won't be created.

Jun 18 2021, 22:06 · Aphlict
chris accepted D25004: Update .gitignore to account for package-lock.json.
Jun 18 2021, 21:45 · Aphlict
tobiaswiese added a comment to D25004: Update .gitignore to account for package-lock.json.

Will this cause a conflict? - I feel like it will..?

Jun 18 2021, 21:37 · Aphlict
speck requested review of D25004: Update .gitignore to account for package-lock.json.

I created T15013: Better handling of node/npm installation for Aphlict for further discussion

Jun 18 2021, 21:19 · Aphlict
speck created T15013: Better handling of node/npm installation for Aphlict.
Jun 18 2021, 21:18 · Aphlict
chris added a comment to D25004: Update .gitignore to account for package-lock.json.

Will it cause a conflict or ask the user to commit or stash untracked changes? But yeahhhhhh, will need some human intervention...

Jun 18 2021, 20:23 · Aphlict
Ekubischta added a comment to D25004: Update .gitignore to account for package-lock.json.

What happens if

Jun 18 2021, 20:19 · Aphlict
tobiaswiese added a comment to D25004: Update .gitignore to account for package-lock.json.

The problem with package-lock.json is, that it either generates noise in the working copy (it just changes its content a lot of times during normal operation). And it needs an update every time a dependency (even indirect) got an security related update because production installs will otherwise not pull the updated dependency in.

Jun 18 2021, 19:53 · Aphlict
speck planned changes to D25004: Update .gitignore to account for package-lock.json.

Yea it probably won’t have an effect until they run npm install/ci. We could create those files and include. I’ll update

Jun 18 2021, 19:48 · Aphlict
tobiaswiese added a comment to D25004: Update .gitignore to account for package-lock.json.

AFAIK package-lock.json is only used by npm itself, when deciding on which version to download. If no package-lock.json exists the version are taken to match package.json.

Jun 18 2021, 19:46 · Aphlict
chris added a comment to D25004: Update .gitignore to account for package-lock.json.

Just confirmed on another instance:

  • Had an existing package-lock.json pinning ws to version 7.0.0
  • Manually updated package-lock.json to pin to version 7.5.0 (did not actually update installed version of ws)
  • Cycled Aphlict service
  • Sent a test notification
  • Received Web + Desktop popups
Jun 18 2021, 19:43 · Aphlict
chris added a comment to D25004: Update .gitignore to account for package-lock.json.

It _shouldn't_ mess up anything existing, I don't think. It's been a few months since I did a ton with JS so might be forgetting something obvious here, but if anyone already has Aphlict up and running, I'm pretty sure their existing install will be unimpacted by the presence/absense of package-lock.json. If they want to manually update their npm packages, then they might need the additional steps, but pretty sure it won't be disruptive outside of that.

Jun 18 2021, 19:30 · Aphlict
speck added a comment to D25004: Update .gitignore to account for package-lock.json.

I was thinking about having it version controlled and I do think that would be a good idea at some point. If we do that now I think that might mess up installations which happen to be running different versions of ws, or the upgrade path would require some additional steps. I think it would be something like

  1. Run npm uninstall
  2. Delete package-lock.json
  3. Upgrade
  4. Run npm ci which should follow the package-lock.json definitions
Jun 18 2021, 19:27 · Aphlict
speck added a project to D25004: Update .gitignore to account for package-lock.json: Aphlict.
Jun 18 2021, 19:21 · Aphlict
Ekubischta created Aphlict.
Jun 18 2021, 19:13