Page MenuHomePhorge

valerio.bozzolan (Valerio Bozz.)
ʕ•ᴥ•ʔ

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 6 2021, 12:36 (202 w, 3 d)
Availability
Available
Timezone
UTC+2

I'm a pasta pizza volunteer Phabrilover. I would like to do it all day long.

I use Phorge in:

  • my personal installation to handle my stuff (about 80 users)
  • in the company I work for (about 30 employees)
  • in the Wikimedia Phabricator (as simple user)

Please don't contact me in private for troubleshooting. Use the chat or ping me from Ponder.

Other links:

Recent Activity

Yesterday

valerio.bozzolan accepted D26007: Remove unused CSS file aphront/panel-view.css.

You grep like a rockstar

Fri, May 23, 17:29
valerio.bozzolan removed a reviewer for D26007: Remove unused CSS file aphront/panel-view.css: valerio.bozzolan.
Fri, May 23, 17:26
valerio.bozzolan resigned from D26007: Remove unused CSS file aphront/panel-view.css.

Unlocking patch

Fri, May 23, 17:26
valerio.bozzolan added a subtask for T15018: Make Harbormaster more generally usable and extendable: T16041: Harbormaster Build Plan: improve input "Depends On".
Fri, May 23, 06:53 · Connor Gurney, Almanac/Drydock/Harbormaster
valerio.bozzolan added a parent task for T16041: Harbormaster Build Plan: improve input "Depends On": T15018: Make Harbormaster more generally usable and extendable.
Fri, May 23, 06:53 · User-valerio.bozzolan, UX, Feature Requests, Almanac/Drydock/Harbormaster
valerio.bozzolan added a project to T16041: Harbormaster Build Plan: improve input "Depends On": User-valerio.bozzolan.
Fri, May 23, 06:53 · User-valerio.bozzolan, UX, Feature Requests, Almanac/Drydock/Harbormaster

Thu, May 22

valerio.bozzolan requested changes to D26007: Remove unused CSS file aphront/panel-view.css.

Flagging as "andre is merging stuff https://we.phorge.it/D26007#26996"

Thu, May 22, 12:49
valerio.bozzolan updated the summary of D25995: Remove orphan CSS selectors in PHUIFormView.
Thu, May 22, 12:47
valerio.bozzolan accepted D25995: Remove orphan CSS selectors in PHUIFormView.

Very good job as usual 👍

Thu, May 22, 12:47
valerio.bozzolan accepted D26030: Fix project typeahead query with columns when string is not name prefix.

Nice. I'm 99% sure about the test plan, please see https://we.phorge.it/T16068#22703 before landing to adjust it, eventually.

Thu, May 22, 12:38
valerio.bozzolan added a comment to T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)".

Questions about the steps:

Thu, May 22, 12:24 · Bug Reports

Wed, May 21

valerio.bozzolan updated the diff for D26026: Add a Before-Destruction Engine.
  • fix last typo
Wed, May 21, 13:39
valerio.bozzolan updated the diff for D26026: Add a Before-Destruction Engine.
  • @return list<PhabricatorDestructionEngineExtension>
Wed, May 21, 13:33
valerio.bozzolan closed T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time), a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Wed, May 21, 09:59 · PHP 8 support
valerio.bozzolan closed D26029: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72.
Wed, May 21, 09:59
valerio.bozzolan closed T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time) as Resolved by committing rPaf4ac8bd9567: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from….
Wed, May 21, 09:59 · Calendar, PHP 8 support
valerio.bozzolan committed rPaf4ac8bd9567: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from….
Wed, May 21, 09:59
valerio.bozzolan added inline comments to D26026: Add a Before-Destruction Engine.
Wed, May 21, 09:51
valerio.bozzolan updated the diff for D26026: Add a Before-Destruction Engine.
  • fix typos
  • add PHPDoc @return
Wed, May 21, 09:50
valerio.bozzolan accepted D26006: Remove unused FatCow icon files.

Thanks! Additionally, it seems it's not possible to use these through {icon NAME} since it only supports font awesome AFAIK

Wed, May 21, 08:49
valerio.bozzolan added a comment to D26024: Make long phui-tag-view object titles wrap in Remarkup context.

Seems very useful thanks, I would like to find small extra time to expand the test plan a bit more and run these extra tests, since this sounds very "core"

Wed, May 21, 07:37

Tue, May 20

valerio.bozzolan updated subscribers of D26026: Add a Before-Destruction Engine.
Tue, May 20, 15:57
valerio.bozzolan added a comment to D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.

Is getDisplayIconColor() related to these? (spoiler: probably it's not)

Tue, May 20, 13:45
valerio.bozzolan claimed T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time).

Yet another one strlen(null)...

Tue, May 20, 13:40 · Calendar, PHP 8 support
valerio.bozzolan added a revision to T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time): D26029: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72.
Tue, May 20, 13:39 · Calendar, PHP 8 support
valerio.bozzolan requested review of D26029: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72.
Tue, May 20, 13:39
valerio.bozzolan created T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time).
Tue, May 20, 13:35 · Calendar, PHP 8 support
valerio.bozzolan accepted D26028: Explain consequences when adding second Multi-Factor Auth.

Love this. Feel free to evaluate the addition of thus, dramatically increasing your corporate security (at the price of slowing you down even more). as stated here lol https://we.phorge.it/D26028#27452 or whatever small thing could help to better visualize this alien behavior that is very peculiar of Phorge (that is, as already said, not intuitive).

Tue, May 20, 12:48
valerio.bozzolan added a comment to D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.

Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?

Tue, May 20, 12:43
valerio.bozzolan awarded D26000: Remove orphan CSS selectors in calendar/phui-calendar.css a Yellow Medal token.
Tue, May 20, 12:38
valerio.bozzolan added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

Maybe better to just expand dialog, so, less code to maintain (?)

Tue, May 20, 12:36
valerio.bozzolan added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

(I just mean the feature comes from Phabricator, not from Phorge; sorry I always pick random words to express myself)

Tue, May 20, 12:33
valerio.bozzolan added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

Awesome. Optional bonus point, since this legacy feature thing is indeed veeeery confusing and very-Phorgi, maybe we may want to add a "Why" Phorge decided this, and highlight potential pitfalls.

Tue, May 20, 12:30
valerio.bozzolan added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

Seems nice. Maybe we can generalize the text a bit to avoid "both" (since you can have multiple of them).

Tue, May 20, 12:12
valerio.bozzolan added a subtask for T16060: arc diff: it could auto-claim the Task, if unclaimed: T15153: Document the special syntax you can use in commit messages to cause effects.
Tue, May 20, 11:46 · Discussion Needed, User-valerio.bozzolan, Feature Requests, Arcanist
valerio.bozzolan added a parent task for T15153: Document the special syntax you can use in commit messages to cause effects: T16060: arc diff: it could auto-claim the Task, if unclaimed.
Tue, May 20, 11:46 · Documentation, Diffusion, User-valerio.bozzolan
valerio.bozzolan updated the diff for D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.

fix PHPDoc - thanks andre

Tue, May 20, 10:22
valerio.bozzolan archived Wikimedia Hackathon 2025.
Tue, May 20, 09:35
valerio.bozzolan edited Description on Wikimedia Hackathon 2025.
Tue, May 20, 09:35
valerio.bozzolan moved T16060: arc diff: it could auto-claim the Task, if unclaimed from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.
Tue, May 20, 09:32 · Discussion Needed, User-valerio.bozzolan, Feature Requests, Arcanist
valerio.bozzolan moved T15973: Fix unit test PhutilRemarkupEngineTestCase from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:31 · Wikimedia Hackathon 2025, Bug Reports, User-valerio.bozzolan, Remarkup
valerio.bozzolan moved T15967: Fix unit test PhutilPygmentizeParserTestCase from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:31 · Wikimedia Hackathon 2025, Bug Reports, User-valerio.bozzolan, Remarkup
valerio.bozzolan moved T16061: PhabricatorEnv isSelfURI(): add small cache of these self-URIs from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:31 · User-valerio.bozzolan, Feature Requests
valerio.bozzolan moved T16079: Allow extensions to define "Before Destruction" engines from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:31 · Extension Development, Feature Requests, User-valerio.bozzolan
valerio.bozzolan moved T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one") from Code Sprint Candidate to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:30 · Feature Requests, Policy, User-valerio.bozzolan, People
valerio.bozzolan moved T16043: Create Unit Tests to cover Project Destroy from Code Sprint Candidate to PingDeath 🌚 on the User-valerio.bozzolan board.
Tue, May 20, 09:30 · Wikimedia Hackathon 2025, User-valerio.bozzolan, Feature Requests, Projects
valerio.bozzolan moved T15160: The Feed should not display the old content of an edited Comment as default from Code Sprint Candidate to 🔥 Trap on the User-valerio.bozzolan board.
Tue, May 20, 09:29 · Feed, Comments, User-valerio.bozzolan
valerio.bozzolan closed T16080: Evaluate a new database index to cover user.profileImagePHID as Wontfix.

The scenario in which this index would be needed is far from being normal. The patch D26027 that would benefit for it, is able to avoid that query in 99% of cases (it only needs such query when you want to destroy a profile picture, AND that picture was manually un-attached... why was it manually un-attached? by a spam click? by a faulty mouse?). So, the normal scenario is too small and unclear to justify a new index.

Tue, May 20, 08:16 · User-valerio.bozzolan, People
valerio.bozzolan closed T16080: Evaluate a new database index to cover user.profileImagePHID, a subtask of T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image), as Wontfix.
Tue, May 20, 08:16 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan updated the diff for D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.

add extra inline comments about T16080

Tue, May 20, 08:04
valerio.bozzolan added a revision to T16080: Evaluate a new database index to cover user.profileImagePHID: D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Tue, May 20, 07:57 · User-valerio.bozzolan, People
valerio.bozzolan updated the summary of D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Tue, May 20, 07:57
valerio.bozzolan added inline comments to D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Tue, May 20, 07:49
valerio.bozzolan updated the diff for D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
  • implement review tips from @mainframe98 - thanks
  • cover the edge case of a profile picture without attachments
Tue, May 20, 07:49
valerio.bozzolan created T16080: Evaluate a new database index to cover user.profileImagePHID.
Tue, May 20, 07:35 · User-valerio.bozzolan, People

Mon, May 19

valerio.bozzolan renamed T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one") from People: profile picture should be editable by their author (not by "No one") to People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one").
Mon, May 19, 23:06 · Feature Requests, Policy, User-valerio.bozzolan, People
valerio.bozzolan updated the name of F4303989: File cannot be Edited or Removed.png from "image.png" to "File cannot be Edited or Removed.png".
Mon, May 19, 22:45
valerio.bozzolan attached a referenced file: F4303304: profile-picture-404-error.jpg.
Mon, May 19, 22:37
valerio.bozzolan claimed T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image).
Mon, May 19, 22:36 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan claimed T16078: PhabricatorFileAttachmentQuery: allow to easily find which users are using a profile picture (allow to only get users, and only get attachments).
Mon, May 19, 22:35 · Files, Feature Requests, User-valerio.bozzolan
valerio.bozzolan requested review of D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Mon, May 19, 22:35
valerio.bozzolan added a revision to T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one"): D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Mon, May 19, 22:35 · Feature Requests, Policy, User-valerio.bozzolan, People
valerio.bozzolan added a revision to T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image): D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Mon, May 19, 22:35 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan added a revision to T16078: PhabricatorFileAttachmentQuery: allow to easily find which users are using a profile picture (allow to only get users, and only get attachments): D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Mon, May 19, 22:35 · Files, Feature Requests, User-valerio.bozzolan
valerio.bozzolan added a revision to T16079: Allow extensions to define "Before Destruction" engines: D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Mon, May 19, 22:35 · Extension Development, Feature Requests, User-valerio.bozzolan
valerio.bozzolan attached a referenced file: F4303304: profile-picture-404-error.jpg.
Mon, May 19, 21:48 · Extension Development, Feature Requests, User-valerio.bozzolan
valerio.bozzolan requested review of D26026: Add a Before-Destruction Engine.
Mon, May 19, 21:48
valerio.bozzolan added a revision to T16079: Allow extensions to define "Before Destruction" engines: D26026: Add a Before-Destruction Engine.
Mon, May 19, 21:48 · Extension Development, Feature Requests, User-valerio.bozzolan
valerio.bozzolan added a revision to T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image): D26026: Add a Before-Destruction Engine.
Mon, May 19, 21:48 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan created T16079: Allow extensions to define "Before Destruction" engines.
Mon, May 19, 20:55 · Extension Development, Feature Requests, User-valerio.bozzolan
valerio.bozzolan added a comment to T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image).

Again, expanding a PhabricatorFileAttachment to support a destruction engine to post-pone its destruction does NOT work as intended (as it's still destroyed very after the file) since the destroyObjectPermanently() is always supposed to be executed BEFORE the extensions.

Mon, May 19, 20:43 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan added a comment to T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image).

OK I've explored the proposal n. 1 about expanding PhabricatorFileAttachment to support PhabricatorDestructibleInterface, but I'm just moving the problem there. The attachment is still immediately nuclearized BEFORE the extensions can do things.

Mon, May 19, 20:22 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan added a comment to T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image).

When you destroy a PhabricatorFile, it seems this happens:

Mon, May 19, 20:00 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan accepted D26025: Add PHPDoc to PhabricatorPHIDType::canLoadNamedObject().

lgtm

Mon, May 19, 18:38
valerio.bozzolan created T16078: PhabricatorFileAttachmentQuery: allow to easily find which users are using a profile picture (allow to only get users, and only get attachments).
Mon, May 19, 17:14 · Files, Feature Requests, User-valerio.bozzolan
valerio.bozzolan added a comment to T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image).

It seems it's necessary to be able to "get the user from a profile picture". This is not easy, since the user seems not mentioned in any obvious way from the file object, as already stated in T15407.

Mon, May 19, 16:42 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan updated the task description for T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image).
Mon, May 19, 16:15 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan added a cover image to T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image).
Mon, May 19, 16:15 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan updated the task description for T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one").
Mon, May 19, 15:58 · Feature Requests, Policy, User-valerio.bozzolan, People
valerio.bozzolan accepted D25978: Fix wrong argument count in numerous calls' signatures.

Macro basketslam:  SLAM APPROVE

Mon, May 19, 14:12
valerio.bozzolan created Image Macro "basketslam".
Mon, May 19, 14:11
valerio.bozzolan updated the test plan for D25978: Fix wrong argument count in numerous calls' signatures.
Mon, May 19, 14:10
valerio.bozzolan updated the diff for D25772: Projects: improve quality of destroy workflow.

Reword inline comment to be about our hero, Mario.

Mon, May 19, 14:04 · Projects
valerio.bozzolan updated the diff for D25772: Projects: improve quality of destroy workflow.

Can we also destroy the root project A? Sure! Added in the unit test.

Mon, May 19, 13:56 · Projects
valerio.bozzolan moved T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image) from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.
Mon, May 19, 11:07 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan added inline comments to D25978: Fix wrong argument count in numerous calls' signatures.
Mon, May 19, 10:19
valerio.bozzolan added a comment to D25872: Implements arc work for git workflow.

Seems nice! Feel free to update.

Mon, May 19, 09:48
valerio.bozzolan added a comment to D25978: Fix wrong argument count in numerous calls' signatures.

Partial review, will conclude (I hope asd)

Mon, May 19, 07:18
valerio.bozzolan accepted D26023: Ignore bogus cards parameter string values in Hovercards calls.

sgtm

Mon, May 19, 07:00
valerio.bozzolan created T16076: Understand if we still need our own JSON parser.
Mon, May 19, 06:57 · User-valerio.bozzolan, Phorge

Sun, May 18

valerio.bozzolan added inline comments to D26023: Ignore bogus cards parameter string values in Hovercards calls.
Sun, May 18, 20:44
valerio.bozzolan added a subtask for T15814: Files: reduce number of orphan transformed files: T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one").
Sun, May 18, 19:54 · User-valerio.bozzolan, People
valerio.bozzolan added a parent task for T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one"): T15814: Files: reduce number of orphan transformed files.
Sun, May 18, 19:54 · Feature Requests, Policy, User-valerio.bozzolan, People
valerio.bozzolan removed a parent task for T15814: Files: reduce number of orphan transformed files: T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one").
Sun, May 18, 19:53 · User-valerio.bozzolan, People
valerio.bozzolan removed a subtask for T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one"): T15814: Files: reduce number of orphan transformed files.
Sun, May 18, 19:53 · Feature Requests, Policy, User-valerio.bozzolan, People
valerio.bozzolan added a comment to T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one").

Plus, making the file editable by the author is the cure of T15814, so, moving that as parent task.

Sun, May 18, 19:53 · Feature Requests, Policy, User-valerio.bozzolan, People
valerio.bozzolan added a comment to T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one").

If we allow authors to destroy their images, we should also avoid 404 errors on them. So, the new subtask T16074.

Sun, May 18, 19:52 · Feature Requests, Policy, User-valerio.bozzolan, People
valerio.bozzolan added a parent task for T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image): T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one").
Sun, May 18, 19:52 · Feature Requests, User-valerio.bozzolan, People
valerio.bozzolan added a subtask for T15407: People: Profile Pictures should be Editable and Deletable by their Authors (not by "No one"): T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image).
Sun, May 18, 19:52 · Feature Requests, Policy, User-valerio.bozzolan, People
valerio.bozzolan created T16074: Profile picture destroy workflow: it should not cause 404 errors (it should set the builtin image).
Sun, May 18, 19:51 · Feature Requests, User-valerio.bozzolan, People