Mark as "some comments"

Covered, thanks for review :3

I need to sleep

transaction.search: handle unmanaged exception when objectType is not supported

Thaanks. Can reproduce in latest master. Premising that uhmmmm probably it seems we are not using the API correctly as the correct usage seems with objectType=TASK. Example to get my transactions:

add more edge cases in unit tests

If you mean this kind of hardcoded CSS rules, yes, it's possible for local installs:

Yessss, I agree and we explored a bit the creation of new transactions as good long-term direction, unfortunately it seems still necessary a bit of CSS help from the backend to cover the legacy data (e.g. 10 years old bot-generated comments, with traditional comments)

Uhm... can we sleep with the very possible possibility of having "User Bot" possibly everywhere? 🌈

removed nonsense comment (last change.zip)

fix damn 81 lines lint

add destroy unit test for A > B > C and milestone (I love computers)

look mum, I'm learning English

improve comments (again) - thanks

avoid double unset(), just use or

update inline doc, thanks aklapper

I've tested this again in my production on gitpull.it (lol) and I cannot see whatsoever change in the resulting project report (and I'm sure that the page I'm testing is the one affected since I've introduced some logs in-code). So, approving 👍

I agree about the mystery in the test plan. Anyway, easily test-able by replacing $this->getMetadataValue('stub:create:phid') with a PHID lol. Thaaaanks all.

Should we phlog($e) in your opinion?

Obtained with:

(double-slam-accept)

Tested in my production 🤩 fail before, works after, thanks lol

(Plus, a domain 0 is nonsense, so the well-known PHP pitfall of if($something) is excluded here - double-slam-accept)

In D25694#19273, @aklapper wrote:

I'm not sure it matters for now as Phorge does not seem to accept non-ascii domains anyway (with a confusing error message):

[acko@fedora phorge (T15859preFetch *$|u+1)]$ ./bin/config set "security.alternate-file-domain" "https://苗条.example.com"
Usage Exception: Config option 'security.alternate-file-domain' is invalid. The URI must start with 'http://' or 'https://'.
[acko@fedora phorge (T15859preFetch *$|u+1)]$ ./bin/config set "security.alternate-file-domain" "https://áéexample.com"
Usage Exception: Config option 'security.alternate-file-domain' is invalid. The URI must start with 'http://' or 'https://'.

avoid to introduce a PHP 8 issue (thanks @mainframe98)

I've done my best to try to understand what we are talking about, so, I've created a nonsense X grid made in this way to catch changes:

Be bold Andre, feel free to land 🚀

(Damn Phorge that auto-claims also for wontfix)

Maybe we can wontfix this. The current "workaround" D25485 by @waldyrious is just great and effectively fixed the super-confusing root problem.

Thanks Andre who fixed all the sub-tasks and deserves all the glory here. I cannot imagine more things to be covered, so, boldly closing.

Thanks. We can update the "We didn't yet release a fix on Phorge" and the "We'll release" since D25967 it's now fixed in master 👍

If the CSS rule should not change anything, why does it change something?

Yuuum. As I mentioned downstream ( https://phabricator.wikimedia.org/T380361#10778444 ) I think probably, fortunately, nobody noticed this in a real world, since it's complicated to cause this condition using the API, and probably impossible from the web interface, but this still seems somehow a reasonable workflow and not dead code and the change makes sense. Thaaaanks

Kindly flagging as "little fixes needed on unit tests"