Double-accept

In D25823#22340, @keithzg wrote:

... Conversely, arc browse . works for what I expected a pathless invocation to do, and funny enough that doesn't work on Git repos! So we have feature parity ;)

Thanks. Can you reproduce with "Upload file" button too? If yes, maybe sub-task of: T15106: "Upload file" in remarkup text fields should attach by default

@avivey Thanks for the tip about arguments allow-list in getArguments() https://we.phorge.it/source/arcanist/browse/master/src/workflow/ArcanistLintWorkflow.php$67 but I was not able to use that since here it's using getWorkflowArguments() 🤔 So I've just added a warning. It works lol. Check "BRANCH OPTION NOT AVAILABLE"

found a corner case, fixed

I think that, after the hidden comment is loaded in its bulk, "some more comments" are loaded as context for the hidden comment 🤔 So I guess that extra loading is probably a feature and not a bug.

Wikimedia Foundation has this in production since years. I think it doesn't hurt.

Hi @keithzg (and any SVN hacker) do you like the new added Subversion support?

Probably not enough consensus for a mass edit. Best we can do is case-by-case fixes reading warn reports.

Any other test plan suggested? Current ones: delete simple milestone, delete project with milestone, delete a project with sub-projects, delete a sub-project, ecc.

helping reviewers, adding comment on future export possibility

fix lint, happy review

it works!

add extra escape

OMG IT WORKS

Thanks. Seems good to me since trim($new) does not receive null so cannot create PHP 8.1 problems, since we already execute strlen($new) and mb_strlen($new) and that was not reporting errors in your updated install

I see the API maniphest.createtask is frozen, maybe this can also create tasks: https://we.phorge.it/conduit/method/maniphest.edit/

I will add a warning about --branch and better management

Thanks, little cute Phorge kitten in profile picture <3

Has anybody a terminal with non-English environment and that obtains a non-English output with this command?

Thank you for trying. Let's continue the "how to reproduce" discussion in the bug report T15927

@BlankEclair Do you want a little help to land this?

@Iniquity - Problem solved by removing that sentence lol - thanks. Now seems super-freshy

Uh! Out of curiosity, what does the notification look like in your web notifications?

P.S. maybe relevant - maybe not :D lol https://we.phorge.it/T15945#19568

Any guess about a supposed right value for service? lol Just for my curiosity

Just talking about accessibility, maybe interesting, Wikipedia on mobile allows to scale, but setting a minimum and maximum scale:

free -h ?

In D25823#22041, @avivey wrote:

mm, isBranchJustFilesystemPath() makes more sense now, as in "the branch name is part of the URI path"...

Maybe I should just try to improve the ArcanistRepositoryAPI#getDefaultBranch() 🤔 since the root problem is there, and the current solution just involves more code to avoid to fallback on that "master" default

move confusing comment

In D25823#22023, @avivey wrote:

a. I'm not sure I like isBranchJustFilesystemPath() to check Is this SVN - if we're trying to be generic, then there may be a different vcs that does this particular trick, but has different logic; And if we're not trying to be generic, then isSVN() is probably a good-ish name? or isVCS('SVN').

wow, it also makes sense to add --branch support to SVN! added

integrate tips

Visit this page: https://we.phorge.it/F2517458 and Edit thanks

Note that I introduced the method isBranchJustFilesystemPath() that returns something different for Subversion, just to recognize Subversion,

(Please mark the file as visible to everybody - thanks)

Nice test plan thanks

Uh, looking at line 112, the return status seems correct and expected. I had not seen that first. Thanks for fixing the constructor.

In general the reporter should really find a small way to reproduce their problem, also because among all the things written here (https://we.phorge.it/book/contrib/article/bug_reports/), everybody may agree with the first point:

Slam-accept

Dear arp, please clone and hack a lot on Phorge :) Thanks and feel free to share any question

Taking the best from the two: what about assuming a default @link /book/group/best-document-ever-about-link - but still allowing custom @link to allow easy migrations?