Paths

Table of Contentst

Differential D26077

Fail more gracefully passing an array to AphrontRequest::getStr()
AcceptedPublic
Actions

Authored by aklapper on Tue, Jun 10, 17:15.

Tags

None

Referenced Files

	F5311739: D26077.1749954861.diff
	Sat, Jun 14, 02:34

	F5277304: D26077.1749910763.diff
	Fri, Jun 13, 14:19

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T16102: Fail more gracefully passing an array to AphrontRequest::getStr($param)

Summary

It is possible to construct URIs with array parameters which end up in AphrontRequest::getStr() which previously just casted the passed value to a string via a (string) prefix.
This leads to an ugly EXCEPTION: (RuntimeException) Array to string conversion.

Instead, fail more gracefully with (Exception) Value passed to "phutil_string_cast()" is an array; arrays can not be sensibly cast to strings.

Closes T16102

Test Plan

Unclear.

Diff Detail

Repository

Branch

arrayT16102 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2088
Build 2088: arc lint + arc unit

Event Timeline

aklapper created this revision.Tue, Jun 10, 17:15

Owners added a reviewer: O1: Blessed Committers.Tue, Jun 10, 17:15

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Jun 10, 17:15

aklapper requested review of this revision.Tue, Jun 10, 17:15

Harbormaster completed remote builds in B2088: Diff 3203.Tue, Jun 10, 17:15

Wow, that utility is utilized and uteful 🧐

This revision is now accepted and ready to land.Tue, Jun 10, 17:44

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

aphront/

AphrontRequest.php

2 lines

17%

Loading...

O1: Blessed Committers

Diff 3203

src/aphront/AphrontRequest.php

Loading...