Page MenuHomePhorge

When Points are disabled, replace "Point Limit" with "Count Limit" label
AcceptedPublic

Authored by valerio.bozzolan on Wed, Jun 11, 10:25.

Details

Summary

When Maniphest points are disabled (the default) we have some labels talking about "Point Limit" but they are really working like a "Count Limit",
so we update the labels accordingly.

After this change, when the option maniphest.points is enabled:

  • everything remains as-is

After this change, When that option is disabled (the default):

  • labels about count limit, are "Count Limit"

We just avoid confusion with what really happens.

This task is NOT about changing the backend or changing behavior.

BeforeAfter
Workboard with Point Limit.png (447×561 px, 130 KB)
Workboard with Count Limit.png (447×561 px, 130 KB)
Column with Point Limit.png (238×822 px, 29 KB)
Column with Count Limit.png (238×822 px, 28 KB)

Closes T16104

Test Plan

Check the configuration page /config/edit/maniphest.points/ - have it empty (no points):

  • visit a workboard column and click edit: - you see "Count Limit" (no more Point Limit)
  • visit the page /project/board/1/column/1/ - you see "Count Limit" (no more Point Limit)

To check for regressions, toggle the configuration /config/edit/maniphest.points/ to activate points:

  • visit a workboard column and click edit: - you see "Point Limit"
  • visit the page /project/board/1/column/1/ - you see "Point Limit"

Diff Detail

Repository
rP Phorge
Branch
fix-user-interface-when-points-are-disabled
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2089
Build 2089: arc lint + arc unit

Event Timeline

aklapper subscribed.

Nice. Tested locally, works as expected.
Also grep'ed for Limit and couldn't find other places.

works-on-my-machine.jpg (191×199 px, 21 KB)

This revision is now accepted and ready to land.Wed, Jun 11, 16:47
aklapper retitled this revision from When Points are disabled, avoid labels "Point Limit" because they act as Count Limit to When Points are disabled, replace "Point Limit" with "Count Limit" label.Wed, Jun 11, 16:48