Page MenuHomePhorge
Feed All Stories

Sat, May 10

aklapper created T16067: Uploaded image files after transformations become/remain public.
Sat, May 10, 10:38

Fri, May 9

mainframe98 accepted D25955: Unhandled Exception: Add last call to error message.
Fri, May 9, 17:37
taavi added projects to T16066: Unnecessary HTML escaping in plain-text email: Mail, Bug Reports.
Fri, May 9, 15:10 · Bug Reports, Mail
taavi created T16066: Unnecessary HTML escaping in plain-text email.
Fri, May 9, 15:09 · Bug Reports, Mail
valerio.bozzolan lowered the priority of T15160: The Feed should not display the old content of an edited Comment as default from Low to Wishlist.

Uhm this is a damn rabbit hole.

Fri, May 9, 14:53 · Feed, Comments, User-valerio.bozzolan
aklapper added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.

Fri, May 9, 13:10
aklapper requested review of D26009: Remove orphan CSS selectors in phui/phui-action-panel.css.
Fri, May 9, 13:02
aklapper requested review of D26008: Remove orphan CSS selectors in phui/phui-header-view.css.
Fri, May 9, 12:57
aklapper updated the summary of D26007: Remove unused CSS file aphront/panel-view.css.
Fri, May 9, 12:57
valerio.bozzolan added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

Maybe also we can drop something from ./webroot/rsrc/css/core/remarkup.css - since it seems to contain .aphront-panel-preview ( .aphront-panel-preview .phabricator-remarkup-mention-unknown)

Fri, May 9, 12:44
aklapper requested review of D26007: Remove unused CSS file aphront/panel-view.css.
Fri, May 9, 12:40
aklapper requested review of D26006: Remove unused FatCow icon files.
Fri, May 9, 11:17
aklapper updated the diff for D26005: Remove unused keyboard shortcuts code.

another round of bin/celerity map

Fri, May 9, 11:01
aklapper requested review of D26005: Remove unused keyboard shortcuts code.
Fri, May 9, 10:57
aklapper created T16065: PHP Deprecation warnings in STDERR can make arc fail.
Fri, May 9, 10:17
aklapper added a comment to D25955: Unhandled Exception: Add last call to error message.

I guess this welcomes another review / testing. Works fine here.™

Fri, May 9, 09:40
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Also update comment

Fri, May 9, 09:35
valerio.bozzolan awarded T15160: The Feed should not display the old content of an edited Comment as default a Hungry Hippo token.
Fri, May 9, 09:28 · Feed, Comments, User-valerio.bozzolan
aklapper edited the content of Next Up.
Fri, May 9, 09:27
aklapper edited the content of Next Up.
Fri, May 9, 09:26
valerio.bozzolan added a comment to T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4).

Thanks. I pinpoint also here your super-relevant extra details: https://we.phorge.it/D25887#26924

Fri, May 9, 09:25 · Deprecation Notice, PHP 8 support, Bug Reports
aklapper closed D25886: Remove use of deprecated E_STRICT PHP constant.
Fri, May 9, 09:24
aklapper committed rARC29575b4f9187: Remove use of deprecated E_STRICT PHP constant.
Fri, May 9, 09:24
aklapper closed T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4) as Resolved by committing rP6619fef2ff97: Remove use of deprecated E_STRICT PHP constant.
Fri, May 9, 09:23 · Deprecation Notice, PHP 8 support, Bug Reports
aklapper closed D25887: Remove use of deprecated E_STRICT PHP constant.
Fri, May 9, 09:23
aklapper committed rP6619fef2ff97: Remove use of deprecated E_STRICT PHP constant.
Fri, May 9, 09:23
aklapper added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

Just for my curiosity, can you please also follow the tip from the screenshot (before the patch), so, using --trace?

Fri, May 9, 09:21
valerio.bozzolan added a comment to T15160: The Feed should not display the old content of an edited Comment as default.

Trying the ManiphestTransactionEditor leads to a dead end. Added personal notes about it...

Fri, May 9, 09:21 · Feed, Comments, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15160: The Feed should not display the old content of an edited Comment as default.
Fri, May 9, 09:20 · Feed, Comments, User-valerio.bozzolan
valerio.bozzolan added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

Just for my curiosity, can you please also follow the tip from the screenshot (before the patch), so, using --strace?

Fri, May 9, 08:12
aklapper added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

I'd still not expect it to actually break anything - the docs say this const is "deprecated" not "removed", so I'd expect a warning and everything to keep working.

Fri, May 9, 08:04
aklapper added a comment to D25886: Remove use of deprecated E_STRICT PHP constant.

Since using E_STRICT is deprecated, I thought the simple fact of using it from whatever Arcanist CLI

Fri, May 9, 08:00
avivey accepted D25887: Remove use of deprecated E_STRICT PHP constant.

I'd still not expect it to actually break anything - the docs say this const is "deprecated" not "removed", so I'd expect a warning and everything to keep working.
maybe something in the lint pipeline is dumping the warning on stdout instead of stderr.

Fri, May 9, 07:47
avivey accepted D25886: Remove use of deprecated E_STRICT PHP constant.
Fri, May 9, 07:44
aklapper added a comment to D25955: Unhandled Exception: Add last call to error message.

Garrr this still needs shortening the two comment lines

Fri, May 9, 07:26
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Use PhutilErrorHandler::adjustFilePath instead of manually manipulating the filepath string

Fri, May 9, 07:24
valerio.bozzolan updated the task description for T15160: The Feed should not display the old content of an edited Comment as default.
Fri, May 9, 07:19 · Feed, Comments, User-valerio.bozzolan
valerio.bozzolan added a comment to T15160: The Feed should not display the old content of an edited Comment as default.

Uh I've found a workaround.

Fri, May 9, 07:19 · Feed, Comments, User-valerio.bozzolan
aklapper added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

After upgrading to PHP 8.4 this issue blocks me now from doing development work as arc diff fails:

Screenshot From 2025-05-09 09-15-08.png (710×1 px, 136 KB)

And Phorge fails to render at all in both Firefox and Chromium (Phorge renders after applying this very patch):
Screenshot From 2025-05-09 09-00-07.png (973×1 px, 112 KB)

Fri, May 9, 07:18
aklapper closed D26004: README: Update URI of FatCow icon set.
Fri, May 9, 03:46
aklapper committed rP8d688f59d123: README: Update URI of FatCow icon set.
Fri, May 9, 03:46

Thu, May 8

matmarex added a comment to T16050: Make it easier for CSS customization to apply to comments by specific users/bots.

Thanks for the comments. For context (which I should have included initially), this task was borne out of a conversation between me, @aklapper and @valerio.bozzolan about which parts of a downstream hack I was working on (https://phabricator.wikimedia.org/T393289) could be useful upstream. If the answer is "none", I can live with that.

Thu, May 8, 21:42 · Feature Requests, Comments
matmarex added a comment to D25987: Add CSS class to object handle if user object is system agent.

For my use case of styling Maniphest comments and other actions, it would be most convenient to have the extra class on phui-timeline-shell. But I'll be fine with maintaining my styles the way they currently are, if we drop this patch.

Thu, May 8, 21:35
mainframe98 requested changes to D25955: Unhandled Exception: Add last call to error message.

This looks very useful. I think somewhere there is a thing that truncates this kind of pathnames to say <phorge>/path/to. I would like to invest some time to reuse that, so, no need of substr(strlen(substr(realpath

Thu, May 8, 19:53
valerio.bozzolan added a comment to D25955: Unhandled Exception: Add last call to error message.

This looks very useful. I think somewhere there is a thing that truncates this kind of pathnames to say <phorge>/path/to. I would like to invest some time to reuse that, so, no need of substr(strlen(substr(realpath

Thu, May 8, 19:35
valerio.bozzolan accepted D26004: README: Update URI of FatCow icon set.

Nice name btw

Thu, May 8, 19:33
mainframe98 accepted D26004: README: Update URI of FatCow icon set.
Thu, May 8, 17:54
aklapper requested review of D26004: README: Update URI of FatCow icon set.
Thu, May 8, 17:50
aklapper closed D25999: Remove orphan CSS selectors in ponder/ponder-view.css.
Thu, May 8, 16:37
aklapper committed rP07e40af06a7a: Remove orphan CSS selectors in ponder/ponder-view.css.
Thu, May 8, 16:37
aklapper edited the content of Next Up.
Thu, May 8, 16:37
aklapper closed D26002: Remove orphan CSS selectors in config/config-options.css.
Thu, May 8, 16:35
aklapper committed rPa5868f388f16: Remove orphan CSS selectors in config/config-options.css.
Thu, May 8, 16:35
valerio.bozzolan accepted D25999: Remove orphan CSS selectors in ponder/ponder-view.css.
Thu, May 8, 16:20
valerio.bozzolan updated the test plan for D25999: Remove orphan CSS selectors in ponder/ponder-view.css.
Thu, May 8, 16:20
valerio.bozzolan accepted D26002: Remove orphan CSS selectors in config/config-options.css.
Thu, May 8, 16:15
aklapper edited the content of Next Up.
Thu, May 8, 14:53
aklapper closed D26003: Remove orphan CSS selectors in slowvote/slowvote.css.
Thu, May 8, 14:53
aklapper committed rP67880e5c4406: Remove orphan CSS selectors in slowvote/slowvote.css.
Thu, May 8, 14:53
aklapper edited the content of Next Up.
Thu, May 8, 14:47
aklapper closed D26001: Remove orphan CSS selectors in maniphest/task-summary.css.
Thu, May 8, 14:46
aklapper committed rP6c4ccf1dc93b: Remove orphan CSS selectors in maniphest/task-summary.css.
Thu, May 8, 14:46
valerio.bozzolan accepted D26003: Remove orphan CSS selectors in slowvote/slowvote.css.
Thu, May 8, 14:45
valerio.bozzolan accepted D26001: Remove orphan CSS selectors in maniphest/task-summary.css.
Thu, May 8, 14:44
aklapper created T16064: New Column Trigger: Assign only unassigned tasks on move.
Thu, May 8, 14:42 · Feature Requests
aklapper requested review of D26003: Remove orphan CSS selectors in slowvote/slowvote.css.
Thu, May 8, 14:19
aklapper requested review of D26002: Remove orphan CSS selectors in config/config-options.css.
Thu, May 8, 14:17
aklapper requested review of D26001: Remove orphan CSS selectors in maniphest/task-summary.css.
Thu, May 8, 14:15
aklapper updated the summary of D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.
Thu, May 8, 13:50
aklapper requested review of D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.
Thu, May 8, 13:49
aklapper requested review of D25999: Remove orphan CSS selectors in ponder/ponder-view.css.
Thu, May 8, 13:18
aklapper requested review of D25998: Remove orphan CSS selectors in base/main-menu-view.css.
Thu, May 8, 13:06
aklapper edited the content of Next Up.
Thu, May 8, 12:22
aklapper closed D25985: Remove unused feed/feed.css and maniphest/task-edit.css.
Thu, May 8, 12:21
aklapper committed rP5f7250fea617: Remove unused feed/feed.css and maniphest/task-edit.css.
Thu, May 8, 12:21
aklapper retitled D25985: Remove unused feed/feed.css and maniphest/task-edit.css from Remove unused CSS files feed/feed.css and maniphest/task-edit.css
Thu, May 8, 12:21
aklapper updated the diff for D25985: Remove unused feed/feed.css and maniphest/task-edit.css.

git rebase master

Thu, May 8, 11:24
avivey created T16063: Full-screen image - have way to zoom.
Thu, May 8, 06:48

Wed, May 7

aklapper requested review of D25997: Remove orphan CSS selectors for differential-haunt-mode.
Wed, May 7, 23:25
aklapper requested review of D25996: Remove unused CSS file differential/revision-list.css.
Wed, May 7, 23:13
aklapper retitled D25985: Remove unused feed/feed.css and maniphest/task-edit.css from Remove some unused CSS files to Remove unused CSS files feed/feed.css and maniphest/task-edit.css.
Wed, May 7, 23:10
avivey added Q180: "Auth" - it is possible to have a provider (LDAP) configured via conf/custom (Answer 224).
Wed, May 7, 18:49
aklapper requested review of D25995: Remove orphan CSS selectors in PHUIFormView.
Wed, May 7, 17:00
aklapper edited the content of Next Up.
Wed, May 7, 16:24
aklapper closed T16062: PHP 8.1 "strlen(null)" exceptions searching in Conpherence as Resolved by committing rP66bad4e5eebe: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 16:24 · PHP 8 support
aklapper closed T16062: PHP 8.1 "strlen(null)" exceptions searching in Conpherence, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Wed, May 7, 16:24 · PHP 8 support
aklapper closed D25994: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 16:24
aklapper committed rP66bad4e5eebe: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 16:24
valerio.bozzolan accepted D25985: Remove unused feed/feed.css and maniphest/task-edit.css.

Thaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaanks

Wed, May 7, 16:21
valerio.bozzolan updated the test plan for D25985: Remove unused feed/feed.css and maniphest/task-edit.css.
Wed, May 7, 16:21
valerio.bozzolan accepted D25994: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence.

Thaaaaaaaaaaaaanks. It works also on my computer woooo

Wed, May 7, 16:12
jgrammen-agilitypr added a comment to Q181: "Auth" - Multiple LDAP Servers (Answer 223).

I don't have permission to create Manifest Tasks, so I cannot create a Phorge task linking to the phabricator one

Wed, May 7, 14:16
aklapper added a revision to T16062: PHP 8.1 "strlen(null)" exceptions searching in Conpherence: D25994: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 13:29 · PHP 8 support
aklapper requested review of D25994: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 13:29
aklapper created T16062: PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 13:22 · PHP 8 support
aklapper added a comment to D25992: Remove unused anchor-target CSS for Conpherence message pane.

Makes sense. The only mention of anchor-target I can (and could at the time of introducing that CSS) can find is in webroot/rsrc/js/core/behavior-watch-anchor.js but still clueless how to ever trigger that in conpherence - it's related to an anchor link like Z2#26 but that doesn't have the parent classes of the CSS selector.

Wed, May 7, 12:38
aklapper updated the diff for D25991: Column triggers: Allow assigning user who performs the move.

Do not concatenate strings (patchwork messages; lego messages) in getRuleViewDescription() so translations can be correct

Wed, May 7, 11:01
aklapper updated the diff for D25878: Project archival dialog: Mention affected Herald rule conditions.

Use getProductionURI(), not getEnvConfig()

Wed, May 7, 10:51
aklapper added inline comments to D25878: Project archival dialog: Mention affected Herald rule conditions.
Wed, May 7, 10:49
valerio.bozzolan added a comment to D25823: arc browse: add support for Subversion repos.

Closed all inline comments.

Wed, May 7, 09:57 · Arcanist