Uhm this is a damn rabbit hole.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Sat, May 10
Fri, May 9
@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.
Maybe also we can drop something from ./webroot/rsrc/css/core/remarkup.css - since it seems to contain .aphront-panel-preview ( .aphront-panel-preview .phabricator-remarkup-mention-unknown)
another round of bin/celerity map
I guess this welcomes another review / testing. Works fine here.™
Also update comment
Thanks. I pinpoint also here your super-relevant extra details: https://we.phorge.it/D25887#26924
In D25887#26923, @valerio.bozzolan wrote:Just for my curiosity, can you please also follow the tip from the screenshot (before the patch), so, using --trace?
Trying the ManiphestTransactionEditor leads to a dead end. Added personal notes about it...
Just for my curiosity, can you please also follow the tip from the screenshot (before the patch), so, using --strace?
In D25887#26917, @avivey wrote:I'd still not expect it to actually break anything - the docs say this const is "deprecated" not "removed", so I'd expect a warning and everything to keep working.
In D25886#24266, @valerio.bozzolan wrote:Since using E_STRICT is deprecated, I thought the simple fact of using it from whatever Arcanist CLI
I'd still not expect it to actually break anything - the docs say this const is "deprecated" not "removed", so I'd expect a warning and everything to keep working.
maybe something in the lint pipeline is dumping the warning on stdout instead of stderr.
Garrr this still needs shortening the two comment lines
Use PhutilErrorHandler::adjustFilePath instead of manually manipulating the filepath string
Uh I've found a workaround.
After upgrading to PHP 8.4 this issue blocks me now from doing development work as arc diff fails:
And Phorge fails to render at all in both Firefox and Chromium (Phorge renders after applying this very patch):
Thu, May 8
Thanks for the comments. For context (which I should have included initially), this task was borne out of a conversation between me, @aklapper and @valerio.bozzolan about which parts of a downstream hack I was working on (https://phabricator.wikimedia.org/T393289) could be useful upstream. If the answer is "none", I can live with that.
For my use case of styling Maniphest comments and other actions, it would be most convenient to have the extra class on phui-timeline-shell. But I'll be fine with maintaining my styles the way they currently are, if we drop this patch.
In D25955#26898, @valerio.bozzolan wrote:This looks very useful. I think somewhere there is a thing that truncates this kind of pathnames to say <phorge>/path/to. I would like to invest some time to reuse that, so, no need of substr(strlen(substr(realpath
This looks very useful. I think somewhere there is a thing that truncates this kind of pathnames to say <phorge>/path/to. I would like to invest some time to reuse that, so, no need of substr(strlen(substr(realpath
Nice name btw
git rebase master
Wed, May 7
Thaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaanks
Thaaaaaaaaaaaaanks. It works also on my computer woooo
I don't have permission to create Manifest Tasks, so I cannot create a Phorge task linking to the phabricator one
Makes sense. The only mention of anchor-target I can (and could at the time of introducing that CSS) can find is in webroot/rsrc/js/core/behavior-watch-anchor.js but still clueless how to ever trigger that in conpherence - it's related to an anchor link like Z2#26 but that doesn't have the parent classes of the CSS selector.
Do not concatenate strings (patchwork messages; lego messages) in getRuleViewDescription() so translations can be correct
Use getProductionURI(), not getEnvConfig()
Closed all inline comments.