• adopt suggested indentation in ArcanistRepositoryRef.php:91-94
• adopt explicit "TODO" in ArcanistRepositoryRef.php:138-139

A related task (maybe not a sub-task?) is probably that the advanced search of herald ( https://we.phorge.it/herald/ ) does not allow to find these by involved project(s).

Reading (and testing) this again/more, after our first round in person a few days ago, now that I have a local SVN repo, I cannot find anything wrong or non-working, still I'd ideally appreciate another pair of eyes.
Added two more small comments.

In D25987#26708, @aklapper wrote:

Note that in the screenshots I used an extremely broad CSS selector as that broad one was specifically mentioned

Note that in the screenshots I used an extremely broad CSS selector as that broad one was specifically mentioned in the previous comment here.

Sometime un

1. see parent task
2. This wouldn't actually help the described use-case anyway.

(see parent task - I'm against this).

ArcanistRepositoryAPI: apply suggested inline comment:

@matmarex: please look at the screenshots of Andre above: can I ask if such new selector would really simplify your downstream job? or, is there anything else missing / that we should do instead?

I have not a strong opinion about author usernames (T16052) but if you say to decline that makes sense, especially if at least as small compromise we simplify bot recognition, T16051 and D25987, so that local installs can rewrite their UX without completely nuking their past history and doing complicated comment→transaction migrations on past data.

The CSS rule has never been applied. After the change it will be. Please help by adding a line in the test plan about how to reproduce it if you have some time 🙏

Thaaanks

Keep route / path in both places as tasks-assigned/ for consistency

In T15998#21086, @Cigaryno wrote:

Did anyone think of showing two separate queries on Tasks

What is Tasks? Could you share an URI? By default http://phorge.localhost/maniphest/ already offers Assigned, Authored, etc. saved queries in the sidebar.

implement avivey's feedbacks

In D25847#26647, @aklapper wrote:

Resigning as this developed into a larger patch requiring testing; shouldn't be listed as "accepted" as that referred to a revision long ago

Resigning as this developed into a larger patch requiring testing; shouldn't be listed as "accepted" as that referred to a revision long ago

Ready for review :3 based on the other one.

In D25987#26601, @valerio.bozzolan wrote:

Uhm. I don't know why but locally I cannot find the selector.

add a potential performance TODO in legacy code: T16061: PhabricatorEnv isSelfURI(): add small cache of these self-URIs

Avoid $array[$key]=1 and use $array[$key]=$key as suggested

I suggest testing by setting window width = 1791px (e.g. CTRL+shift+M on Firefox), and then passing to window width = 1792px. So we can see that the content max width at the moment always seems ~ 800px.

Uhm - but looking at your screenshot, at looking here T15920, it seems a regression

Patch welcome, with "Ref T15920"

When reading the wiki at a resolution of 3440x1440 (34 inch monitor), there is still a lot of white space.

Uhm. I don't know why but locally I cannot find the selector. Also this should help in getting the selector but without success, both from the home, or from a task created and assigned to a bot.

Nice. Just for fun I've played intensively with https://developer.mozilla.org/en-US/docs/Web/CSS/font-smooth without being able to notice whatsoever difference, so, green light I assume. Thanks

drop newline

add some inline documentation about $array[$v] = 1

Generated with

Feel free to throw the patch as-is, as I usual I love to cleanup and test more loool

I have a patch ready, need to clean up and test more

Generate a super-useful documentation table in Remarkup

It kind of makes sense.
maybe some day we'll need to extract the Identity table to a different place.