My grep loves this
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Fri, May 16
Fri, May 16
e.g. https://regex101.com/r/PDyAGh/1 (then the slash, or the slash and the version - but that is)
There is something wrong now nearby the |((Chrome, that should be enclosed by pipes and just one bracket, like an hamburger of pipes, like @stuff|(Chromestuff)|(Firefox stuff)@0
wrap long string to make lint happy
but in Firefox seems easier, we can just match "Mobile.*Firefox" probably
valerio.bozzolan added a comment to T15828: "Any" & "Not In" query operators should also involve project's direct milestones.
@A_smart_kitten you are super-super-welcome if you create another parent task like this https://web.archive.org/web/20250218071010/https://secure.phabricator.com/T12486 so " Search exclude-by-tag doesn't work consistently with subprojects" - since I completely agree on your point but I'm unsure how to manage it, so here T15828 we become just one of your sub-tasks.
valerio.bozzolan triaged T16071: Avoid large layout shifts while page loading on mobile as Normal priority.
Per https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/User-Agent/Firefox (and other pages like https://www.whatismybrowser.com/guides/the-latest-user-agent/firefox ), the current regex check in Phorge requiring the string Chrome won't even try to match Firefox browsers on mobile (e.g. Mozilla/5.0 (Android 15; Mobile; rv:138.0) Gecko/138.0 Firefox/138.0).
A_smart_kitten added a comment to T15828: "Any" & "Not In" query operators should also involve project's direct milestones.
- 🔶 this task (T15828) is not reporting a real-world thing about this use with sub-projects
FWIW, my use case from today in terms of sub-projects was attempting to search tasks on Wikimedia Phabricator that were tagged with either #MediaWiki-Recent-changes or #Edit-Review-Improvements (or a subproject thereof).
valerio.bozzolan updated the task description for T15828: "Any" & "Not In" query operators should also involve project's direct milestones.
valerio.bozzolan renamed T15828: "Any" & "Not In" query operators should also involve project's direct milestones from "Any" & "Not In" query operators are not respected when searching for subprojects/milestones of a given project to "Any" & "Not In" query operators should also involve project's direct milestones.
valerio.bozzolan added a comment to T15828: "Any" & "Not In" query operators should also involve project's direct milestones.
Triaging a bit more than "Wishlist" and a bit less than "Normal" since a prototype is actionable but we still lived years without this... so, "Low".
valerio.bozzolan added a comment to T15828: "Any" & "Not In" query operators should also involve project's direct milestones.
OK hackers, thanks for stimulating a follow-up. I've studied this a bit and I have a more clear opinion. Let's write some notes down.
Reverting rARC29575b4f91876bf0a95739eba50f792e2aa78c0c and rP6619fef2ff977ea81092b970e58abbb33e78f644 makes Phorge throw errors again:
Firefox says This page is in Quirks Mode. Page layout may be impacted.,
Chromium says net::ERR_CONTENT_DECODING_FAILED 200 (OK)),
both because the deprecation warning is added before the usual HTML header created by AphrontPageView, as curl shows:
[acko@foo phorge (master *$|u=)]$ curl 'http://phorge.localhost' <br /> <b>Deprecated</b>: Constant E_STRICT is deprecated in <b>/var/www/html/phorge/phorge/support/startup/PhabricatorStartup.php</b> on line <b>391</b><br /> <!DOCTYPE html><html data-developer-mode="1"><head><meta charset="UTF-8" /><title>Home</title><meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=yes" /><link rel="mask-icon" color="#3D4B67" [...]
We don't end up calling PhutilErrorHandler::handleError() or PhutilErrorLog::onError() or PhutilSystem::writeStderr() here.
dhinus updated the task description for T15828: "Any" & "Not In" query operators should also involve project's direct milestones.
A_smart_kitten renamed T15828: "Any" & "Not In" query operators should also involve project's direct milestones from "Not In" query operator is not respected when searching for project milestones to "Any" & "Not In" query operators are not respected when searching for subprojects/milestones of a given project.
A_smart_kitten added projects to T15828: "Any" & "Not In" query operators should also involve project's direct milestones: Bug Reports, Maniphest.
Gonna boldly call it a bug, given that I was about to file an upstream bug report for https://phabricator.wikimedia.org/T386830 before I came across this task :)
P.S. Uh, I noticed that arc work also has a --start parameter! I documented a bit the expected behavior in the task T15993.
Tested for T15100 and T15993 and I'm a bit surprised to obtain, this very long branch with commas and square brackets (and just the closing bracket? uhm)
valerio.bozzolan updated the task description for T15993: Support for arc work T12345 (workOnTask workflow).
aklapper updated the task description for T16071: Avoid large layout shifts while page loading on mobile.
- arc lint
- arc unit
- fix a couple of id($api) and just use $api
Do you know for sure (did Fabio explicitly say so)
seems manually uploaded by an user, but it's not
Thu, May 15
Thu, May 15
This is different than T15814: Files: reduce number of orphan transformed files
Wed, May 14
Wed, May 14
git rebase master
git rebase master
valerio.bozzolan closed T15541: "arc browse <file>" should support Subversion as Resolved by committing rARCc58c780b47ef: arc browse: add support for Subversion repos.
OK, tested by 3 hackers, no git regressions, more SVN stability, more inline documentation, more abstraction, very Phorgi, already tracking follow-ups, yuuup
valerio.bozzolan added a comment to T15957: 'arc browse .' from the root of the project should work (at least in git and SVN).
In T15957#22436, @keithzg wrote:Testing this a bit myself again, I discovered that actually this problem affects both Git and SVN
valerio.bozzolan renamed T15957: 'arc browse .' from the root of the project should work (at least in git and SVN) from 'arc browse .' should work in git to 'arc browse .' from the root of the project should work (at least in git and SVN).
keithzg added a comment to T15957: 'arc browse .' from the root of the project should work (at least in git and SVN).
Testing this a bit myself again, I discovered that actually this problem affects both Git and SVN, it just wasn't being noticed in my SVN testing because it doesn't go wrong if run from any subfolder. So for example in a checkout of rARC, running arc browse . in the root directory will pop one into the bogus path of, say, https://we.phorge.it/source/arcanist/browse/master/home/keithzg/Code/git/arcanist, but if I'm in my local ~/Code/git/arcanist/src/ then arc browse . pops open https://we.phorge.it/source/arcanist/browse/master/src as intended.
The only remaining issue I could find in retesting was that, when run on the root of a repo, apparently SVN exhibits the same behaviour as Git does in T15957; and furthermore in my testing actually Git also doesn't have that problem if arc browse . is run in a subfolder rather than the root of a repo. (It's just so much more common to be in the root of a Git repo, and so much less common to be in the true root of an SVN repo, that we didn't notice!)
Chlod added a comment to T16054: Conduit API transaction.search with objectType = XACT causes internal error "get_class() expects parameter 1 to be object, null given".
Thanks, @valerio.bozzolan! :D
Tue, May 13
Tue, May 13
valerio.bozzolan added a comment to T16054: Conduit API transaction.search with objectType = XACT causes internal error "get_class() expects parameter 1 to be object, null given".
valerio.bozzolan renamed T16054: Conduit API transaction.search with objectType = XACT causes internal error "get_class() expects parameter 1 to be object, null given" from transaction.search with XACT causes internal error to Conduit API transaction.search with objectType = XACT causes internal error "get_class() expects parameter 1 to be object, null given".
That was my patch initially but it felt like too much duplicated code... I don't have a strong opinion though; I'm also fine with that other approach. :)
valerio.bozzolan added a comment to D26020: Add workboard column trigger to assign only unassigned tasks.
I wonder if we should just extend PhabricatorProjectTriggerRule. So, leaving PhabricatorProjectTriggerManiphestOwnerRule as-is 🤔 any opinion about that?
What's the expectation for classes which have a child class extending them? Marking them as abstract though they are really not abstract at all? protected class? Uhm.
valerio.bozzolan added a comment to D25988: transaction.search: add auto-generated documentation for objectType and handle unmanaged exception.
Better now, thanks again @avivey
Mon, May 12
Mon, May 12
aklapper requested review of D26019: Add two trivial PHPDocs lines to PhabricatorTypeaheadDatasource.
Sun, May 11
Sun, May 11
Sat, May 10
Sat, May 10
Tested right now. Unexpected pleasure! thanks! :3 :3
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0