Page MenuHomePhorge
Feed All Stories

Feb 4 2025

valerio.bozzolan added a comment to D25863: Convert tokens given to use SearchEngine.

OK probably just this is missing

Feb 4 2025, 13:58
valerio.bozzolan added a comment to D25863: Convert tokens given to use SearchEngine.

It works on my computer but I see that in the left sidebar usually there is "Queries" 馃 instead it seems to work for ManiphestController and similar ones

Feb 4 2025, 13:54
valerio.bozzolan updated the test plan for D25863: Convert tokens given to use SearchEngine.
Feb 4 2025, 13:51
Cigaryno added a project to T15990: ERROR 8192: exit(): Passing null to parameter #1 ($status) of type string|int is deprecated at [arcanist/src/parser/argument/PhutilArgumentParser.php:494] on PHP 8.4: Arcanist.
Feb 4 2025, 13:51PHP 8 support, Arcanist, Bug Reports
Cigaryno removed 3 auditor(s) for rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID(): Remarkup, DeepClone (Extension), Extension Development.
Feb 4 2025, 13:50
valerio.bozzolan added inline comments to D25776: Portals: Rename unused newNoMenuItemsView() to newNoContentView().
Feb 4 2025, 13:27Dashboards
taavi created T15990: ERROR 8192: exit(): Passing null to parameter #1 ($status) of type string|int is deprecated at [arcanist/src/parser/argument/PhutilArgumentParser.php:494] on PHP 8.4.
Feb 4 2025, 13:14PHP 8 support, Arcanist, Bug Reports
taavi requested review of D25863: Convert tokens given to use SearchEngine.
Feb 4 2025, 13:11
taavi added a revision to T15988: Allow filtering tokens given by list of token: D25863: Convert tokens given to use SearchEngine.
Feb 4 2025, 13:11Feature Requests
valerio.bozzolan triaged T15989: `arc unit`: Constant E_STRICT is deprecated (with PHP 8.4) as Normal priority.

Welcome PHP 8.4

Feb 4 2025, 12:39Deprecation Notice, PHP 8 support, Bug Reports
taavi created T15989: `arc unit`: Constant E_STRICT is deprecated (with PHP 8.4).
Feb 4 2025, 12:32Deprecation Notice, PHP 8 support, Bug Reports
valerio.bozzolan awarded T15988: Allow filtering tokens given by list of token a Like token.
Feb 4 2025, 12:00Feature Requests
valerio.bozzolan added a comment to T15988: Allow filtering tokens given by list of token.

(Additional context: as follow-up request, the most adopted token MUST always be "fox" or "馃", forever - even if not available. So maybe the implementation is a bit simpler and efficient 馃憤 lol)

Feb 4 2025, 11:55Feature Requests
taavi created T15988: Allow filtering tokens given by list of token.
Feb 4 2025, 11:51Feature Requests

Feb 3 2025

aklapper edited the content of Next Up.
Feb 3 2025, 20:55
aklapper edited the content of Next Up.
Feb 3 2025, 20:48
aklapper closed T15890: Workboard: better clarify if it's Archived, a subtask of T15886: Archived Projects: make them "more Archived" , as Resolved.
Feb 3 2025, 17:57Projects
aklapper closed D25774: Strike through archived projects in navigation crumbs.
Feb 3 2025, 17:57Projects
aklapper closed T15890: Workboard: better clarify if it's Archived as Resolved by committing rP0bd838868422: Strike through archived projects in navigation crumbs.
Feb 3 2025, 17:57UX, Projects
aklapper committed rP0bd838868422: Strike through archived projects in navigation crumbs.
Strike through archived projects in navigation crumbs
Feb 3 2025, 17:57
aklapper updated the diff for D25774: Strike through archived projects in navigation crumbs.
  • rebase again
Feb 3 2025, 17:55Projects
valerio.bozzolan accepted D25774: Strike through archived projects in navigation crumbs.

Double slam-sgtm

Feb 3 2025, 17:25Projects
aklapper updated the diff for D25774: Strike through archived projects in navigation crumbs.

./bin/celerity/map

Feb 3 2025, 11:13Projects
aklapper closed D25862: Communicate max dimensions of profile images before upload.
Feb 3 2025, 10:53
aklapper closed T15984: Communicate maximum dimensions of avatar images as Resolved by committing rP6facee6140ea: Communicate max dimensions of profile images before upload.
Feb 3 2025, 10:53Projects
aklapper committed rP6facee6140ea: Communicate max dimensions of profile images before upload.
Communicate max dimensions of profile images before upload
Feb 3 2025, 10:53
aklapper retitled D25776: Portals: Rename unused newNoMenuItemsView() to newNoContentView() from Fix newEmptyView() parameters in PhabricatorDashboardPortalProfileMenuEngine to Remove unused newNoMenuItemsView() function.
Feb 3 2025, 10:50Dashboards
aklapper updated the diff for D25776: Portals: Rename unused newNoMenuItemsView() to newNoContentView().

Remove newNoMenuItemsView() instead

Feb 3 2025, 10:49Dashboards
aklapper retitled D25776: Portals: Rename unused newNoMenuItemsView() to newNoContentView() from Fix newEmptyView() parameters in PhabricatorDashboardPortalProfileMenuEngine to Remove unused newNoMenuItemsView() function.
Feb 3 2025, 10:49Dashboards
aklapper added inline comments to D25776: Portals: Rename unused newNoMenuItemsView() to newNoContentView().
Feb 3 2025, 10:46Dashboards
aklapper closed T15895: PhabricatorCustomField::readValueFromObject() should not return $this as Resolved by committing rPaaff2415f981: Fix incorrect return value of PhabricatorCustomField::readValueFromObject().
Feb 3 2025, 09:40
aklapper closed D25751: Fix incorrect return value of PhabricatorCustomField::readValueFromObject().
Feb 3 2025, 09:40
aklapper committed rPaaff2415f981: Fix incorrect return value of PhabricatorCustomField::readValueFromObject().
Fix incorrect return value of PhabricatorCustomField::readValueFromObject()
Feb 3 2025, 09:40
reet- updated the question details for Q167: Personal Herald rule for repository activity.
Feb 3 2025, 09:20Herald
reet- asked Q167: Personal Herald rule for repository activity.
Feb 3 2025, 09:17Herald
avivey added a comment to T15987: Preview for patch files.

https://secure.phabricator.com/T13105 is the relevant historical meta-task, I didn't find a matching one here.

Feb 3 2025, 08:14Files
Tgr created T15987: Preview for patch files.
Feb 3 2025, 08:00Files
valerio.bozzolan updated the test plan for D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.
Feb 3 2025, 08:00Remarkup
valerio.bozzolan requested changes to D25776: Portals: Rename unused newNoMenuItemsView() to newNoContentView().
Feb 3 2025, 08:00Dashboards
valerio.bozzolan updated the diff for D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

add little cute comment and newline, to make it clear that the comment belongs only to that line, and really nothing else lol

Feb 3 2025, 08:00Remarkup
valerio.bozzolan accepted D25751: Fix incorrect return value of PhabricatorCustomField::readValueFromObject().

Makes sense looking at

Feb 3 2025, 08:00
mainframe98 requested changes to D25772: Projects: improve quality of destroy workflow.

I find the current iteration too difficult to read, although that may be partially caused by the mutual language barrier.

Feb 3 2025, 08:00Projects
valerio.bozzolan accepted D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

It works on my computer. Thaaaanks \o/

Feb 3 2025, 08:00Remarkup

Feb 2 2025

waldyrious awarded T15701: Clarify that a Project is just a "Tag" a Like token.
Feb 2 2025, 20:43UX, Projects
waldyrious awarded T15504: If registration is disabled, show the button as disabled a Like token.
Feb 2 2025, 20:25Auth, Good Starter Task, UX
Arkus404 edited 4 auditor(s) for rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID(), removed 1: Arkus404; added 3: Extension Development, DeepClone (Extension), Remarkup.
Feb 2 2025, 00:04

Feb 1 2025

Arkus404 awarded rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID() a Cup of Joe token.
Feb 1 2025, 23:51
Arkus404 added 1 auditor(s) for rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID(): Arkus404.
Feb 1 2025, 23:50

Jan 31 2025

tusooa asked Q166: Support for request header and body in "Make HTTP Request" step in Harbormaster.
Jan 31 2025, 02:48Almanac/Drydock/Harbormaster
amybones added a comment to T15982: Update the documentation for "Adding New CSS and JS" to not exclude extensions.

A comment in two parts:
First and most relevant to this task: It certainly would be nice to get some of this into documentation! It took me quite awhile to figure this out when doing my own extension development.

Jan 31 2025, 01:42Extension Development, Documentation

Jan 26 2025

mainframe98 accepted D25535: T15011: Update support for XHPast on Windows.

Took some fiddling with VS2022 to find exactly what I needed to install, but worked like a charm afterwards.

Jan 26 2025, 13:29

Jan 25 2025

Cigaryno updated the task description for T15128: Differential: Allow to change "Default Edit Policy".
Jan 25 2025, 19:23Spam mitigation, Policy, Differential, User-Cigaryno
Cigaryno updated the task description for T15128: Differential: Allow to change "Default Edit Policy".
Jan 25 2025, 18:51Spam mitigation, Policy, Differential, User-Cigaryno
Cigaryno updated Cigaryno.
Jan 25 2025, 18:44
Cigaryno updated Cigaryno.
Jan 25 2025, 18:44
IamMin updated IamMin.
Jan 25 2025, 04:53

Jan 24 2025

Cigaryno moved T15450: Configure another Ponder Question status "Closed, Graduated" from Feature Requests to Bug Reports on the Ponder board.
Jan 24 2025, 16:29Feature Requests, Ponder, phorge.it install
Cigaryno added a project to T15171: Ponder: add "Hide" button on your answer: Feature Requests.
Jan 24 2025, 16:18Feature Requests, Ponder, User-valerio.bozzolan
Cigaryno moved T15985: Fix UX regression in Phame from Backlog to UX & Mobile on the Bug Reports board.
Jan 24 2025, 16:13Phame, Bug Reports, UX
Cigaryno added a project to T15812: Double escaped text when adding an auth provider: Auth.
Jan 24 2025, 16:12Auth, Bug Reports
Cigaryno moved T15985: Fix UX regression in Phame from Backlog to Bug Reports on the Phame board.
Jan 24 2025, 08:11Phame, Bug Reports, UX
Cigaryno added a project to T15985: Fix UX regression in Phame: Phame.
Jan 24 2025, 08:10Phame, Bug Reports, UX
xmain123 added a comment to T15043: Automatically move tasks between columns on project boards.

the vsts has a good workboard experience for this feature, it supply the mapping setting for the board relationship.

Jan 24 2025, 06:08Herald, Feature Requests, Workboard

Jan 23 2025

aklapper added a comment to T15985: Fix UX regression in Phame.

Uhm, right. A quick fix would be removing the margin-left: 300px; CSS rule for div.phui-document-content-outer.

Jan 23 2025, 11:48Phame, Bug Reports, UX
aklapper updated the task description for T15986: Consider disabling unread notification count in page title.
Jan 23 2025, 07:59
aklapper created T15986: Consider disabling unread notification count in page title.
Jan 23 2025, 07:57

Jan 22 2025

valerio.bozzolan edited the content of Next Up.
Jan 22 2025, 11:41
valerio.bozzolan added a comment to T15985: Fix UX regression in Phame.

Decreasing priority since this happens only if you have not any posts.

Jan 22 2025, 11:38Phame, Bug Reports, UX
valerio.bozzolan lowered the priority of T15985: Fix UX regression in Phame from High to Normal.
Jan 22 2025, 11:38Phame, Bug Reports, UX
valerio.bozzolan edited the content of Next Up.
Jan 22 2025, 11:30
valerio.bozzolan placed T15985: Fix UX regression in Phame up for grabs.

(Sorry @mturdus I didn't want to assign this to you. It was automatically assigned by sub-task.)

Jan 22 2025, 11:28Phame, Bug Reports, UX
valerio.bozzolan created T15985: Fix UX regression in Phame.
Jan 22 2025, 11:27Phame, Bug Reports, UX
valerio.bozzolan accepted D25862: Communicate max dimensions of profile images before upload.

It works on my computer \o/ thanks

Jan 22 2025, 07:42
valerio.bozzolan updated the diff for D25862: Communicate max dimensions of profile images before upload.

fix PhabricatorPeopleProfilePictureController and PhabricatorProjectEditPictureController,
thanks to generic "transform" stuff from PhabricatorFileTransform

Jan 22 2025, 07:33
valerio.bozzolan added a comment to D25862: Communicate max dimensions of profile images before upload.

Hoping to be useful I will amend to fix 2 new errors caused by my suggestion.

Jan 22 2025, 07:31
valerio.bozzolan added a comment to D25862: Communicate max dimensions of profile images before upload.

Ouch the non-static method raised an error. I'm investigating a possible fix to keep this non-static approach in the next 20 minutes

Jan 22 2025, 07:19

Jan 21 2025

aklapper updated the diff for D25862: Communicate max dimensions of profile images before upload.

Do not use consts but keep the two pixel values defined in getMaxTransformDimensions(), make function non-static

Jan 21 2025, 19:01
avivey added inline comments to D25862: Communicate max dimensions of profile images before upload.
Jan 21 2025, 08:33
avivey added a comment to T15984: Communicate maximum dimensions of avatar images.

Oh, I miss-understood the problem statement. The 4096 limit is on the size of the image that we can resize from...

Jan 21 2025, 08:26Projects

Jan 20 2025

valerio.bozzolan added a comment to T15984: Communicate maximum dimensions of avatar images.

Maybe since "we live in interesting times" we can increase such limit indeed also, but that logic makes some sense (but terrible user experience, I agree lol)

Jan 20 2025, 13:48Projects
valerio.bozzolan added a comment to T15984: Communicate maximum dimensions of avatar images.

I also thought that, but I think the current limitation (4096 x 4096) is reasonable and was introduced to avoid to scale huge things and mitigate resource exhaustion in thumb generation.

Jan 20 2025, 13:47Projects
avivey added a comment to T15984: Communicate maximum dimensions of avatar images.

I'd expect it to just resize the image as needed....

Jan 20 2025, 13:33Projects
valerio.bozzolan added a comment to D25862: Communicate max dimensions of profile images before upload.

Still untested but seems nice thanks <3

Jan 20 2025, 08:38
tanasi added a comment to Q165: Maniphest tasks in calendar view (Answer 207).

Yes, I got the idea. It's a feasible workaround.

Jan 20 2025, 08:04
valerio.bozzolan added a comment to Q165: Maniphest tasks in calendar view (Answer 207).

Yep, maybe the "Dummy project" can be a "personal project", that is, just a workboard with your name, like this:

Jan 20 2025, 07:49

Jan 19 2025

tanasi added Q165: Maniphest tasks in calendar view (Answer 207).
Jan 19 2025, 19:26
valerio.bozzolan added Q165: Maniphest tasks in calendar view (Answer 206).
Jan 19 2025, 19:11

Jan 18 2025

tanasi asked Q165: Maniphest tasks in calendar view.
Jan 18 2025, 21:38
Cigaryno added a comment to D25862: Communicate max dimensions of profile images before upload.

@Cigaryno: What is your motivation behind and which actual problem are you trying to solve by this? For example, there are now 4 out of ~25000 patches tagged with Projects if I was about to search for patches tagged with Projects. I can imagine tags to be partially useful on Maniphest tasks and I fail to see the advantage for Differential patches so far.

Jan 18 2025, 18:17
aklapper added a comment to D25862: Communicate max dimensions of profile images before upload.

@Cigaryno: What is your motivation behind and which actual problem are you trying to solve by this? For example, there are now 4 out of ~25000 patches tagged with Projects if I was about to search for patches tagged with Projects. I can imagine tags to be partially useful on Maniphest tasks and I fail to see the advantage for Differential patches so far.

Jan 18 2025, 18:15
Cigaryno changed the visibility for V3: Disable self-action emails on every install by default?.
Jan 18 2025, 18:10
Cigaryno added a comment to D25862: Communicate max dimensions of profile images before upload.

@akplapper just to ask, is adding tags to revs pointless or this isn't the right revision for adding tags to?

Jan 18 2025, 18:09
aklapper removed projects from D25862: Communicate max dimensions of profile images before upload: Projects, People.

@Cigaryno: Could you please not add project tags to patches? You seem to be the only person doing this lately, and it creates notifications that others need to read. Thanks.

Jan 18 2025, 18:08
Cigaryno added a project to T15057: Kubernetes support in Almanac/Drydock/Harbormaster: Feature Requests.
Jan 18 2025, 12:36Feature Requests, Almanac/Drydock/Harbormaster
Cigaryno added projects to D25862: Communicate max dimensions of profile images before upload: People, Projects.
Jan 18 2025, 11:54
Cigaryno added a project to T15984: Communicate maximum dimensions of avatar images: Projects.
Jan 18 2025, 11:52Projects
aklapper added a comment to D25862: Communicate max dimensions of profile images before upload.
  • mb_chr(215) because arc lint dislikes funky
  • const MAX_TRANSFORM_* because arc lint does not like private const, so maybe PhabricatorFileImageTransform::getMaxTransformDimensions() is overengineering as I could also access the two consts directly instead
  • Cannot private const int because that requires PHP 8.3 (type safety haha)
Jan 18 2025, 11:49
aklapper requested review of D25862: Communicate max dimensions of profile images before upload.
Jan 18 2025, 11:48
aklapper added a revision to T15984: Communicate maximum dimensions of avatar images: D25862: Communicate max dimensions of profile images before upload.
Jan 18 2025, 11:48Projects
aklapper updated the task description for T15984: Communicate maximum dimensions of avatar images.
Jan 18 2025, 11:25Projects