Feel free to land \o/

What about this small change? So, the checkbox has not a related "left" label, and has a more descriptive "right" label.

Tested before/after, thanks :)

It's a Git repository branch called 201709 (see downstream) but still no idea how to trigger the exception.
If anyone has an idea what to do to reach code in DiffusionRequest::generateURI() or DiffusionCommitBranchesController, please share.

I've taken the habit of updating to "latest RC" whenever I make an RC cut (every 3-4 months?), and then leaving it there until I feel like updating to master.
"I feel like updating to master" ususally means "there's something interesting there", and unless it's only interesting to this install, I tend to also cut the RC while I'm at it (or wait for when I do that).

Just for reference, see related T15449 and Q56.

Or, additional approach could be to have a small periodic script to watch for change on diffusion.branchquery Conduit call and than to trigger a build plan through Conduit.

looks good

great - see D25446

@avivey Yes this seems to work! Thank you

@fgaz can you try this and see if it it works for you?

I'm looking at PhutilLibraryMapBuilder:analyzeLibrary(), and it kinda looks like:

• if $this->fileSymbolMap is null, we call analyzeLibrary()`
• We load the data from the file if it's there
• We update the data
• We store it in $this->fileSymbolMap
• and we always save it to disk

There's no return in analyzeLibrary`, so if we got there, we'll save to disk. And there's no other write to fileSymbolMap, so we'll always get there.

The command does create the file, but arc lint tries to modify it anyway:

Could libexec/arcanist/src/.phutil_module_cache just be a symlink to somewhere else?

Nix

Just for my curiosity, what lovely package are you crafting? APT? snap? Thanks :)

I accept but please wait at least one day before landing :) Thanks for your code contribution!

I'm inclined to accept this, premising that usually we adopt PlatformSymbols::getPlatformServerPath() but in this case that will not work since this error is very low-level about the load of Arcanist itself.

Thanks but I don't know where that typo is, so, feel free to fix

See e.g. https://www.law.cornell.edu/wex/release why to "license under" instead of "release in"

Triaging to "Unbreak Now!" so to be kindly shown in the homepage :)

I don't remember but that was an attempt to do not release Passphrase credentials as CC BY-SA 4.0 :D :D

Public contents are released in Creative Commons Attribution-ShareAlike 4.0.

Updated to reflect some tips from comments. Also added some "Pro / Cons"

+1 for CC BY-SA 4.0 International for content (text, images, etc) and Apache 2.0 for code.

git rebase master

There is a thing, to be honest. We are trimming the $above just in the test, but then we are not using the trimmed string in the rendering. So, the $v = coalesce($v, '') thing, and always trim() later, may still be better.

Maybe other people would like to propose a coalesce() and always trim() that and just have the if(phutil_nonempty...($)), but to be honest this is just correct and somehow minimal.

I tried browsing that page without being able to trigger the issue

Abandoning per last comment; guess we should debug a bit more first in downstream to understand the root cause better

This issue has been a pain for years. Never investigated it before...

Fix unit test

Lint & fix xml unit test

Not sure how to proceed here, this abandoning for now