Page MenuHomePhorge

Update ArcanistComposerLinter.php to check content-hash instead of hash
ClosedPublic

Authored by Sten on Sep 27 2023, 09:11.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 19:16
Unknown Object (File)
Wed, May 1, 19:16
Unknown Object (File)
Wed, May 1, 19:16
Unknown Object (File)
Wed, May 1, 19:15
Unknown Object (File)
Wed, May 1, 19:15
Unknown Object (File)
Wed, May 1, 08:54
Unknown Object (File)
Sat, Apr 27, 14:16
Unknown Object (File)
Wed, Apr 10, 16:34

Details

Summary

The 'hash' key in composer.json files was removed by composer version 1.3.0 in December 2016, in favour of the 'content-hash' key.

Update the code to validate the content-hash instead.

Fixes T15647

Test Plan
  • Update a composer.json file, without running 'composer update'
  • Run 'arc lint' and confirm it warns you that the composer.lock file is out of date
  • Run 'composer update'
  • Run 'arc lint' and confirm it returns OKAY

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Sten requested review of this revision.Sep 27 2023, 09:11
Sten planned changes to this revision.Sep 27 2023, 09:12

Lint & fix xml unit test

This revision is now accepted and ready to land.Sep 27 2023, 20:21