In D25234#7306, @valerio.bozzolan wrote:

Just to clarify: I think we both agree on these four things:

1. showing a "No interpreter error" to the frontend could be weird, at minimum this is true for MediaWiki users (not just Wikimedia users) and showing the original raw text could be more useful (green light)

Just to clarify: I think we both agree on these four things:

That sounds very sketchy - getMatchingLineCount should either refer to raw text, or to post-processed text - and the 2nd option isn't possible (There might not be any text in the result, like in macro).

In D25234#7303, @avivey wrote:

Where was it "returning an error message with potentially a different number of line" ?

Where was it "returning an error message with potentially a different number of line" ?

Ah yeah indeed now I understand the issue:

In D25234#7296, @avivey wrote:

I don't see how this stops the exception discussed in T15372 - nothing in this change looks like it might stop an "Undefined array key" exception?

I don't see how this stops the exception discussed in T15372 - nothing in this change looks like it might stop an "Undefined array key" exception?

Can you please set this image as Public? thanks :)

I absolutely don't know what is happening here, but now it works again after a rebase.

rebase and add minor comment

Uhm. We are breaking something here. I'm testing with:

Hi @roguelazer are you still interested in this feature? In 3 days, hoping to be useful, I will try to do something similar, following the tips from kind user speck

@Matthew feel free to "sgtm" <3

I prefer if ($thing !== null && strlen($thing)), but whatever.

Note that I like to do NOT mention the stuff phutil_nonempty_stringlike() since it causes extra headaches with incoming objects to many friends. Same for its friend phutil_nonempty_scalar() since it's broken with known scalars (T15239).

avoid unuseful tables

mention the cast thing

mention the cast thing

Thanks again for this patch!

Again @amit I know you have other things to do :) Can you just try to manually apply this patch?

avoid phutil_nonempty_string() since upstream is not using that

Thaanks! Tested locally. No implosions obviously ihih

lint

In D25237#7223, @jkimbo wrote:

Awesome, revision landed. Thanks for the help @valerio.bozzolan

OK just to have a stub somewhere to start with, please feel free to edit this page:

Awesome, revision landed. Thanks for the help @valerio.bozzolan

Thaanks again

Indeed the Slug and the Callsign should be null or strings and nothing else.

This is that kind of scary thing that deserves our phutil_string_cast() trick, since the incoming value from PhabricatorStandardCustomField is probably too much wild, probably an integer, probably a boolean, probably an object.

In D25237#7155, @valerio.bozzolan wrote:

To land this patch, you can download Arcanist and:

arc patch D25237
arc land

If you can't for some reasons, don't worry: I will land this in 8 days, hoping to be useful

Thanks again :)