Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions which block rendering Browse Repositories overlay dialog
ClosedPublic

Authored by aklapper on May 24 2023, 15:42.
Tags
None
Referenced Files
F2231483: D25244.1718756343.diff
Tue, Jun 18, 00:19
Unknown Object (File)
Sat, Jun 15, 14:18
Unknown Object (File)
Sat, Jun 15, 14:18
Unknown Object (File)
Sat, Jun 15, 13:35
Unknown Object (File)
Sat, Jun 15, 12:59
Unknown Object (File)
Fri, Jun 14, 08:53
Unknown Object (File)
Wed, Jun 12, 14:16
Unknown Object (File)
Wed, Jun 12, 05:09

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15420

Test Plan

Applied these two changes; afterwards "Browse Repositories" overlay dialog gets rendered in web browser and lists existing repositories.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks (again)

Indeed the Slug and the Callsign should be null or strings and nothing else.

The function phutil_nonempty_string() will report any alien type, and that is OK here.

I tested this with some fuzzy tests in Diffusion Callsign, without any nuclear implosion.

lgtm

src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php
57

↑ This assumes all the parts as strings.

This revision is now accepted and ready to land.May 24 2023, 15:50