Page MenuHomePhorge

PHP Pitfalls: mention strlen() deprecation since PHP 8.1
ClosedPublic

Authored by valerio.bozzolan on Apr 2 2023, 19:26.
Referenced Files
Unknown Object (File)
Sun, Jun 16, 00:00
Unknown Object (File)
Sat, Jun 8, 20:06
Unknown Object (File)
Fri, Jun 7, 03:29
Unknown Object (File)
Thu, Jun 6, 22:56
Unknown Object (File)
Thu, Jun 6, 05:40
Unknown Object (File)
Thu, Jun 6, 03:06
Unknown Object (File)
Thu, Jun 6, 02:13
Unknown Object (File)
Wed, Jun 5, 00:09

Details

Summary
  • expand documentation about PHP Pitfalls to mention strlen() in PHP 8.1
  • mention phutil_string_cast()
  • mention phutil_nonempty_string()
  • add a commodity link from PHP Contributors Manual

Ref T15190

Test Plan
  • check with your big eyes for typos

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

valerio.bozzolan retitled this revision from Documentation: mention strlen() deprecation since PHP 8.1 - improve a bit PHP Pitfalls to mention strlen() deprecation - mention is_string() benefits - mention phutil_nonempty_string() - link PHP Pitfalls from PHP Contributors Manual to Documentation: mention strlen() deprecation since PHP 8.1.Apr 2 2023, 19:26
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan added inline comments.
src/docs/flavor/php_pitfalls.diviner
63

I moved this text under the section "Check for non-empty strings"

93

I just indented a bit

valerio.bozzolan retitled this revision from Documentation: mention strlen() deprecation since PHP 8.1 to PHP Pitfalls: mention strlen() deprecation since PHP 8.1.Apr 6 2023, 18:34
valerio.bozzolan edited the summary of this revision. (Show Details)
src/docs/flavor/php_pitfalls.diviner
152

↑ That part was just copy-pasted mostly from the already-existing block

↓ This part is new

Note that I like to do NOT mention the stuff phutil_nonempty_stringlike() since it causes extra headaches with incoming objects to many friends. Same for its friend phutil_nonempty_scalar() since it's broken with known scalars (T15239).

This revision is now accepted and ready to land.May 25 2023, 10:58