I'd still not expect it to actually break anything - the docs say this const is "deprecated" not "removed", so I'd expect a warning and everything to keep working.
maybe something in the lint pipeline is dumping the warning on stdout instead of stderr.

Garrr this still needs shortening the two comment lines

Use PhutilErrorHandler::adjustFilePath instead of manually manipulating the filepath string

Uh I've found a workaround.

After upgrading to PHP 8.4 this issue blocks me now from doing development work as arc diff fails:

Thanks for the comments. For context (which I should have included initially), this task was borne out of a conversation between me, @aklapper and @valerio.bozzolan about which parts of a downstream hack I was working on (https://phabricator.wikimedia.org/T393289) could be useful upstream. If the answer is "none", I can live with that.

For my use case of styling Maniphest comments and other actions, it would be most convenient to have the extra class on phui-timeline-shell. But I'll be fine with maintaining my styles the way they currently are, if we drop this patch.

In D25955#26898, @valerio.bozzolan wrote:

This looks very useful. I think somewhere there is a thing that truncates this kind of pathnames to say <phorge>/path/to. I would like to invest some time to reuse that, so, no need of substr(strlen(substr(realpath

This looks very useful. I think somewhere there is a thing that truncates this kind of pathnames to say <phorge>/path/to. I would like to invest some time to reuse that, so, no need of substr(strlen(substr(realpath

Nice name btw

git rebase master

Thaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaanks

Thaaaaaaaaaaaaanks. It works also on my computer woooo

I don't have permission to create Manifest Tasks, so I cannot create a Phorge task linking to the phabricator one

Makes sense. The only mention of anchor-target I can (and could at the time of introducing that CSS) can find is in webroot/rsrc/js/core/behavior-watch-anchor.js but still clueless how to ever trigger that in conpherence - it's related to an anchor link like Z2#26 but that doesn't have the parent classes of the CSS selector.

Do not concatenate strings (patchwork messages; lego messages) in getRuleViewDescription() so translations can be correct

Use getProductionURI(), not getEnvConfig()

Closed all inline comments.

• adopt suggested indentation in ArcanistRepositoryRef.php:91-94
• adopt explicit "TODO" in ArcanistRepositoryRef.php:138-139

A related task (maybe not a sub-task?) is probably that the advanced search of herald ( https://we.phorge.it/herald/ ) does not allow to find these by involved project(s).

Reading (and testing) this again/more, after our first round in person a few days ago, now that I have a local SVN repo, I cannot find anything wrong or non-working, still I'd ideally appreciate another pair of eyes.
Added two more small comments.

In D25987#26708, @aklapper wrote:

Note that in the screenshots I used an extremely broad CSS selector as that broad one was specifically mentioned

Note that in the screenshots I used an extremely broad CSS selector as that broad one was specifically mentioned in the previous comment here.

Sometime un

1. see parent task
2. This wouldn't actually help the described use-case anyway.

(see parent task - I'm against this).

ArcanistRepositoryAPI: apply suggested inline comment:

@matmarex: please look at the screenshots of Andre above: can I ask if such new selector would really simplify your downstream job? or, is there anything else missing / that we should do instead?

I have not a strong opinion about author usernames (T16052) but if you say to decline that makes sense, especially if at least as small compromise we simplify bot recognition, T16051 and D25987, so that local installs can rewrite their UX without completely nuking their past history and doing complicated comment→transaction migrations on past data.

The CSS rule has never been applied. After the change it will be. Please help by adding a line in the test plan about how to reproduce it if you have some time 🙏

Thaaanks

Keep route / path in both places as tasks-assigned/ for consistency

In T15998#21086, @Cigaryno wrote:

Did anyone think of showing two separate queries on Tasks

What is Tasks? Could you share an URI? By default http://phorge.localhost/maniphest/ already offers Assigned, Authored, etc. saved queries in the sidebar.

implement avivey's feedbacks