In D25847#26647, @aklapper wrote:

Resigning as this developed into a larger patch requiring testing; shouldn't be listed as "accepted" as that referred to a revision long ago

Resigning as this developed into a larger patch requiring testing; shouldn't be listed as "accepted" as that referred to a revision long ago

Ready for review :3 based on the other one.

In D25987#26601, @valerio.bozzolan wrote:

Uhm. I don't know why but locally I cannot find the selector.

add a potential performance TODO in legacy code: T16061: PhabricatorEnv isSelfURI(): add small cache of these self-URIs

Avoid $array[$key]=1 and use $array[$key]=$key as suggested

I suggest testing by setting window width = 1791px (e.g. CTRL+shift+M on Firefox), and then passing to window width = 1792px. So we can see that the content max width at the moment always seems ~ 800px.

Uhm - but looking at your screenshot, at looking here T15920, it seems a regression

Patch welcome, with "Ref T15920"

When reading the wiki at a resolution of 3440x1440 (34 inch monitor), there is still a lot of white space.

Uhm. I don't know why but locally I cannot find the selector. Also this should help in getting the selector but without success, both from the home, or from a task created and assigned to a bot.

Nice. Just for fun I've played intensively with https://developer.mozilla.org/en-US/docs/Web/CSS/font-smooth without being able to notice whatsoever difference, so, green light I assume. Thanks

drop newline

add some inline documentation about $array[$v] = 1

Generated with

Feel free to throw the patch as-is, as I usual I love to cleanup and test more loool

I have a patch ready, need to clean up and test more

Generate a super-useful documentation table in Remarkup

It kind of makes sense.
maybe some day we'll need to extract the Identity table to a different place.

Ouch. Indeed my last comment had no sense. I was meaning T15941 that should be kept opened.

Ops I've closed this by mistake. We closed just T15564 👍

Can this be resolved? If not, what exactly is left in this task (apart from separate T15803)?

P.S. - XACT exists, but it does not support the newObject():

Additionally, I don't know if we are able here to show the "supported types" in line 391 (that are less than the existing types, needed in the other if case).

In D25988#26522, @aklapper wrote:

Should ideally use the same error message as in https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php;4862eada5cd05236b81487b261668f2a2d72fad7$382-387 so one string less to translate.

Ironically though, that existing message will list XACT used to trigger this issue:

Ops I've closed this by mistake. We closed just T15564 👍