Any patch is welcome :)

Thanks. Tested and it works! no regressions.

Is there any plans for this?

Exactly. Like I said probably you will find interesting things debugging $old_text. I guess it's empty. That's probably our root cause. What do you think about?

Maybe interesting, there is this different non-deprecated API:

I mean, it should do exactly that,

Double-slam accept

Do as Valerio said. Tested before and after, two errors less in PHPStan output.

I saw that in my searching but I just end up with Argument 1 passed to PhabricatorCustomField::getObjectField() must implement interface PhabricatorCustomFieldInterface whenever I try to use it, perhaps because I'm unsure what to actually pass it as the $object other than $this, though I second-guess my second-guessing because ManifestCustomField, which I'm extending, does seem to have the interface the error is claiming I'm missing?

In your opinion, why is the current code not working? I mean, it should do exactly that, checking the text before, and the text after, so, to only mention newly-introduced mentions.

Eh, there is a trade-off: Editing the description of an existing task to add a @mention will not add this newly mentioned user as a task subscriber anymore.

Sorry for the delay with this. I've moved the null check as suggested.

Move null check to earlier in function

Make lint happy

Only one fix remains. I set "unclear" in the test plan accordingly to T15536. If you still want to merge, just:

git rebase master

rebase

feeex typo (theenks aklapper)

Either INVITEED_* is a typo or I don't get what the second E stands for. :)

Not sure what "similar working links" means... Something like https://we.phorge.it/diviner/find/?name=PhutilSafeHTML ?

Is this also the reason why links to e.g. https://we.phorge.it/diviner/find/?name=JX.behavior&type=function&jump=1 on https://we.phorge.it/book/javelin/article/behaviors/ or to http://we.phorge.it/diviner/find/?name=JX.Stratcom&type=class&jump=1 are 404s, or do I misunderstand and that's a separate issue?

Urgh. In calling https://we.phorge.it/source/phorge/browse/master/src/applications/diviner/query/DivinerAtomQuery.php$340 , $this->titles is an array which has a length of 1, with its only member being null. Sounds like there's already something fishy before.

Where I can find similar working links? I've tried generating Diviner books for both Arcanist and Phorge but http://phorge.localhost/diviner/find/?name=JX.Stratcom is still giving me 404