There are, in total, 3 call-sites to setErrorListener - in for the daemons, one for dark-console, and one (PhutilErrorLog) that lives in arcanist but is only used by the SSHD scripts.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Aug 11 2023
Aug 11 2023
aklapper committed rP98dfac53ba72: Fix PHP 8.1 "strlen(null)" exceptions blocking account registration with custom….
Fix PHP 8.1 "strlen(null)" exceptions blocking account registration with custom…
aklapper committed rPa2e8ab318070: Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step….
Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step…
aklapper closed T15591: PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper committed rPc61c6a1ec3c1: Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan.
Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan
aklapper committed rP085769ceb687: Fix PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth….
Fix PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth…
aklapper closed T15580: PHP 8.1 "strlen(null)" exception setting Passphrase Credential, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper committed rP10ee019785d5: Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential
Replace dedicated Commit Field with an existing one
Minimal fix to the issue as discussed...
Sten added a comment to T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.
That works...
avivey added a comment to T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.
I've replaced it with DifferentialRevertPlanCommitMessageField, anyway - that one already has all the required stuff.
Sten added a comment to T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.
Simply adding a FIELDKEY adds Test: to the title of a new diff, but the full fix of making DifferentialTestCommitMessageField a DifferentialCommitMessageCustomField doesn't
avivey claimed T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.
Unfortunately, that fix adds the word "Test:" to the title of any new diff. I'm trying to find an existing field that can make the test work, or else find another creative solution.
avivey added a comment to D25334: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.
The test-field gets picked up automatically because we pick all fields. It's missing FIELDKEY, so arc-diff doesn't work at all, and if we add FIELDKEY it shows up as the first field in the arc-diff form.
Sten added a comment to T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.
I have a fix, but can't create it. Will need manually applying to the server:
Sten updated the task description for T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.
valerio.bozzolan updated the task description for T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.
Please also manually run this
Yeah bob, feel free to add your nice screenshots in the Task description for more visibility. You are a good minion!
Matthew accepted D25383: Fix a PHP 8.1/8.2 deprecated use of strlen deprecated call with a NULL argument.
LGTM
LGTM
In workboard, empty column's drop zone is a little bit 'agressive' isn't it ?
bob updated the diff for D25383: Fix a PHP 8.1/8.2 deprecated use of strlen deprecated call with a NULL argument.
Updating D25383: Removing useless fallback string definition when calling idx
Gotcha. So
- isset() is safer when pulling things out of arrays.
- phutil_non_empty_string() provides for stricter parameter checking as it demands the array value is set, even if set to null.
valerio.bozzolan added a comment to D25383: Fix a PHP 8.1/8.2 deprecated use of strlen deprecated call with a NULL argument.
Thanks! Interestingly you fixed an incomplete fix since D25128
Sten closed T15529: arc diff DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors , a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Sten committed rP8310591523f5: Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors.
Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors
Sten committed rP4b3c384856da: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.
Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error
Sten closed T15548: PHP 8.2 "ltrim(null)" exception while executing ./bin/diviner generate, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Fix PHP 8.1 trim(null) exception in ./bin/diviner generate
tl;dr: I like phutil_nonempty_string($map['query']) better if we know $map['query'] is defined, and phutil_nonempty_string(idx($map, 'query')) otherwise.
Aug 10 2023
Aug 10 2023
Gentle reminder that this has been waiting review for a while now...
Gentle reminder that this has been waiting review for a while now...
Sten added a comment to D25334: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.
Gentle reminder that this has been waiting review for a while now...
Sten added a comment to D25333: Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors.
Gentle reminder that this has been waiting review for a while now...
Gentle reminder that this has been waiting review for a while now...
bob updated the summary of D25383: Fix a PHP 8.1/8.2 deprecated use of strlen deprecated call with a NULL argument.
bob closed T15595: PHP 8.2 "strlen() null exception" when using the top bar search tool, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Fix PHP 8.1/8.2 "strlen(null)" exception in SearchController
bob committed rP2da7594344c9: Fix a PHP 8.1/8.2 deprecated call to strlen with a NULL argument (authored by root <root@streamvision.com>).
Fix a PHP 8.1/8.2 deprecated call to strlen with a NULL argument
valerio.bozzolan added a comment to D25381: Fix a PHP 8.1/8.2 deprecated call to strlen with a NULL argument.
Would you like to try yourself arc patch D25381 and then arc land to land into master branch?
Perfect ! Thanks for the review valerio !
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0