Page MenuHomePhorge
Feed All Stories

May 9 2023

avivey removed a project from T15361: PHP 8.1 "explode(null)" exception blocks rendering the Multimeter page: Phorge.
May 9 2023, 10:42 · PHP 8 support
avivey removed a project from T15362: PHP 8.1 "strlen(null)" exceptions block rendering page to import ICS calendar file: Phorge.
May 9 2023, 10:42 · PHP 8 support
avivey removed a project from T15363: PHP 8.1 "strlen(null)" exception blocks rendering Phortune account page: Phorge.
May 9 2023, 10:42 · PHP 8 support
avivey removed a project from T15365: PHP 8.1 "strlen(null)" exception blocks rendering error pages for Packages' Create Package and Fund's Create Initiative: Phorge.
May 9 2023, 10:42 · PHP 8 support
avivey removed a project from T15306: Fix Call to phutil_nonempty_string() expected null or a string, got: PhutilURI from PHUIObjectItemView.php:662: Phorge.
May 9 2023, 10:42 · Bug Reports, PHP 8 support
avivey edited projects for T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing, added: PHP 8 support; removed Remarkup, Phorge.
May 9 2023, 10:35 · Bug Reports, Remarkup, Affects-Wikimedia
valerio.bozzolan added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.

Premising that very probably a fix there would not 100% resolve that upstream issue but surely this deserves a fix :D

May 9 2023, 08:05 · Bug Reports, Remarkup, Affects-Wikimedia
valerio.bozzolan added a project to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing: Remarkup.
May 9 2023, 08:03 · Bug Reports, Remarkup, Affects-Wikimedia
valerio.bozzolan added a project to T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing: Affects-Wikimedia.
May 9 2023, 08:02 · Bug Reports, Remarkup, Affects-Wikimedia
aklapper created T15371: RuntimeException in preg_replace_callback: Text disappears due to catastrophic backtracking regex in Remarkup parsing.
May 9 2023, 07:52 · Bug Reports, Remarkup, Affects-Wikimedia
valerio.bozzolan edited the content of Next Up (since Week 18).
May 9 2023, 07:22
valerio.bozzolan accepted D25182: Fix PHP 8.1 "strlen(null)" and "preg_match()" exceptions which block repository creation.

I invested so much energies in this patch in trying some facets, and I think I really cannot verify more stuff without becoming completely insane.

May 9 2023, 07:20
valerio.bozzolan closed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98], a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
May 9 2023, 06:29 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98] as Resolved by committing rARCc14785c3795c: Fix PHP 8.1 "strpos(null)" exception from PhutilCommandString which blocks arc….
May 9 2023, 06:29 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan closed D25205: Fix PHP 8.1 "strpos(null)" exception from PhutilCommandString which blocks arc patch.
May 9 2023, 06:29
valerio.bozzolan committed rARCc14785c3795c: Fix PHP 8.1 "strpos(null)" exception from PhutilCommandString which blocks arc….
May 9 2023, 06:29
avivey accepted D25205: Fix PHP 8.1 "strpos(null)" exception from PhutilCommandString which blocks arc patch.
May 9 2023, 06:27

May 8 2023

aklapper closed T15362: PHP 8.1 "strlen(null)" exceptions block rendering page to import ICS calendar file as Resolved by committing rP8d2b481bb5a8: Fix PHP 8.1 "strlen(null)" exceptions which block rendering page to import ICS….
May 8 2023, 21:13 · PHP 8 support
aklapper closed D25200: Fix PHP 8.1 "strlen(null)" exceptions which block rendering page to import ICS calendar file.
May 8 2023, 21:13
aklapper committed rP8d2b481bb5a8: Fix PHP 8.1 "strlen(null)" exceptions which block rendering page to import ICS….
May 8 2023, 21:13
valerio.bozzolan edited the content of Why Migrate from Phabricator to Phorge.
May 8 2023, 20:34
valerio.bozzolan added a comment to T15239: phutil_nonempty_scalar() should never throw an exception with valid scalars (like booleans).

By the way the only usages are:

May 8 2023, 20:19 · User-valerio.bozzolan, Arcanist
valerio.bozzolan added a comment to D25025: Unify user-select CSS directives.

@Matthew please remove the red flag from this revision :) Thank you so much

May 8 2023, 20:12
valerio.bozzolan added a comment to D25067: Change erroneous loose comparison to strict comparison in tab panels.

Hi @Dylsss, feel free to land :) A reviewer approved this patch!

May 8 2023, 20:11
valerio.bozzolan added a comment to D25143: Update the arc-hg.py extension to work with mercurial 6.4.

Hi @speck, feel free to land :)

May 8 2023, 20:09
valerio.bozzolan accepted D25200: Fix PHP 8.1 "strlen(null)" exceptions which block rendering page to import ICS calendar file.

I tested both values locally with phlog() and using some forms as the test plan suggests.

May 8 2023, 20:08
aklapper closed T15365: PHP 8.1 "strlen(null)" exception blocks rendering error pages for Packages' Create Package and Fund's Create Initiative, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 8 2023, 19:43 · PHP 8 support
aklapper closed T15365: PHP 8.1 "strlen(null)" exception blocks rendering error pages for Packages' Create Package and Fund's Create Initiative as Resolved by committing rP1b08be518ef6: Fix PHP 8.1 "strlen(null)" exception which blocks rendering error pages for….
May 8 2023, 19:43 · PHP 8 support
aklapper closed D25202: Fix PHP 8.1 "strlen(null)" exception which blocks rendering error pages for Packages' Create Package and Fund's Create Initiative.
May 8 2023, 19:43
aklapper committed rP1b08be518ef6: Fix PHP 8.1 "strlen(null)" exception which blocks rendering error pages for….
May 8 2023, 19:43
valerio.bozzolan accepted D25202: Fix PHP 8.1 "strlen(null)" exception which blocks rendering error pages for Packages' Create Package and Fund's Create Initiative.

Thanks again

May 8 2023, 19:25
20after4 added a comment to T15364: arc land complaints summary by FreeBSD community.

FWIW I think the test plan is configurable (that requirement can be disabled in phabricator's config server side which should remove it from commit messages in arc)

May 8 2023, 18:21 · Arcanist, Differential, Affects-FreeBSD
speck added a comment to T15351: Create repository for Conduit API client in Rust.

One other thing we’ll need to address is the current code sharing between arcanist and phorge. I’m not sure the full scope of what Phorge relies on from arcanist but I think there’sa fair amount. We can probably get an idea by looking at the libphutil repo which was the shared library between the two which was eventually merged into arcanist

May 8 2023, 17:38 · Phactory: Community Projects
valerio.bozzolan placed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98] up for grabs.

Yeah no problem!

May 8 2023, 17:14 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a comment to T15368: PHP 8.1 fix PhutilUTF8StringTruncator::truncateString(NULL) called at [<arcanist>/src/ref/ArcanistRefView.php:103].

Hi @aklapper. Are you affected by this as well?

May 8 2023, 17:07 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton reopened T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98], a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Open.
May 8 2023, 17:07 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton reopened T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98] as "Open".

@valerio.bozzolan right, I forgot the important bit, sorry :D

May 8 2023, 17:07 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a comment to T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98].

Note that probably @ton you have resolved, but anybody else nope :D The patch D25205 still needs review and land

May 8 2023, 17:06 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton closed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98], a subtask of T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo), as Resolved.
May 8 2023, 17:06 · PHP 8 support, Arcanist, User-valerio.bozzolan
ton closed T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98] as Resolved.
May 8 2023, 17:06 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
May 8 2023, 17:04 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan requested review of D25206: Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc look remotes".
May 8 2023, 17:04
valerio.bozzolan added a revision to T15368: PHP 8.1 fix PhutilUTF8StringTruncator::truncateString(NULL) called at [<arcanist>/src/ref/ArcanistRefView.php:103]: D25206: Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc look remotes".
May 8 2023, 17:04 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan requested review of D25205: Fix PHP 8.1 "strpos(null)" exception from PhutilCommandString which blocks arc patch.
May 8 2023, 16:53
valerio.bozzolan added a revision to T15367: PHP 8.1 fix strpos(NULL, string) called at [<arcanist>/src/xsprintf/PhutilCommandString.php:98]: D25205: Fix PHP 8.1 "strpos(null)" exception from PhutilCommandString which blocks arc patch.
May 8 2023, 16:53 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan awarded Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing") a Yellow Medal token.
May 8 2023, 15:40
valerio.bozzolan updated the answer details for Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing") (Answer 67).
May 8 2023, 15:39
valerio.bozzolan updated Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing") from Diffusion - Latest Commits not showing in PHP 8.1 and above to Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").
May 8 2023, 15:07
valerio.bozzolan closed Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing") as resolved.
May 8 2023, 15:07
valerio.bozzolan added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

Since this question has an answer and a related Task and a related Patch, I mark this as closed :)

May 8 2023, 15:07
valerio.bozzolan updated the answer details for Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing") (Answer 67).
May 8 2023, 15:05
valerio.bozzolan added Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing") (Answer 67).
May 8 2023, 15:05
valerio.bozzolan updated subscribers of D25204: Fix PHP 8.1 "strlen(null)" exception which can block repository imports.

@amit Can you please try again with PHP 8.1 enabled, check whenever this patch fixes your problem? (Or, at least, it unlocks another problem)

May 8 2023, 15:03
amit added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

Works fine after downgrading to PHP 7.4

May 8 2023, 15:02
valerio.bozzolan requested review of D25204: Fix PHP 8.1 "strlen(null)" exception which can block repository imports.
May 8 2023, 15:02
valerio.bozzolan added a revision to T15370: PHP 8.1 "strlen(null)" exceptions block repository import: D25204: Fix PHP 8.1 "strlen(null)" exception which can block repository imports.
May 8 2023, 15:02 · Bug Reports, Diffusion, PHP 8 support
valerio.bozzolan triaged T15370: PHP 8.1 "strlen(null)" exceptions block repository import as High priority.
May 8 2023, 15:01 · Bug Reports, Diffusion, PHP 8 support
valerio.bozzolan updated Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing") from Diffusion - Latest Commits not showing to Diffusion - Latest Commits not showing in PHP 8.1 and above.
May 8 2023, 14:52
amit added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

Oh no.......... I think some auto-update has updated the PHP version to 8.2

May 8 2023, 14:39
valerio.bozzolan added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

The bad news is that you are using PHP 8.1 or above that is not supported officially since never

May 8 2023, 14:35
valerio.bozzolan updated the question details for Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").
May 8 2023, 14:31
amit added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

I see this strlen() error keeps repeating, and it is flooding the daemon.log

May 8 2023, 14:31
amit added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

Ah! I was looking in php error log

May 8 2023, 14:13
valerio.bozzolan updated the diff for D25120: Mobile: hide unuseful "Persistent Chat" checkbox.
  • update celerity map again
May 8 2023, 13:34
valerio.bozzolan updated the task description for T15187: Fix Arcanist in PHP 8.1+ (testing the Phorge repo).
May 8 2023, 13:31 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

Premising that it is very strange that the daemon log is not telling anything in your /var/tmp/phd/log/daemons.log about this thing

May 8 2023, 13:19
valerio.bozzolan added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

Kind of

May 8 2023, 13:15
valerio.bozzolan updated the question details for Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").
May 8 2023, 13:15
valerio.bozzolan added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

Can I ask your current commit hash of Phorge?

May 8 2023, 13:14
amit added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

Sorry for not giving more info

May 8 2023, 13:09
valerio.bozzolan claimed T15347: Auto-subscription is a little bit too verbose: «Person added a subscriber: Person».
May 8 2023, 13:07 · UX
valerio.bozzolan added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

Thanks! uhm...... still unclear how to help. Feel free to clarify these:

May 8 2023, 13:04
amit updated the question details for Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").
May 8 2023, 13:02
valerio.bozzolan renamed T15299: Config page runs git commands that should have an HOME to open gitconfig correctly from Config page runs git commands that must have an HOME to open gitconfig correctly to Config page runs git commands that should have an HOME to open gitconfig correctly.
May 8 2023, 12:58 · Config
avivey renamed T15369: Clarify the "Do nothing" Herald Action from Clarify the "Do nothing" Herald rule to Clarify the "Do nothing" Herald Action.
May 8 2023, 12:42 · Herald
aklapper updated the diff for D25203: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.

Uhm, remove now duplicated package name. Heh.

May 8 2023, 12:41
valerio.bozzolan updated the task description for T15369: Clarify the "Do nothing" Herald Action.
May 8 2023, 12:39 · Herald
aklapper closed T15363: PHP 8.1 "strlen(null)" exception blocks rendering Phortune account page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 8 2023, 12:36 · PHP 8 support
aklapper closed T15363: PHP 8.1 "strlen(null)" exception blocks rendering Phortune account page as Resolved by committing rP25e93501c39e: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Phortune account….
May 8 2023, 12:36 · PHP 8 support
aklapper closed D25201: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Phortune account page.
May 8 2023, 12:36
aklapper committed rP25e93501c39e: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Phortune account….
May 8 2023, 12:36
aklapper closed T15360: PHP 8.1 "strlen(null)" exception blocks rendering a project's page when Reports prototype enabled, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 8 2023, 12:35 · PHP 8 support
aklapper closed T15360: PHP 8.1 "strlen(null)" exception blocks rendering a project's page when Reports prototype enabled as Resolved by committing rPaa8baf1c8b59: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a project's page….
May 8 2023, 12:35 · Projects, PHP 8 support
aklapper closed D25199: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a project's page when Reports prototype enabled.
May 8 2023, 12:35
aklapper committed rPaa8baf1c8b59: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a project's page….
May 8 2023, 12:35
aklapper closed T15359: PHP 8.1 "ltrim(null)" exception blocks rendering five applications' Configure pages, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 8 2023, 12:33 · PHP 8 support
aklapper closed T15359: PHP 8.1 "ltrim(null)" exception blocks rendering five applications' Configure pages as Resolved by committing rP3819f7ff196e: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering five applications'….
May 8 2023, 12:33 · PHP 8 support
aklapper closed D25198: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering five applications' Configure pages.
May 8 2023, 12:33
aklapper committed rP3819f7ff196e: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering five applications'….
May 8 2023, 12:33
valerio.bozzolan updated the task description for T15369: Clarify the "Do nothing" Herald Action.
May 8 2023, 12:31 · Herald
valerio.bozzolan triaged T15369: Clarify the "Do nothing" Herald Action as Low priority.
May 8 2023, 12:29 · Herald
valerio.bozzolan added a project to T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool: Affects-Wikimedia.
May 8 2023, 12:25 · Bug Reports, Affects-Wikimedia, Herald
valerio.bozzolan closed Q54: Conpherence notification settings are in inconsistent location as resolved.
May 8 2023, 12:13 · Conpherence
valerio.bozzolan added a comment to Q54: Conpherence notification settings are in inconsistent location.

I close this answer since probably now we have an answer that explains the current situation. But, feel free to also file a specific Task under Conpherence (also feel free to put myself in Subscribers since I'm interested in that)

May 8 2023, 12:13 · Conpherence
valerio.bozzolan added a comment to Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").

Can you please share more details in the question? Is that a new installation? have you seen the logs? are your daemons running? Thanks :)

May 8 2023, 12:11
amit asked Q55: Diffusion - Latest Commits not showing in PHP 8.1 and above ("Still Importing").
May 8 2023, 12:01
valerio.bozzolan accepted D25199: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a project's page when Reports prototype enabled.

Thanks for this patch

May 8 2023, 11:51
valerio.bozzolan accepted D25198: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering five applications' Configure pages.

Thanks for this patch (again)

May 8 2023, 11:36
aklapper closed T15358: PHP 8.1 "strlen(null)" exception blocks rendering most projects' Configure pages, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 8 2023, 11:23 · PHP 8 support
aklapper closed T15358: PHP 8.1 "strlen(null)" exception blocks rendering most projects' Configure pages as Resolved by committing rPd74e9d825a2c: Fix PHP 8.1 "strlen(null)" exception which blocks rendering most applications'….
May 8 2023, 11:23 · PHP 8 support