Page MenuHomePhorge
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Sep 20 2023

Sten created T15641: Creating or editing a project under PHP 8.1 causes strlen() null error with custom integer fields.
Sep 20 2023, 19:21 · PHP 8 support
Sten closed D25434: Add documentation for cowsay.
Sep 20 2023, 09:21
Sten committed rP91faf16cace9: Add documentation for cowsay.
Add documentation for cowsay
Sep 20 2023, 09:21
Sten added a comment to D25434: Add documentation for cowsay.

No further changes requested in 13 days, so am going to land this diff.

Sep 20 2023, 09:21

Sep 12 2023

Sten updated the diff for D25436: Update PhutilCowsay.php to work for small cows.

Update unit test

Sep 12 2023, 16:12
Sten planned changes to D25436: Update PhutilCowsay.php to work for small cows.
Sep 12 2023, 16:10
Sten requested review of D25436: Update PhutilCowsay.php to work for small cows.
Sep 12 2023, 16:09
Sten closed D25435: Fix rendering of cowsay sheep.cow.
Sep 12 2023, 14:57
Sten committed rARC35e127da57a8: Fix rendering of cowsay sheep.cow.
Fix rendering of cowsay sheep.cow
Sep 12 2023, 14:57

Sep 11 2023

Sten updated the diff for D25435: Fix rendering of cowsay sheep.cow.

Updates as per reviews

Sep 11 2023, 12:39
Sten closed T15634: auth view results in strlen(null) error under PHP 8.1, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Sep 11 2023, 10:57 · PHP 8 support
Sten closed T15634: auth view results in strlen(null) error under PHP 8.1 as Resolved by committing rPa0fb344b9488: Fix PHP 8.1 auth view strlen(null) error.
Sep 11 2023, 10:57 · PHP 8 support
Sten closed D25432: Fix PHP 8.1 auth view strlen(null) error.
Sep 11 2023, 10:57
Sten committed rPa0fb344b9488: Fix PHP 8.1 auth view strlen(null) error.
Fix PHP 8.1 auth view strlen(null) error
Sep 11 2023, 10:57
Sten updated the diff for D25434: Add documentation for cowsay.

Add a note about figlet

Sep 11 2023, 10:56
Sten updated the summary of D25435: Fix rendering of cowsay sheep.cow.
Sep 11 2023, 10:13
Sten requested review of D25435: Fix rendering of cowsay sheep.cow.
Sep 11 2023, 10:12

Sep 8 2023

Sten added inline comments to D25418: Catch RuntimeException: mb_convert_encoding(): Illegal character encoding specified at PhabricatorTextDocumentEngine.php:73.
Sep 8 2023, 08:35
Sten accepted D25431: Fix PHP 8.1 "strlen(null)" exception rendering Task with empty custom date field.
Sep 8 2023, 08:17

Sep 7 2023

Sten added a comment to D25434: Add documentation for cowsay.

Please wait 2-3 days before landing, so other people can share useful tips

Sep 7 2023, 13:27

Sep 6 2023

Sten closed T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Sep 6 2023, 11:24 · PHP 8 support
Sten closed T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1 as Resolved by committing rPf7d9d95b79f7: Fix Diviner strlen(null) error when clicking on a link.
Sep 6 2023, 11:23 · PHP 8 support
Sten closed D25433: Fix Diviner strlen(null) error when clicking on a link.
Sep 6 2023, 11:23
Sten committed rPf7d9d95b79f7: Fix Diviner strlen(null) error when clicking on a link.
Fix Diviner strlen(null) error when clicking on a link
Sep 6 2023, 11:23
Sten updated the diff for D25434: Add documentation for cowsay.

Updated differential_faq.diviner as per review.

Sep 6 2023, 11:19
Sten updated the diff for D25434: Add documentation for cowsay.

Cowsay documentation moved to Remarkup section
Links to Remarkup section added to Differential documentation

Sep 6 2023, 06:57
Sten updated the diff for D25434: Add documentation for cowsay.

Cowsay documentation moved to Remarkup section
Links to Remarkup section added to Differential documentation

Sep 6 2023, 06:56

Sep 5 2023

Sten planned changes to D25434: Add documentation for cowsay.
In D25434#12399, @valerio.bozzolan wrote:

lol

Just a question. Why under differential and not related to Remarkup?

Sep 5 2023, 19:42
Sten closed D25367: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.
Sep 5 2023, 16:33
Sten closed T15574: PHP8.1: strlen() null exception when creating a tab panel in a dashboard, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Sep 5 2023, 16:33 · PHP 8 support
Sten closed T15574: PHP8.1: strlen() null exception when creating a tab panel in a dashboard as Resolved by committing rP1720209f16c3: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.
Sep 5 2023, 16:33 · PHP 8 support
Sten committed rP1720209f16c3: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.
Various PHP 8.1 strlen(null) fixes for Dashboard Panels
Sep 5 2023, 16:33
Sten added a comment to D25434: Add documentation for cowsay.
___________________________ < Please approve this diff! > --------------------------- \ . . \ / `. .' " \ .---. < > < > .---. \ | \ \ - ~ ~ - / / | _____ ..-~ ~-..-~ | | \~~~\.' `./~~~/ --------- \__/ \__/ .' O \ / / \ " (_____, `._.' | } \/~~~/ `----. / } | / \__/ `-. | / | / `. ,~~| ~-.__| /_ - ~ ^| /- _ `..-' | / | / ~-. `-. _ _ _ |_____| |_____| ~ - . _ _ _ _ _>
Sep 5 2023, 16:31
Sten requested review of D25434: Add documentation for cowsay.
Sep 5 2023, 16:29
Sten requested review of D25433: Fix Diviner strlen(null) error when clicking on a link.
Sep 5 2023, 16:05
Sten added a revision to T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1: D25433: Fix Diviner strlen(null) error when clicking on a link.
Sep 5 2023, 16:05 · PHP 8 support
Sten claimed T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1.
Sep 5 2023, 16:01 · PHP 8 support
Sten created T15635: Clicking on a link in Diviner results in a strlen(null) error under PHP 8.1.
Sep 5 2023, 16:01 · PHP 8 support
Sten added a comment to D25367: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.

Hi all, can this be approved if no one has any objections? Dashboards simply can't be modified under PHP 8.1 without this. Thanks.

Sep 5 2023, 14:18
Sten requested review of D25432: Fix PHP 8.1 auth view strlen(null) error.
Sep 5 2023, 14:16
Sten added a revision to T15634: auth view results in strlen(null) error under PHP 8.1: D25432: Fix PHP 8.1 auth view strlen(null) error.
Sep 5 2023, 14:16 · PHP 8 support
Sten claimed T15634: auth view results in strlen(null) error under PHP 8.1.
Sep 5 2023, 14:07 · PHP 8 support
Sten created T15634: auth view results in strlen(null) error under PHP 8.1.
Sep 5 2023, 14:07 · PHP 8 support

Aug 28 2023

Sten accepted D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.

Looks good

Aug 28 2023, 13:36
Sten accepted D25423: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.

Looks good to me.

Aug 28 2023, 13:33

Aug 18 2023

Sten closed T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null) as Resolved by committing rARC8b907d771661: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 13:58 · PHP 8 support
Sten closed T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null), a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 18 2023, 13:58 · PHP 8 support
Sten closed D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 13:58
Sten committed rARC8b907d771661: Fix PHP 8.1 arc patch strlen(null) binary file error.
Fix PHP 8.1 arc patch strlen(null) binary file error
Aug 18 2023, 13:58
Sten accepted D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Looks good to me.

Aug 18 2023, 13:06
Sten added a comment to D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
In D25409#11652, @avivey wrote:

I think phutil_nonempty_string fails faster then strlen (strlen allowing automatic conversion of string-like things to string and phutil_nonempty_string doesn't), but I'm a little confused right now...

Aug 18 2023, 10:12
Sten created Image Macro "technicallycorrect".
Aug 18 2023, 10:11
Sten updated the diff for D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.

Switch to using phutil_nonempty_string

Aug 18 2023, 10:06
Sten updated the task description for T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null).
Aug 18 2023, 09:21 · PHP 8 support
Sten added a comment to D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
In D25409#11648, @avivey wrote:

phutil_nonempty_string is basically the exact same thing, but with stricter type control

Aug 18 2023, 09:19
Sten added a comment to D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 09:14
Sten updated the summary of D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 09:09
Sten added a revision to T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null): D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 09:09 · PHP 8 support
Sten added inline comments to D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 09:05
Sten requested review of D25409: Fix PHP 8.1 arc patch strlen(null) binary file error.
Aug 18 2023, 09:02
Sten claimed T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null).
Aug 18 2023, 08:58 · PHP 8 support
Sten created T15617: arc patch fails when binary files are added/removed with PHP 8.1 strlen(null).
Aug 18 2023, 08:58 · PHP 8 support

Aug 16 2023

Sten accepted D25397: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument.

Looks safe and sensible.

Aug 16 2023, 20:16

Aug 12 2023

Sten closed T15517: Differential PHP 8.1 failure - DifferentialChangeset getOldStatePathVector() strlen, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 12 2023, 07:39 · PHP 8 support
Sten closed D25323: Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector().
Aug 12 2023, 07:39
Sten closed T15517: Differential PHP 8.1 failure - DifferentialChangeset getOldStatePathVector() strlen as Resolved by committing rPe8ea7a4a3697: Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector().
Aug 12 2023, 07:39 · PHP 8 support
Sten committed rPe8ea7a4a3697: Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector().
Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector()
Aug 12 2023, 07:39

Aug 11 2023

Sten added a comment to D25385: Replace dedicated Commit Field with an existing one.

Minimal fix to the issue as discussed...

Aug 11 2023, 18:39
Sten accepted D25385: Replace dedicated Commit Field with an existing one.
Aug 11 2023, 18:38
Sten added a comment to T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.

That works...

Aug 11 2023, 18:33
Sten added a comment to T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.

Simply adding a FIELDKEY adds Test: to the title of a new diff, but the full fix of making DifferentialTestCommitMessageField a DifferentialCommitMessageCustomField doesn't

Aug 11 2023, 18:29
Sten placed T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant up for grabs.
Aug 11 2023, 18:07
Sten added a comment to T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.

I have a fix, but can't create it. Will need manually applying to the server:

Aug 11 2023, 17:28
Sten updated the task description for T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.
Aug 11 2023, 17:27
Sten claimed T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.
Aug 11 2023, 17:18
Sten created T15600: arc patch broken - class "DifferentialTestCommitMessageField" must define a "FIELDKEY" constant.
Aug 11 2023, 17:18
Sten added a comment to D25367: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.

Gotcha. So

  • isset() is safer when pulling things out of arrays.
  • phutil_non_empty_string() provides for stricter parameter checking as it demands the array value is set, even if set to null.
Aug 11 2023, 10:02
Sten closed T15529: arc diff DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors , a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 11 2023, 09:40 · PHP 8 support
Sten closed D25333: Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors.
Aug 11 2023, 09:40
Sten closed T15529: arc diff DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors as Resolved by committing rP8310591523f5: Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors.
Aug 11 2023, 09:40 · PHP 8 support
Sten committed rP8310591523f5: Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors.
Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors
Aug 11 2023, 09:40
Sten closed T15530: arc diff throws PHP 8.1 strlen(null) error from DifferentialCommitMessageField renderFieldValue, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 11 2023, 09:38 · PHP 8 support
Sten closed D25334: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.
Aug 11 2023, 09:38
Sten closed T15530: arc diff throws PHP 8.1 strlen(null) error from DifferentialCommitMessageField renderFieldValue as Resolved by committing rP4b3c384856da: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.
Aug 11 2023, 09:38 · PHP 8 support
Sten committed rP4b3c384856da: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.
Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error
Aug 11 2023, 09:38
Sten closed T15548: PHP 8.2 "ltrim(null)" exception while executing ./bin/diviner generate as Resolved by committing rP9c8b9a6bbf04: Fix PHP 8.1 trim(null) exception in ./bin/diviner generate.
Aug 11 2023, 09:37 · PHP 8 support
Sten closed T15548: PHP 8.2 "ltrim(null)" exception while executing ./bin/diviner generate, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 11 2023, 09:37 · PHP 8 support
Sten closed D25353: Fix PHP 8.1 trim(null) exception in ./bin/diviner generate.
Aug 11 2023, 09:37
Sten committed rP9c8b9a6bbf04: Fix PHP 8.1 trim(null) exception in ./bin/diviner generate.
Fix PHP 8.1 trim(null) exception in ./bin/diviner generate
Aug 11 2023, 09:37

Aug 10 2023

Sten added a comment to D25367: Various PHP 8.1 strlen(null) fixes for Dashboard Panels.

Gentle reminder that this has been waiting review for a while now...

Aug 10 2023, 16:35
Sten added a comment to D25353: Fix PHP 8.1 trim(null) exception in ./bin/diviner generate.

Gentle reminder that this has been waiting review for a while now...

Aug 10 2023, 16:35
Sten added a comment to D25334: Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error.

Gentle reminder that this has been waiting review for a while now...

Aug 10 2023, 16:35
Sten added a comment to D25333: Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors.

Gentle reminder that this has been waiting review for a while now...

Aug 10 2023, 16:35
Sten added a comment to D25323: Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector().

Gentle reminder that this has been waiting review for a while now...

Aug 10 2023, 16:35

Aug 9 2023

Sten added a comment to T15596: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in configuration.

What was your strategy to locate strlen(null) issue without any stacktrace, manual code analysis ?

'git grep' to find where the error page was generated, then adding the missing phlog($ex) to get the stack trace.

Aug 9 2023, 11:03 · PHP 8 support

Aug 8 2023

Sten added a comment to T15596: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in configuration.

Testing with my PHP 8.1, I can't replicate this. But I do have a bunch of PHP 8.1 fixes in place which are still awaiting approval.

Aug 8 2023, 23:05 · PHP 8 support
Sten accepted D25078: Trigger: Capitalize most Buzzwords in our Weird Way as usual.

Apart from the pre-existing 'Statues' typo, looks good to me...

Aug 8 2023, 10:59

Aug 7 2023

Sten added a comment to T15586: arcanist EXCEPTION: (CommandException) Command failed with error #-1!.

The issue is in a change which went in with PHP 8.1.22, and is being reverted in PHP 8.1.23.
@aklapper - as PHP 8.2.9 isn't released yet, I assume you compiled from source? If you 'git pull' and recompile, the latest 8.2.9-dev should work. The fix was committed Aug 2 21:08:52.

Aug 7 2023, 09:35

Aug 4 2023

Sten closed T15586: arcanist EXCEPTION: (CommandException) Command failed with error #-1! as Wontfix.
Aug 4 2023, 08:04
Sten added a comment to T15586: arcanist EXCEPTION: (CommandException) Command failed with error #-1!.

Raised PHP bug https://github.com/php/php-src/issues/11871

Aug 4 2023, 08:02
First
Prev
Next
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0