In T15640#19898, @valerio.bozzolan wrote:

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

The current workaround I'm proposing is just:

BTW I think the page is reached by a crawler that is visiting a branch root on a specific commit:

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

Finally got a reproducer URI in downstream:

• Broken: https://phabricator.wikimedia.org/diffusion/OSWB/branches/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (branches in URI).
• Works: https://phabricator.wikimedia.org/diffusion/OSWB/browse/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (browse in URI).

Digging deeper, the problem is specific to ProjectRemarkupRule::getObjectIDPattern. That returns:

Step 2: Remove irrelevant character class exclusions:

Disentangling that monster regex, step 1:

Indeed https://devina.io/redos-checker says the aformentioned regex is exponential time worst-case

I monkeypatched the code to print preg_last_error when the problematic preg_match returns null. The error is "Backtrack limit exhausted".

This exception happens once $rule in the loop foreach ($this->getMarkupRules() as $rule) in PhutilRemarkupBlockRule::applyRules($text) becomes ProjectRemarkupRule. That's where it blows up.

Maybe interesting, there is this different non-deprecated API:

This is an issue in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php . In getObjectEmbedPattern(), preg_quote($prefix) returns \# and the method finally returns (\B{\#([^.\s?!,:;{}#\(\)"'\*/~]+(?:[^\s?!,:;{}#\(\)"'\*/~]*[^.\s?!,:;{}#\(\)"'\*/~]+)*)([,\s](?:[^}\\]|\\.)*)?}\B)u.
Within apply($text), $text becomes null after that first preg_replace_callback, so the second call barks.

I'm not skilled enough to look into the bigger picture, however maybe the Edit Column dialog could have a third field apart from Name and Point Limit to also have Task Limit (or Card Limit?). Point Limit and Task Limit then must be mutually exclusive (do not allow to set both for a column, or even...board?), somehow.

I do not (yet?) understand the use case of this task.

Indeed reported from a Wikimedia user about Wikimedia Phabricator.

It seems to me that this problem can be solved with an additional setting that turns this functionality on or off.

It might not happen on any other card, because we might not be rendering Remarkup on any other card. Interesting....

So this is quite an edge-case:

• PhabricatorMentionRemarkupRule wants to give the mention a different color, depending on if the user can view the "context object", in this case the Project.
• There's an automatic rule, saying a member of a project can always view the project
• When loading the project for the hovercard, we don't bother loading all the member list
• When loading the user for the mention, we don't bother loading all its projects
• so data is not available at the rendering point.

Another good simple candidate GDPR-friendly:

Ouch

Also note that we have a similar PhabricatorDataNotAttachedException in PhabricatorRepositoryCommit (via getRepository()) in downstream https://phabricator.wikimedia.org/T360714. It's without reproduction steps but sounds a bit similar.

Maybe unrelated. But after we fix PhabricatorCursorPagedPolicyAwareQuery, maybe we will find a crash test also for the first two lines:

Interestingly I was able to reproduce, but only creating 101+ tasks manually and going to the next page. So after that ?after=100 is introduced.

Here's another one that I think deserves to be upstreamed: https://phabricator.wikimedia.org/T230787 adds context and search term highlights to fulltext search results. Currently Phorge and upstream Phabricator only show matching document titles with highlights on keywords in the title but not the body.
The efficiency of my solution is questionable, however, it's working well enough for Wikimedia's use of the feature.

there is a presentation from eric brechner, who was in microsofts xbox development, about kanban. he does it on whiteboard, extremely sinple:
https://www.youtube.com/watch?v=CD0y-aU1sXo

Translatewiki finally processed the rebrand a few days ago, as part of https://phabricator.wikimedia.org/T318763

Probably this was moved?

Cool. Two things:

Other edges have probably been eliminated in the past. For example this one:

Interestingly I was able to reproduce the issue with this nonsense patch, in the hope to emulate an email plain-text generation, even if it's not the case:

For interesting reasons, I cannot, in any way, get an email about somebody renaming a single Mockup photo. And, my email preferences are like "email me for everything from every application" and email delivery is "email me about myself".

Initially, the task is in the project's default column:

MariaDB [phabricator_project]> SELECT cp.id, p.name AS projectName, cp.boardPHID, c.name AS columnName, cp.columnPHID FROM project_columnposition cp INNER JOIN project_column c ON cp.columnPHID = c.phid INNER JOIN phabricator_project.project p ON cp.boardPHID = p.phid WHERE objectPHID ="PHID-TASK-f6ri2kdpcvtb3yncho2n";
+-----+----------------+--------------------------------+------------+--------------------------------+
| id  | projectName    | boardPHID                      | columnName | columnPHID                     |
+-----+----------------+--------------------------------+------------+--------------------------------+
| 509 | T139396-parent | PHID-PROJ-yt43plz2cxlidyu4dlia | Backloggg  | PHID-PCOL-no7jbin6vngwkrghrmrk |
+-----+----------------+--------------------------------+------------+--------------------------------+

In T15653#13929, @valerio.bozzolan wrote:

Yeah so we are all for "let's just append as default and maybe think about something more for the future, if they ask"

Yeah so we are all for "let's just append as default and maybe think about something more for the future, if they ask"

What if it were possible to intentionally remove a tag by passing the tag prepended with - to signify removal? like ?tags=-ABCDE to remove a tag but otherwise the behavior would be to just append. I realize this doesn't have the same compatibility advantages but it does offer slightly more flexibility for use in ad-hoc workflows.

Thanks for reporting.

I've probably understood what is going on here

I triage this to Wishlist since it's indeed useful to some people but it's somehow still controversial. In order to attract more eyes, adding also Discussion Needed.

It's a Git repository branch called 201709 (see downstream) but still no idea how to trigger the exception.
If anyone has an idea what to do to reach code in DiffusionRequest::generateURI() or DiffusionCommitBranchesController, please share.