In D25905#24572, @aklapper wrote:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mar 16 2025
Mar 16 2025
Cigaryno added a comment to D25905: Remove No Prototype Changes section from Contributing Code document.
aklapper added a comment to D25905: Remove No Prototype Changes section from Contributing Code document.
Obsoleted by D25909: Diviner: Contributing Code: Update section on Prototype Changes. I think @aklapper should have instead commandeered this rev but it's still okay to have a new revision instead.
Mar 7 2025
Mar 7 2025
Cigaryno planned changes to D25905: Remove No Prototype Changes section from Contributing Code document.
valerio.bozzolan added a comment to D25905: Remove No Prototype Changes section from Contributing Code document.
In the meanwhile I paste here a proposed alternative that may better reflect the current situation (no need to update the patch - since I guess this phrase will attract more changes):
valerio.bozzolan added a comment to D25905: Remove No Prototype Changes section from Contributing Code document.
I agree on discussing the removal of this phrase. I will wait the task, but my opinion is that it's a legacy phrase from a company that had better to do than fixing weird workflows based on Prototypes (and it had sense). But now it's a community and we already work on best effort on everything, including prototypes. Moreover that phrase does not reflect the current situation, since we triaged and fixed 6 bugs on the Calendar prototype Calendar (even if it should be un-prototyped one day) - and probably more evident already-reviewed patches.
avivey added a comment to D25905: Remove No Prototype Changes section from Contributing Code document.
@Cigaryno please create a task under Discussion Needed for this - I'm not sure we want to make this policy change.
Mar 6 2025
Mar 6 2025
Cigaryno updated the summary of D25905: Remove No Prototype Changes section from Contributing Code document.
Cigaryno updated the diff for D25905: Remove No Prototype Changes section from Contributing Code document.
Fix the typo in line 167
Cigaryno planned changes to D25905: Remove No Prototype Changes section from Contributing Code document.
Cigaryno requested review of D25905: Remove No Prototype Changes section from Contributing Code document.
Feb 17 2025
Feb 17 2025
aklapper updated the task description for T15982: Update the documentation for "Adding New CSS and JS" to not exclude extensions.
Jan 31 2025
Jan 31 2025
amybones added a comment to T15982: Update the documentation for "Adding New CSS and JS" to not exclude extensions.
A comment in two parts:
First and most relevant to this task: It certainly would be nice to get some of this into documentation! It took me quite awhile to figure this out when doing my own extension development.
Dec 29 2024
Dec 29 2024
Dec 25 2024
Dec 25 2024
Nov 5 2024
Nov 5 2024
valerio.bozzolan closed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies as Wontfix.
Probably not enough consensus for a mass edit. Best we can do is case-by-case fixes reading warn reports.
Sep 14 2024
Sep 14 2024
Sep 9 2024
Sep 9 2024
Aug 4 2024
Aug 4 2024
Jun 28 2024
Jun 28 2024
valerio.bozzolan updated the task description for T15870: Provide documentation for Javelin scry, find, and findAbove.
Jun 27 2024
Jun 27 2024
(re-opening, there's more work left here)
Jun 26 2024
Jun 26 2024
mturdus closed T15401: Make the Remarkup Help Page Extensible as Resolved by committing rPf52bc073216e: Make the Remarkup Help Page Extensible.
Jun 23 2024
Jun 23 2024
Apr 4 2024
Apr 4 2024
Feb 13 2024
Feb 13 2024
Feb 12 2024
Feb 12 2024
sirocyl added a comment to T15737: Include information for installing required PHP version in Diviner docs.
On it, thank you!
valerio.bozzolan added a comment to T15737: Include information for installing required PHP version in Diviner docs.
My friend, I think you are affected by this change, and this applies to whatever PHP version
sirocyl added a comment to T15737: Include information for installing required PHP version in Diviner docs.
I'm on the latest pull, commit f81e821abf2b275d1778d02a018a4d0af7208be8.
A bit off topic here :) but I'll quickly sum up the issue I'm having (and am in the middle of trying things to fix):
- Visiting https://[phorge instance]/auth/config/view/2/, where my Github auth item is, makes nginx dump a blank 502 page, no further info.
- First instinct is to check the /var/log/nginx/error.log, where I get a PHP stack trace concatenated into one line, and an nginx header length error (reformatted for readability. the PHP error is truncated):
avivey added a comment to T15737: Include information for installing required PHP version in Diviner docs.
Oh, totally possible that I forgot to update it :)
sirocyl added a comment to T15737: Include information for installing required PHP version in Diviner docs.
I'll take your word on it that it's supported, though the current installation guide says otherwise.
Further, I had a few roadbumps on a fresh install to a new server with PHP 8, that I suspect may relate to strlen(NULL) behavior, but I did need to set up PHP 7 to make sure that was or wasn't the case.
(I'm in the process of reproducing those and working out a possible cause or trace. Some manifested as warning banners, one as a 502 on my end in the GitHub auth provider.)
avivey added a comment to T15737: Include information for installing required PHP version in Diviner docs.
We already support PHP 8...
sirocyl updated the task description for T15737: Include information for installing required PHP version in Diviner docs.
sirocyl updated the task description for T15737: Include information for installing required PHP version in Diviner docs.
Dec 14 2023
Dec 14 2023
Partially related, a systemd unit for the SSH server. Proposal in D25497
Sep 6 2023
Sep 6 2023
While it could be nice to have this, in the meanwhile I think that having something minimal like D25434 would be nice
Aug 30 2023
Aug 30 2023
I'm Valerio, a simple person: I see "GNU/Linux" and I say "yeah, land".
Aug 29 2023
Aug 29 2023
Jul 18 2023
Jul 18 2023
Jul 8 2023
Jul 8 2023
avivey renamed T15401: Make the Remarkup Help Page Extensible from Add Documentation about Figlet and Cowsay to Make the Remarkup Help Page Extensible.
Jun 29 2023
Jun 29 2023
Cigaryno moved T15015: Remove or clean up references to libphutil in the documentation from Backlog to Removal/Cleanup on the Documentation board.
Cigaryno added a project to T15015: Remove or clean up references to libphutil in the documentation: Documentation.
Jun 23 2023
Jun 23 2023
valerio.bozzolan closed T15467: Document a systemd daemon as Resolved by committing rPa25af8ccef69: Diviner: add a minimal systemd example.
Jun 16 2023
Jun 16 2023
valerio.bozzolan moved T15467: Document a systemd daemon from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Jun 14 2023
Jun 14 2023
valerio.bozzolan added a revision to T15467: Document a systemd daemon: D25293: Diviner: add a minimal systemd example.
This is a nice contribution and definitely would be a valuable addition to the docs, IMO.
Jun 12 2023
Jun 12 2023
valerio.bozzolan added projects to T15467: Document a systemd daemon: Documentation, User-valerio.bozzolan.
valerio.bozzolan placed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies up for grabs.
I honestly have nothing more to be done here. I would like to set as resolved but there are sub-tasks opened
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Jun 10 2023
Jun 10 2023
May 25 2023
May 25 2023
valerio.bozzolan added a comment to D25108: PHP Pitfalls: mention strlen() deprecation since PHP 8.1.
Note that I like to do NOT mention the stuff phutil_nonempty_stringlike() since it causes extra headaches with incoming objects to many friends. Same for its friend phutil_nonempty_scalar() since it's broken with known scalars (T15239).
valerio.bozzolan updated the diff for D25108: PHP Pitfalls: mention strlen() deprecation since PHP 8.1.
avoid unuseful tables
valerio.bozzolan updated the summary of D25108: PHP Pitfalls: mention strlen() deprecation since PHP 8.1.
valerio.bozzolan updated the diff for D25108: PHP Pitfalls: mention strlen() deprecation since PHP 8.1.
mention the cast thing
valerio.bozzolan updated the diff for D25108: PHP Pitfalls: mention strlen() deprecation since PHP 8.1.
mention the cast thing
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
May 12 2023
May 12 2023
valerio.bozzolan added inline comments to D25108: PHP Pitfalls: mention strlen() deprecation since PHP 8.1.
Apr 28 2023
Apr 28 2023
Apr 19 2023
Apr 19 2023
Apr 14 2023
Apr 14 2023
valerio.bozzolan renamed T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies from PHP 8.1: strlen() does not accept NULL anymore - understand fix strategies to PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
valerio.bozzolan updated the task description for T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Apr 7 2023
Apr 7 2023
valerio.bozzolan added a comment to T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.
Basically phutil_nonempty_scalar() cannot be used since, instead of returning false when receiving false, it explodes.
Apr 6 2023
Apr 6 2023
valerio.bozzolan retitled D25108: PHP Pitfalls: mention strlen() deprecation since PHP 8.1 from Documentation: mention strlen() deprecation since PHP 8.1
valerio.bozzolan added a comment to D25108: PHP Pitfalls: mention strlen() deprecation since PHP 8.1.
If you need a preview:
avivey edited projects for T15179: Diffusion: fix support for git version 1.8.3.1 ("This path was a submodule at ...") - probably since git < 2.5.0, added: Diffusion; removed Diffusion (archived).
Apr 3 2023
Apr 3 2023
Mar 28 2023
Mar 28 2023
Mar 27 2023
Mar 27 2023
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0