The other option would be including "__form__":"1" in that call to avoid the 400.
Feed All Stories
Jul 15 2024
Jul 15 2024
aklapper requested review of D25733: Do not throw Aphront400Response when editing a task.
aklapper added a comment to T15866: Aphront400Response when editing a task.
aklapper updated the summary of D25672: Allow collapsing/expanding workboard column content by clicking its header.
👍👍
aklapper committed rP03092ca42202: Removed unused loadGitLocalRefs() from PhabricatorRepositoryPullEngine.
Removed unused loadGitLocalRefs() from PhabricatorRepositoryPullEngine
valerio.bozzolan added inline comments to D25569: Avoid separate per-line URIs in line number column.
valerio.bozzolan requested changes to D25569: Avoid separate per-line URIs in line number column.
valerio.bozzolan accepted D25718: Removed unused loadGitLocalRefs() from PhabricatorRepositoryPullEngine.
Jul 14 2024
Jul 14 2024
aklapper committed rP5a454cef8a98: Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE.
Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE
aklapper added a comment to D25732: Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE.
valerio.bozzolan accepted D25732: Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE.
- was this improving the situation? rPf4d9d6920bcd: The feed "created this task" should be the first one seems yes, accordingly to your comments
- was PhabricatorTransactions::TYPE_CREATE needing a nice action name? yes
- Am I confused about newActionStrengthSortVector? Yes. I don't know why it works, but it works. But this deserves further discussion.
TylerMS887 updated TylerMS887.
Jul 13 2024
Jul 13 2024
aklapper requested review of D25732: Set ActionName to "Created" for PhabricatorTransactions::TYPE_CREATE.
aklapper added a comment to T15865: [Regression] Incorrect mail subject header [Updated] instead of [Created].
Applying the debug patch in P45, output when creating a new task shows that Updated (defined in https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/storage/PhabricatorApplicationTransaction.php;877ac8a873f979f418064eb2f36f1148c9838694$1611-1612) wins over Created (defined in https://we.phorge.it/source/phorge/browse/master/src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php;877ac8a873f979f418064eb2f36f1148c9838694$24) as ActionName, likely due to rPf4d9d6920bcdcafedd6a05f34c28642589b3c285 :
[0] PHLOG: 'PATE: TransactionType: core:create' at [/var/www/html/phorge/phorge/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1625] PHLOG: 'PAT: TA Type: core:create' at [/var/www/html/phorge/phorge/src/applications/transactions/storage/PhabricatorApplicationTransaction.php:1601] PHLOG: 'PATE: ActionName: Updated' at [/var/www/html/phorge/phorge/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1626] PHLOG: 'PATE: ActionStrength: 140' at [/var/www/html/phorge/phorge/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1627]
Remarkup documentation added
Remarkup documentation added
Jul 12 2024
Jul 12 2024
valerio.bozzolan closed T15883: Column "Move to Project": make it working for Milestones (instead of "You must choose a project with a workboard") as Invalid.
OK I'm stupid. I just need to visit the Milestone and create a Workboard.
valerio.bozzolan updated the task description for T15883: Column "Move to Project": make it working for Milestones (instead of "You must choose a project with a workboard").
Fix property name typo in PhabricatorPDFIterator
valerio.bozzolan added inline comments to D25502: Make PhabricatorSearchIntField validate its input.
valerio.bozzolan added inline comments to D25502: Make PhabricatorSearchIntField validate its input.
Seems that nothing internally accessed that method, and probably nothing externally. But we should probably keep that method since it's public. Thanks.
I was still able to generate QR codes, and I verified with alternative application "Barcode Scanner" that the desired URL is read.
valerio.bozzolan edited the content of Next Up.
valerio.bozzolan added a comment to T15882: When archiving a project, reset its default menu item to Profile.
Premising that the root problem is that it's difficult to understand if a project is archived just looking at other parts.
valerio.bozzolan triaged T15882: When archiving a project, reset its default menu item to Profile as Wishlist priority.
valerio.bozzolan accepted D25731: Set default menu item to Project Details when archiving a project.
Thanks. Feature makes sense and implementation seems good (but I have untested).
Jul 11 2024
Jul 11 2024
aklapper updated the task description for T15882: When archiving a project, reset its default menu item to Profile.
aklapper requested review of D25731: Set default menu item to Project Details when archiving a project.
aklapper added a revision to T15378: PhabricatorApplicationTransactionStructureException trying to mute File notifications: "Attempting to apply a transaction which has not been constructed correctly": D25730: Avoid PhabricatorApplicationTransactionStructureException on editors not supporting Mute Notifications.
• s.quinn closed Q143: Upgrading from Phabricator as resolved.
avivey removed a project from T15705: Lower the search ranking of disabled user accounts: Discussion Needed.
I think we're all aligned here...
aklapper closed T15881: PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
aklapper committed rP59428f64ca2c: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView
aklapper retitled D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView from Fix PHP 8.1 "strlen(null)" exception rendering AphrontStackTraceView
Jul 10 2024
Jul 10 2024
😆
aklapper updated the diff for D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
Eh, the PHP pitfalls that I'll never learn by heart... Thanks! :)
Let's try if ($file !== null && $file !== '') instead of if ($file) then?
avivey added a comment to Q143: Upgrading from Phabricator (Answer 179).
The best way is probably to make an Extension:
aklapper committed rPc4246cf871a7: Remove unreachable return statement in AphrontFormDateControlValue.
Remove unreachable return statement in AphrontFormDateControlValue
aklapper requested review of D25729: Remove unreachable return statement in AphrontFormDateControlValue.
Declare missing class property in PhabricatorTimelineEngine
aklapper closed T15876: Update external timezone information file to 2024a as Resolved by committing rP3fbb0309b53f: Update external timezone information to IANA TZDB 2024a.
Update external timezone information to IANA TZDB 2024a
aklapper committed rPd9592e034812: Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine.
Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine
valerio.bozzolan accepted D25719: Removed unused validateNavigationMenuItem() from PhabricatorProfileMenuEngine.
valerio.bozzolan retitled D25722: Update external timezone information to IANA TZDB 2024a from Update external timezone information to 2024a
• s.quinn added a comment to Q143: Upgrading from Phabricator (Answer 179).
Thanks for the confirmation!
valerio.bozzolan updated the diff for D25305: Workboard: have thin scrollbars.
git rebase master (again)
valerio.bozzolan attached a referenced file: F312320: Screenshot 2023-06-20 at 07-26-08 Maniphest · Workboard.png.
valerio.bozzolan attached a referenced file: F312321: Screenshot 2023-06-20 at 07-27-41 Editing-team (Kanban Board) · Workboard.png.
valerio.bozzolan attached a referenced file: F312322: Screenshot 2023-06-20 at 07-31-57 Maniphest · Workboard.png.
valerio.bozzolan attached a referenced file: F312323: Screenshot 2023-06-20 at 07-32-20 Editing-team (Kanban Board) · Workboard.png.
Sorry for waiting.
valerio.bozzolan updated the diff for D25305: Workboard: have thin scrollbars.
git rebase master
Declare missing class properties in ArcanistDownloadWorkflow
Correct PHPDoc of dropSymbolCache()
aklapper committed rPff7be2cf1444: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest()
Set specific timeline title for form creation
speck added a comment to D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
This might regress the case where file is “0”
Jul 9 2024
Jul 9 2024
aklapper updated the summary of D25728: Fix PHP 8.1 "file_exists(null)" exception rendering AphrontStackTraceView.
aklapper updated the diff for D25727: Fix invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
Restore an empty line
aklapper added a comment to T15874: Invalid logic in PhabricatorEmailPreferencesSettingsPanel::processRequest().
This broken code is intended to find MailTags (means: each entry listed under http://phorge.localhost/settings/panel/emailpreferences/ , grep for const MAILTAG_ to get a list of them) defined more than once to display them in a Common section on top:
However, as currently all MailTags are prefixed with their application (examples: phame-post-content, vote:responses, maniphest-owner) there is nothing to display anyway.